From: Jakub Narebski <jnareb@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Bill Pemberton <wfp5p@virginia.edu>, git@vger.kernel.org
Subject: Re: [PATCH v2] blame: add a range option to -L
Date: Tue, 04 May 2010 10:48:31 -0700 (PDT) [thread overview]
Message-ID: <m3bpcvftjk.fsf@localhost.localdomain> (raw)
In-Reply-To: <7vd3xbmv4w.fsf@alter.siamese.dyndns.org>
Junio C Hamano <gitster@pobox.com> writes:
> I wonder if it makes the interface more consistent to rewrite the
> above comment like this:
>
> /*
> * Allow "-L <something>,+20" to mean starting at <something>
> * for 20 lines; "-L <something>,-5" for 5 lines ending at
> * <something>; and "-L <something>,+-5" for 5 lines around
> * <something>.
> */
>
> and the match the code.
I like this.
The other approach would be to use -B <num> / -A <num> / -C [num], -<num>
convention from 'grep'... but git-blame uses -C and -<num> for other
things.
--
Jakub Narebski
Poland
ShadeHawk on #git
next prev parent reply other threads:[~2010-05-04 17:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-03 18:06 [PATCH v2] blame: add a range option to -L Bill Pemberton
2010-05-03 18:23 ` Michael Witten
2010-05-04 17:31 ` Junio C Hamano
2010-05-04 17:48 ` Jakub Narebski [this message]
2010-05-04 18:11 ` Matthieu Moy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3bpcvftjk.fsf@localhost.localdomain \
--to=jnareb@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=wfp5p@virginia.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).