From: Jakub Narebski <jnareb@gmail.com>
To: Jeff King <peff@peff.net>
Cc: Philip Hofstetter <phofstetter@sensational.ch>, git@vger.kernel.org
Subject: Re: git-mailinfo doesn't stop parsing at the end of the header
Date: Wed, 18 Nov 2009 09:46:43 -0800 (PST) [thread overview]
Message-ID: <m3bpizd8ua.fsf@localhost.localdomain> (raw)
In-Reply-To: <20091118172424.GA24416@coredump.intra.peff.net>
Jeff King <peff@peff.net> writes:
> I also think "git commit" would not be the right time for such a
> feature. The problem is not that you have this text in your commit
> message. The problem is that the "format-patch | am" transport is lossy.
> You would do better to have format-patch say "Ah, this is going to
> create a bogus email address" and somehow quote it appropriately.
Doesn't mbox format have some way of escaping "From:" (or is it "From ")?
If I remember correctly it uses ">From " or something for that.
git-format-patch could do this also (perhaps only with --rebasing
option).
P.S. As git-format-patch / git-am have hidden --rebasing option,
perhaps git-mailinfo should have it as well (even if it is called
--strict).
--
Jakub Narebski
Poland
ShadeHawk on #git
next prev parent reply other threads:[~2009-11-18 17:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-18 14:20 git-mailinfo doesn't stop parsing at the end of the header Philip Hofstetter
2009-11-18 15:51 ` Jeff King
2009-11-18 16:42 ` Jeff King
2009-11-18 22:45 ` [PATCH] git am/mailinfo: Don't look at in-body headers when rebasing Lukas Sandström
2009-11-18 23:47 ` Philip Hofstetter
2009-11-19 8:51 ` [PATCH v2] " Lukas Sandström
2009-11-19 15:36 ` Jeff King
2009-11-20 16:12 ` [PATCH] " Lukas Sandström
2009-11-18 17:11 ` git-mailinfo doesn't stop parsing at the end of the header Philip Hofstetter
2009-11-18 17:24 ` Jeff King
2009-11-18 17:46 ` Jakub Narebski [this message]
2009-11-18 18:42 ` Jeff King
2009-11-18 19:57 ` Philip Hofstetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3bpizd8ua.fsf@localhost.localdomain \
--to=jnareb@gmail.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=phofstetter@sensational.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).