From: Jakub Narebski <jnareb@gmail.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] perl/Makefile: Unset INSTALL_BASE when making perl.mak
Date: Tue, 03 Aug 2010 04:16:40 -0700 (PDT) [thread overview]
Message-ID: <m3d3u0osjo.fsf@localhost.localdomain> (raw)
In-Reply-To: <1280831411-4511-1-git-send-email-avarab@gmail.com>
Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
> PREFIX and INSTALL_BASE are mutually exclusive. If both are supplied
> by INSTALL_BASE being set in PERL_MM_OPT ExtUtils::MakeMaker will
> produce an error:
>
> $ echo $PERL_MM_OPT
> INSTALL_BASE=/home/avar/perl5
> $ make -C perl PERL_PATH='/usr/bin/perl' prefix='/home/avar' perl.mak
> make: Entering directory `/home/avar/g/git/perl'
> /usr/bin/perl Makefile.PL PREFIX='/home/avar'
> Only one of PREFIX or INSTALL_BASE can be given. Not both.
> make: *** [perl.mak] Error 255
> make: Leaving directory `/home/avar/g/git/perl'
>
> Change the perl Makefile to work around this by explicitly unsetting
> INSTALL_BASE.
>
> INSTALL_BASE is set in PERL_MM_OPT by e.g. the popular local::lib
> package, from its documentation:
>
> eval $(perl -I$HOME/perl5/lib/perl5 -Mlocal::lib 2>/dev/null)
>
> Many other environments might also have set PERL_MM_OPT before
> building Git. This change enables us to build in these environments.
>
> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Great! I really appreciate this, using local::lib myself.
--
Jakub Narebski
Poland
ShadeHawk on #git
next prev parent reply other threads:[~2010-08-03 11:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-03 10:30 [PATCH] perl/Makefile: Unset INSTALL_BASE when making perl.mak Ævar Arnfjörð Bjarmason
2010-08-03 11:16 ` Jakub Narebski [this message]
2010-08-12 2:48 ` [PATCH v2/pu] " Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3d3u0osjo.fsf@localhost.localdomain \
--to=jnareb@gmail.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).