From: Jakub Narebski <jnareb@gmail.com>
To: Mark Rada <markrada26@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [RFC] Gitweb: include minified version of js and css files in the repo
Date: Sat, 13 Mar 2010 00:26:51 -0800 (PST) [thread overview]
Message-ID: <m3d3z8lj9x.fsf@localhost.localdomain> (raw)
In-Reply-To: <1B527F20-CF6C-451B-9C6E-1BE74992354D@gmail.com>
Mark Rada <markrada26@gmail.com> writes:
> I was catching up on the changes to gitweb changes in the
> last little while and I noticed an option to pass gitweb.js
> through a minifier during the make execution, which I thought
> was pretty cool.
>
> However, I was wondering if there were any reasons why the
> minified version of the javascript code was not distributed
> in the git repository? It seems like you are leaving that
> effort to be duplicated a lot by people who compile git
> themselves.
The reason is that one should not include *generated* files in
version control. We do not include ./configure script (from
configure.ac), we do not include gitweb.min.js (from gitweb.js).
--
Jakub Narebski
Poland
ShadeHawk on #git
next prev parent reply other threads:[~2010-03-13 8:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-13 4:31 [RFC] Gitweb: include minified version of js and css files in the repo Mark Rada
2010-03-13 8:26 ` Jakub Narebski [this message]
2010-03-14 13:22 ` Miklos Vajna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3d3z8lj9x.fsf@localhost.localdomain \
--to=jnareb@gmail.com \
--cc=git@vger.kernel.org \
--cc=markrada26@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).