From: Jakub Narebski <jnareb@gmail.com>
To: Jari Aalto <jari.aalto@cante.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Documentation/config.txt: Order variables alphabetically
Date: Wed, 01 Dec 2010 05:58:45 -0800 (PST) [thread overview]
Message-ID: <m3eia14mu7.fsf@localhost.localdomain> (raw)
In-Reply-To: <1291209174-9239-1-git-send-email-jari.aalto@cante.net>
jari.aalto@cante.net writes:
> From: Jari Aalto <jari.aalto@cante.net>
>
>
> Signed-off-by: Jari Aalto <jari.aalto@cante.net>
> ---
> Documentation/config.txt | 1698 +++++++++++++++++++++++-----------------------
> 1 files changed, 852 insertions(+), 846 deletions(-)
Why? What such large change is for?
Note that currently config variables are grouped by functionality: for
example core.eol and core.safecrlf, or core.compression and
core.loosecompression are close to each other.
I like the fact that we have first advice.*, then core.*, then mostly
alphabetically sorted rest of configuration variables.
> diff --git a/Documentation/config.txt b/Documentation/config.txt
> index 6a6c0b5..6e92623 100644
> --- a/Documentation/config.txt
> +++ b/Documentation/config.txt
> @@ -142,313 +142,251 @@ advice.*::
> detachedHead::
> Advice shown when you used linkgit::git-checkout[1] to
> move to the detach HEAD state, to instruct how to create
> - a local branch after the fact. Default: true.
> + a local branch after the fact. Default: true.
This change has nothing to do with ordering variables alphabetically,
therefore IMHO it belongs in separate patch.
[...]
--
Jakub Narebski
Poland
ShadeHawk on #git
next prev parent reply other threads:[~2010-12-01 13:59 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-01 13:12 [PATCH] Documentation/config.txt: Order variables alphabetically jari.aalto
2010-12-01 13:58 ` Jakub Narebski [this message]
2010-12-01 14:34 ` jari
[not found] ` <20101201142920.GB6537@picasso.cante.net>
2010-12-01 14:57 ` Jakub Narebski
2010-12-01 15:09 ` jari
2010-12-01 15:19 ` Erik Faye-Lund
2010-12-01 15:33 ` Jari Aalto
2010-12-01 15:37 ` Jari Aalto
2010-12-01 16:37 ` Jakub Narebski
2010-12-01 17:10 ` Jari Aalto
2010-12-01 18:03 ` Jeff King
2010-12-01 23:38 ` Jakub Narebski
2010-12-02 1:02 ` SZEDER Gábor
2010-12-02 5:43 ` Jari Aalto
2010-12-02 9:32 ` SZEDER Gábor
2010-12-02 5:46 ` Jari Aalto
2010-12-02 9:24 ` SZEDER Gábor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3eia14mu7.fsf@localhost.localdomain \
--to=jnareb@gmail.com \
--cc=git@vger.kernel.org \
--cc=jari.aalto@cante.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).