git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Narebski <jnareb@gmail.com>
To: Bruno Ribas <ribas@c3sl.ufpr.br>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] contrib/hooks/post-receive-email: checks for gitweb.description
Date: Mon, 11 Feb 2008 13:20:21 -0800 (PST)	[thread overview]
Message-ID: <m3ejbjdwc6.fsf@localhost.localdomain> (raw)
In-Reply-To: <1202760138-24227-1-git-send-email-ribas@c3sl.ufpr.br>

Bruno Ribas <ribas@c3sl.ufpr.br> writes:

Here it would be nice to have longer description, like:

  Check repository configuration gitweb.description for project
  description, if $GIT_DIR/description does not exist

Note that 'description' file is created by default when creating
repository by git-init by default repo template.

> Signed-off-by: Bruno Ribas <ribas@c3sl.ufpr.br>
> ---
>  contrib/hooks/post-receive-email |    6 +++++-
>  1 files changed, 5 insertions(+), 1 deletions(-)
> 
> diff --git a/contrib/hooks/post-receive-email b/contrib/hooks/post-receive-email
> index 77c88eb..bdd21fa 100644
> --- a/contrib/hooks/post-receive-email
> +++ b/contrib/hooks/post-receive-email
> @@ -614,7 +614,11 @@ if [ -z "$GIT_DIR" ]; then
>  	exit 1
>  fi
>  
> -projectdesc=$(sed -ne '1p' "$GIT_DIR/description")
> +if [ -f "$GIT_DIR/description" ]; then
> +	projectdesc=$(sed -ne '1p' "$GIT_DIR/description")
> +else
> +	projectdesc=$(git-config gitweb.description)

The rest of this hook use "git cmd". Preferred way to call git
commands is "git cmd". So I would use

  "git config gitweb.description"

> +fi
>  # Check if the description is unchanged from it's default, and shorten it to
>  # a more manageable length if it is
>  if expr "$projectdesc" : "Unnamed repository.*$" >/dev/null
> -- 
> 1.5.4.24.gce08d
> 

-- 
Jakub Narebski
Poland
ShadeHawk on #git

  reply	other threads:[~2008-02-11 21:21 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-11 20:02 [PATCH] contrib/hooks/post-receive-email: checks for gitweb.description Bruno Ribas
2008-02-11 21:20 ` Jakub Narebski [this message]
2008-02-11 21:49   ` BRUNO CESAR RIBAS
  -- strict thread matches above, loose matches on Subject: below --
2008-02-12  3:25 Bruno Ribas
2008-02-12  8:17 ` Jakub Narebski
2008-02-13  0:24   ` Bruno Cesar Ribas
2008-02-18  3:46     ` Bruno Cesar Ribas
2008-02-18  6:03       ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3ejbjdwc6.fsf@localhost.localdomain \
    --to=jnareb@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=ribas@c3sl.ufpr.br \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).