Git development
 help / color / mirror / Atom feed
From: Jakub Narebski <jnareb@gmail.com>
To: Rafael Gieschke <rafael@gieschke.de>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCHv2] compat: add a getpass() compatibility function
Date: Mon, 23 May 2011 10:59:49 -0700 (PDT)	[thread overview]
Message-ID: <m3fwo5z4bi.fsf@localhost.localdomain> (raw)
In-Reply-To: <0301451F-9998-4208-8CE0-82B095DD5D32@gieschke.de>

Rafael Gieschke <rafael@gieschke.de> writes:

> If NO_GETPASS is set, getpass is provided in compat/getpass.c from
> http://git.uclibc.org/uClibc/plain/libc/unistd/getpass.c
> (getpass() was renamed to gitgetpass()).
> 
> Signed-off-by: Rafael Gieschke <rafael@gieschke.de>
> ---
>  Makefile          |    6 +++
>  compat/getpass.c  |   98 +++++++++++++++++++++++++++++++++++++++++++++++++++++
>  git-compat-util.h |    5 +++
>  3 files changed, 109 insertions(+), 0 deletions(-)
>  create mode 100644 compat/getpass.c

Thanks.  What is missing is optional automatic detection of this case,
which means changes to configure.ac and config.mak.in; see e.g. how it
is done for NO_STRLCPY.

-- 
Jakub Narebski
Poland
ShadeHawk on #git

      reply	other threads:[~2011-05-23 18:00 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-19 17:01 [PATCHv2] compat: add a getpass() compatibility function Rafael Gieschke
2011-05-23 17:59 ` Jakub Narebski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3fwo5z4bi.fsf@localhost.localdomain \
    --to=jnareb@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=rafael@gieschke.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox