* [PATCH] Makefile: Fix 'clean' target to remove all gitweb build files
@ 2010-05-08 17:36 Ramsay Jones
2010-05-08 18:07 ` Jakub Narebski
0 siblings, 1 reply; 2+ messages in thread
From: Ramsay Jones @ 2010-05-08 17:36 UTC (permalink / raw)
To: Junio C Hamano; +Cc: GIT Mailing-list
In particular the gitweb/GITWEB-BUILD-OPTIONS file was not being
removed by the main Makefile. However, the gitweb/Makefile has a
'clean' target that correctly removes all the build products.
In order to fix the problem, rather than duplicate the clean-up
instructions, we change the main Makefile so that it delegates
the clean-up actions to the gitweb Makefile.
Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
---
Makefile | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/Makefile b/Makefile
index 910f471..eb1d162 100644
--- a/Makefile
+++ b/Makefile
@@ -2098,7 +2098,7 @@ clean:
$(RM) $(htmldocs).tar.gz $(manpages).tar.gz
$(MAKE) -C Documentation/ clean
ifndef NO_PERL
- $(RM) gitweb/gitweb.cgi gitweb/gitweb.min.*
+ $(MAKE) -C gitweb clean
$(MAKE) -C perl clean
endif
ifndef NO_PYTHON
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Makefile: Fix 'clean' target to remove all gitweb build files
2010-05-08 17:36 [PATCH] Makefile: Fix 'clean' target to remove all gitweb build files Ramsay Jones
@ 2010-05-08 18:07 ` Jakub Narebski
0 siblings, 0 replies; 2+ messages in thread
From: Jakub Narebski @ 2010-05-08 18:07 UTC (permalink / raw)
To: Ramsay Jones; +Cc: Junio C Hamano, GIT Mailing-list
Ramsay Jones <ramsay@ramsay1.demon.co.uk> writes:
> In particular the gitweb/GITWEB-BUILD-OPTIONS file was not being
> removed by the main Makefile. However, the gitweb/Makefile has a
> 'clean' target that correctly removes all the build products.
> In order to fix the problem, rather than duplicate the clean-up
> instructions, we change the main Makefile so that it delegates
> the clean-up actions to the gitweb Makefile.
>
> Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
For what it is worth
Acked-by: Jakub Narebski <jnareb@gmail.com>
> ---
> Makefile | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 910f471..eb1d162 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -2098,7 +2098,7 @@ clean:
> $(RM) $(htmldocs).tar.gz $(manpages).tar.gz
> $(MAKE) -C Documentation/ clean
> ifndef NO_PERL
> - $(RM) gitweb/gitweb.cgi gitweb/gitweb.min.*
> + $(MAKE) -C gitweb clean
> $(MAKE) -C perl clean
> endif
> ifndef NO_PYTHON
> --
> 1.7.1
--
Jakub Narebski
Poland
ShadeHawk on #git
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-05-08 18:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-05-08 17:36 [PATCH] Makefile: Fix 'clean' target to remove all gitweb build files Ramsay Jones
2010-05-08 18:07 ` Jakub Narebski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).