From: Jakub Narebski <jnareb@gmail.com>
To: Matthew Ogilvie <mmogilvi_git@miniinfo.net>
Cc: git@vger.kernel.org, Junio Hamano <gitster@pobox.com>
Subject: Re: [PATCH v2 5/6] run test suite without dashed git-commands in PATH
Date: Tue, 01 Dec 2009 09:24:46 -0800 (PST) [thread overview]
Message-ID: <m3fx7un7vb.fsf@localhost.localdomain> (raw)
In-Reply-To: <1259561971-25730-6-git-send-email-mmogilvi_git@miniinfo.net>
Matthew Ogilvie <mmogilvi_git@miniinfo.net> writes:
> diff --git a/t/README b/t/README
> index 4e1d7dd..8c5d892 100644
> --- a/t/README
> +++ b/t/README
> @@ -75,6 +75,14 @@ appropriately before running "make".
> As the names depend on the tests' file names, it is safe to
> run the tests with this option in parallel.
>
> +--with-dashes::
> + By default tests are run without dashed forms of
> + commands (like git-commit) in the PATH (it only uses
> + wrappers from TOP/git-bin). Use this option to include TOP
> + in the PATH, which conains all the dashed forms of commands.
> + This option is currently implied by other options like --valgrind
> + and GIT_TEST_INSTALLED.
> +
Shouldn't it be 'TOP/bin-wrappers' and not 'TOP/git-bin'?
Shouldn't TOP be explained somewhere, or is it obvious in the context?
s/conains/contains/.
> +else # normal case, use ../bin-wrappers only unless $with_dashes:
--
Jakub Narebski
Poland
ShadeHawk on #git
next prev parent reply other threads:[~2009-12-01 17:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-30 6:19 [PATCH v2 0/6] Run test suite without dashed commands in PATH Matthew Ogilvie
2009-11-30 6:19 ` [PATCH v2 1/6] t2300: use documented technique to invoke git-sh-setup Matthew Ogilvie
2009-11-30 6:19 ` [PATCH v2 2/6] t3409 t4107 t7406: use dashless commands Matthew Ogilvie
2009-11-30 6:19 ` [PATCH v2 3/6] t/README: Document GIT_TEST_INSTALLED and GIT_TEST_EXEC_PATH Matthew Ogilvie
2009-11-30 6:19 ` [PATCH v2 4/6] build dashless "bin-wrappers" directory similar to installed bindir Matthew Ogilvie
2009-11-30 6:19 ` [PATCH v2 5/6] run test suite without dashed git-commands in PATH Matthew Ogilvie
2009-11-30 6:19 ` [PATCH v2 6/6] INSTALL: document a simpler way to run uninstalled builds Matthew Ogilvie
2009-11-30 6:48 ` Junio C Hamano
2009-12-01 17:24 ` Jakub Narebski [this message]
2009-12-02 5:49 ` [PATCH v2 5/6] run test suite without dashed git-commands in PATH Matthew Ogilvie
2009-12-02 6:25 ` Junio C Hamano
2009-11-30 6:28 ` [PATCH v2 4/6] build dashless "bin-wrappers" directory similar to installed bindir Junio C Hamano
2009-12-01 7:33 ` Matthew Ogilvie
2009-11-30 7:16 ` [PATCH v2 0/6] Run test suite without dashed commands in PATH Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3fx7un7vb.fsf@localhost.localdomain \
--to=jnareb@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=mmogilvi_git@miniinfo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).