From: Jakub Narebski <jnareb@gmail.com>
To: Joey Hess <joey@kitenet.net>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: git log and utf-u in filenames
Date: Thu, 25 Sep 2008 16:15:58 -0700 (PDT) [thread overview]
Message-ID: <m3fxnn3ji6.fsf@localhost.localdomain> (raw)
In-Reply-To: <20080925224354.GA6072@kodama.kitenet.net>
Joey Hess <joey@kitenet.net> writes:
> Joey Hess wrote:
> > And did earlier versions of git (circa 2006) perhaps not do that
> > escaping? I have code in ikiwiki that apparently used to work, but
> > is certianly not working with current git, due to this escaping.
>
> No, I guess it's always done that, perhaps something broke on my side
> in the meantime.
>
> But it doesn't seem right somehow that gitweb, ikiwiki, and seemingly
> any other program that needs to look at git log / commits and figure out
> what filename is being changed needs to include their own nasty code[1] to
> convert the escaped characters back to normal characters.
Well, in gitweb we could use '-z' option for git-diff-tree and git-ls-tree,
but it has its disadvantages, like having to do actual parsing record after
record instead of simplys splitting outout on end of line ("\n") characters.
> Would making git-log and git-commit display de-escaped filenames be likely
> to break something?
core.quotepath limits filename escaping, but you still _have_ to quote
"\n", "\t", and of course '"' and '\', if you want for filename to have
in single line in text format.
--
Jakub Narebski
Poland
ShadeHawk on #git
next prev parent reply other threads:[~2008-09-25 23:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-25 21:50 git log and utf-u in filenames Joey Hess
2008-09-25 22:43 ` Joey Hess
2008-09-25 23:15 ` Jakub Narebski [this message]
2008-09-26 6:33 ` Alex Riesen
2008-09-26 7:31 ` Jakub Narebski
2008-09-26 13:49 ` Alex Riesen
2008-09-27 8:37 ` Jakub Narebski
2008-09-25 23:11 ` Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3fxnn3ji6.fsf@localhost.localdomain \
--to=jnareb@gmail.com \
--cc=git@vger.kernel.org \
--cc=joey@kitenet.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).