From: Jakub Narebski <jnareb@gmail.com>
To: "Jürgen Kreileder" <jk@blackdown.de>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] gitweb: Output site name with valid utf8 in OPML
Date: Tue, 29 Nov 2011 11:35:21 -0800 (PST) [thread overview]
Message-ID: <m3hb1mlo1z.fsf@localhost.localdomain> (raw)
In-Reply-To: <CAKD0UuyJDaHyofM5VYG-R03mgYi_1QBJvQufv927+x6YYzPU2w@mail.gmail.com>
Jürgen Kreileder <jk@blackdown.de> writes:
> Signed-off-by: Juergen Kreileder <jk@blackdown.de>
> ---
> gitweb/gitweb.perl | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
> index 4f0c3bd..df747c1 100755
> --- a/gitweb/gitweb.perl
> +++ b/gitweb/gitweb.perl
> @@ -7699,11 +7699,12 @@ sub git_opml {
> -charset => 'utf-8',
> -content_disposition => 'inline; filename="opml.xml"');
>
> + my $title = esc_html($site_name);
> print <<XML;
> <?xml version="1.0" encoding="utf-8"?>
> <opml version="1.0">
> <head>
> - <title>$site_name OPML Export</title>
> + <title>$title OPML Export</title>
> </head>
> <body>
> <outline text="git RSS feeds">
> --
Thanks. That is certainly correct... but it is more than just
handling utf8, isn't it. It was also about not escaping XML
(think of site name containing eg. '<< foo >>' etc.).
So the subject / commit message should be corrected.
--
Jakub Narębski
prev parent reply other threads:[~2011-11-29 19:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-28 1:45 [PATCH] gitweb: Output site name with valid utf8 in OPML Jürgen Kreileder
2011-11-29 19:35 ` Jakub Narebski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3hb1mlo1z.fsf@localhost.localdomain \
--to=jnareb@gmail.com \
--cc=git@vger.kernel.org \
--cc=jk@blackdown.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).