* [PATCH] gitweb: Output site name with valid utf8 in OPML
@ 2011-11-28 1:45 Jürgen Kreileder
2011-11-29 19:35 ` Jakub Narebski
0 siblings, 1 reply; 2+ messages in thread
From: Jürgen Kreileder @ 2011-11-28 1:45 UTC (permalink / raw)
To: git
Signed-off-by: Juergen Kreileder <jk@blackdown.de>
---
gitweb/gitweb.perl | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 4f0c3bd..df747c1 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -7699,11 +7699,12 @@ sub git_opml {
-charset => 'utf-8',
-content_disposition => 'inline; filename="opml.xml"');
+ my $title = esc_html($site_name);
print <<XML;
<?xml version="1.0" encoding="utf-8"?>
<opml version="1.0">
<head>
- <title>$site_name OPML Export</title>
+ <title>$title OPML Export</title>
</head>
<body>
<outline text="git RSS feeds">
--
1.7.5.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] gitweb: Output site name with valid utf8 in OPML
2011-11-28 1:45 [PATCH] gitweb: Output site name with valid utf8 in OPML Jürgen Kreileder
@ 2011-11-29 19:35 ` Jakub Narebski
0 siblings, 0 replies; 2+ messages in thread
From: Jakub Narebski @ 2011-11-29 19:35 UTC (permalink / raw)
To: Jürgen Kreileder; +Cc: git
Jürgen Kreileder <jk@blackdown.de> writes:
> Signed-off-by: Juergen Kreileder <jk@blackdown.de>
> ---
> gitweb/gitweb.perl | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
> index 4f0c3bd..df747c1 100755
> --- a/gitweb/gitweb.perl
> +++ b/gitweb/gitweb.perl
> @@ -7699,11 +7699,12 @@ sub git_opml {
> -charset => 'utf-8',
> -content_disposition => 'inline; filename="opml.xml"');
>
> + my $title = esc_html($site_name);
> print <<XML;
> <?xml version="1.0" encoding="utf-8"?>
> <opml version="1.0">
> <head>
> - <title>$site_name OPML Export</title>
> + <title>$title OPML Export</title>
> </head>
> <body>
> <outline text="git RSS feeds">
> --
Thanks. That is certainly correct... but it is more than just
handling utf8, isn't it. It was also about not escaping XML
(think of site name containing eg. '<< foo >>' etc.).
So the subject / commit message should be corrected.
--
Jakub Narębski
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-11-29 19:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-28 1:45 [PATCH] gitweb: Output site name with valid utf8 in OPML Jürgen Kreileder
2011-11-29 19:35 ` Jakub Narebski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).