Re: NO_REGEX defaults on obscure platforms

[Jakub Narebski <jnareb@gmail.com>]

Brandon Casey <brandon.casey.ctr@nrlssc.navy.mil> writes:
> On 09/08/2010 10:12 AM, Ævar Arnfjörð Bjarmason wrote:
>> On Mon, Sep 6, 2010 at 07:41, Junio C Hamano <gitster@pobox.com> wrote:
>> 
>>> There are a few leftover bits in 'next' that need to be merged to 'master'
>>> before we declare a real -rc cycle, so tonight's pushout is -rc0.
>> 
>> One thing that's almost certainly wrong in v1.7.3-rc0 is the NO_REGEX
>> defaults. It's a non-issue for people who run the configure script,
>> but the Makefile probably has the wrong defaults on some obscure
>> platforms.
[...]

>> Alternatively, just check for REG_STARTEND in regex.h (or the includes
>> it pulls in):
>> 
>>     $ grep REG_STARTEND /usr/include/regex.h
>>     #define REG_STARTEND (1 << 2)
> 
> Unfortunately, IRIX actually defines REG_STARTEND in its regex.h, but
> the feature does not seem to work.  This also means the configure script
> will give a false negative and indicate that NO_REGEX should _not_ be
> set, when it actually should be.

Well, that just means that the test for NO_REGEX in configure.ac
should be more involved than just checking if REG_STARTEND is defined:
it should test if regex can truly handle null bytes.  There are some
examples of such test programs: see e.g. check for NO_C99_FORMAT
above.

-- 
Jakub Narebski
Poland
ShadeHawk on #git