From: Jakub Narebski <jnareb@gmail.com>
To: "Shawn O. Pearce" <spearce@spearce.org>
Cc: Petr Baudis <pasky@suse.cz>,
git@vger.kernel.org, Petr Baudis <petr.baudis@novartis.com>
Subject: Re: [PATCH] gitweb: Identify all summary metadata table rows
Date: Thu, 02 Oct 2008 18:04:56 -0700 (PDT) [thread overview]
Message-ID: <m3hc7uqyix.fsf@localhost.localdomain> (raw)
In-Reply-To: <20081003003053.GT21310@spearce.org>
"Shawn O. Pearce" <spearce@spearce.org> writes:
> Petr Baudis <pasky@suse.cz> wrote:
> > In the metadata table of the summary page, all rows have their
> > id (or class in case of URL) set now. This for example lets sites
> > easily disable fields they do not want to show in their custom
> > stylesheet (e.g. they are overly technical or irrelevant for the site).
> >
> > Many of my other patches depend on this, so I would appreciate to hear
> > as soon as possible if someone has an issue with this patch.
>
> Its pretty trivial and painless. So its applied. Marking up unique
> elements so you can control them via CSS isn't rocket science. ;-)
Somehow original patch didn't appear (yet) on git mailing list;
perhaps it ran afoul vger anti-SPAM filter...
> > + "<tr id=\"metadata_desc\"><td>description</td><td>" . esc_html($descr) . "</td></tr>\n" .
> > + "<tr id=\"metadata_owner\"><td>owner</td><td>" . esc_html($owner) . "</td></tr>\n";
> > + print "<tr id=\"metadata_lchange\"><td>last change</td><td>$cd{'rfc2822'}</td></tr>\n";
> > + print "<tr class=\"metadata_url\"><td>$url_tag</td><td>$git_url</td></tr>\n";
I like the idea, and I think this can be seen as beginning to use
either microformats, or RDFa. You have marked those fragments for CSS
to show or hide; microformats are about marking those fragments for
machine to parse. Although microformats usually use 'class' (or 'rel'
for links), not 'id' attribute for classifying data...
--
Jakub Narebski
Poland
ShadeHawk on #git
prev parent reply other threads:[~2008-10-03 1:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-02 14:25 [PATCH] gitweb: Identify all summary metadata table rows Petr Baudis
2008-10-03 0:30 ` Shawn O. Pearce
2008-10-03 1:04 ` Jakub Narebski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3hc7uqyix.fsf@localhost.localdomain \
--to=jnareb@gmail.com \
--cc=git@vger.kernel.org \
--cc=pasky@suse.cz \
--cc=petr.baudis@novartis.com \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).