From: Jakub Narebski <jnareb@gmail.com>
To: Peter Simons <simons@cryp.to>
Cc: git@vger.kernel.org, Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Subject: Re: gitweb sets incorrect <base> header
Date: Wed, 29 Apr 2009 02:33:01 -0700 (PDT) [thread overview]
Message-ID: <m3k553oldj.fsf@localhost.localdomain> (raw)
In-Reply-To: <877i15uf14.fsf@write-only.cryp.to>
Peter Simons <simons@cryp.to> writes:
> Hi,
>
> after a recent gitweb update to revision v1.6.3-rc3-12-gb79376c, the CGI now
> generates an incorrect <base> header. For example, the first "patch" on the
> page
>
> http://git.cryp.to/fastcgi/commitdiff/9ad9965b3fa293c458df14391f181f2f8f1197cd
>
> erroneously refer to http://git.cryp.to/cgi-bin/gitweb.cgi#patch1, but that
> page doesn't exist. It appears that $base_url is not determined correctly.
>
> Does anyone have a clue how that problem can be fixed?
See gitweb/README:
* $my_url, $my_uri
Full URL and absolute URL of gitweb script;
in earlier versions of gitweb you might have need to set those
variables, now there should be no need to do it.
Or you can set up $base_url in your gitweb configuration file (which
is not mentioned in the gitweb/README, unfortunately).
Since 81d3fe9 (gitweb: fix wrong base URL when non-root DirectoryIndex)
by Giuseppe Bilotta (I have CC-ed him) gitweb tries to set $base_url
using $cgi->url(-base => 1) . $ENV{'SCRIPT_NAME'} if we use $path_info,
and if both $my_url and $my_uri begin with $path_info.
I do not know CGI.pm well enough to think up a better solution, but
when $base_url was introduced I have posted email on git mailing list
about slight mismatch between what CGI.pm thinks as absolute URL and
the notion of absolute URL and absolute _paths_ in appropriate RFC,
see e.g.
http://thread.gmane.org/gmane.comp.version-control.git/107344/focus=107437
http://thread.gmane.org/gmane.comp.version-control.git/107898/focus=108010
P.S. I didn't look at the site in question.
--
Jakub Narebski
Poland
ShadeHawk on #git
next prev parent reply other threads:[~2009-04-29 9:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-28 12:41 gitweb sets incorrect <base> header Peter Simons
2009-04-29 9:22 ` Giuseppe Bilotta
2009-04-29 9:33 ` Jakub Narebski [this message]
2009-04-30 10:06 ` Peter Simons
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3k553oldj.fsf@localhost.localdomain \
--to=jnareb@gmail.com \
--cc=git@vger.kernel.org \
--cc=giuseppe.bilotta@gmail.com \
--cc=simons@cryp.to \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).