From: Jakub Narebski <jnareb@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Git Mailing List <git@vger.kernel.org>,
Daniel Barkalow <barkalow@iabervon.org>,
Marcus Griep <neoeinstein@gmail.com>
Subject: Re: [PATCH v2] diff: vary default prefix depending on what are compared
Date: Wed, 20 Aug 2008 02:06:50 -0700 (PDT) [thread overview]
Message-ID: <m3k5ecrr6j.fsf@localhost.localdomain> (raw)
In-Reply-To: <7vljysru9b.fsf_-_@gitster.siamese.dyndns.org>
Junio C Hamano <gitster@pobox.com> writes:
> With a new configuration "diff.mnemonicprefix", "git diff" shows the
> differences between various combinations of preimage and postimage trees
> with prefixes different from the standard "a/" and "b/". Hopefully this
> will make the distinction stand out for some people.
>
> "git diff" compares the (i)ndex and the (w)ork tree;
> "git diff HEAD" compares a (c)ommit and the (w)ork tree;
> "git diff --cached" compares a (c)ommit and the (i)ndex;
> "git diff --no-index a b" compares two non-git things (1) and (2).
>
> Because these mnemonics now have meanings, they are swapped when reverse
> diff is in effect and this feature is enabled.
>
> + diff_set_mnemonic_prefix(&revs->diffopt, "o/", "w/");
> +
Somehow you lost in the commit description and in the added
documentation the (o)bject prefix (explicitely naming 'blob' object,
for example HEAD:a, or :2:b, or 7a7ff130a34942506e6068105ac5946c9404bf18)
It is also not obvious IMVHO that when comparing two trees (two
commits) git uses default 'a/'..'b/' prefixes.
--
Jakub Narebski
Poland
ShadeHawk on #git
next prev parent reply other threads:[~2008-08-20 9:07 UTC|newest]
Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-18 0:02 Call Me Gitless Trans
2008-08-18 0:28 ` Benjamin Sergeant
2008-08-18 0:40 ` Martin Langhoff
2008-08-18 8:50 ` Pascal Obry
2008-08-18 16:43 ` Jon Loeliger
2008-08-18 19:22 ` Daniel Barkalow
2008-08-18 20:17 ` Marcus Griep
2008-08-18 20:20 ` Junio C Hamano
2008-08-18 21:31 ` Daniel Barkalow
2008-08-18 22:30 ` Junio C Hamano
2008-08-18 23:12 ` Daniel Barkalow
2008-08-19 3:22 ` Junio C Hamano
2008-08-19 3:55 ` Marcus Griep
2008-08-19 6:47 ` Junio C Hamano
2008-08-19 7:02 ` Junio C Hamano
2008-08-20 8:00 ` [PATCH v2] diff: vary default prefix depending on what are compared Junio C Hamano
2008-08-20 9:06 ` Jakub Narebski [this message]
2008-08-19 6:28 ` Call Me Gitless Stephen R. van den Berg
2008-08-19 11:42 ` Jakub Narebski
2008-08-19 18:18 ` Junio C Hamano
2008-08-19 17:52 ` Jeff King
2008-08-19 18:39 ` Daniel Barkalow
2008-08-19 18:45 ` Jeff King
2008-08-19 18:57 ` Daniel Barkalow
2008-08-19 19:01 ` Jeff King
2008-08-19 19:42 ` Daniel Barkalow
2008-08-19 20:33 ` Petr Baudis
2008-08-19 21:49 ` Daniel Barkalow
2008-08-19 19:43 ` Junio C Hamano
2008-08-19 7:25 ` Junio C Hamano
2008-08-19 19:22 ` Daniel Barkalow
2008-08-21 3:40 ` Sverre Hvammen Johansen
2008-08-21 8:41 ` Junio C Hamano
2008-08-21 8:43 ` [PATCH 1/3] sha1_object_info(): pay attention to cached objects Junio C Hamano
2008-08-21 8:43 ` [PATCH 2/3] cached_object: learn empty blob Junio C Hamano
2008-08-21 8:44 ` [PATCH 3/3] git-add --intent-to-add (-N) Junio C Hamano
2008-08-21 14:23 ` Paolo Bonzini
2008-08-21 21:14 ` Jonathan Nieder
2008-08-22 4:10 ` Jonathan Nieder
2008-08-22 4:34 ` Daniel Barkalow
2008-08-22 4:59 ` Junio C Hamano
2008-08-22 5:32 ` Jonathan Nieder
2008-08-22 5:59 ` Junio C Hamano
2008-08-22 6:38 ` Jonathan Nieder
2008-08-22 7:52 ` Jonathan Nieder
2008-08-21 13:58 ` Call Me Gitless Daniel Barkalow
2008-08-18 23:24 ` Tarmigan
2008-08-19 0:32 ` Daniel Barkalow
2008-08-19 0:45 ` Tarmigan
2008-08-19 7:53 ` "Peter Valdemar Mørch (Lists)"
2008-08-19 8:01 ` Junio C Hamano
2008-08-19 8:10 ` Imran M Yousuf
2008-08-19 8:26 ` "Peter Valdemar Mørch (Lists)"
2008-08-19 8:53 ` Imran M Yousuf
2008-08-19 8:57 ` Alexander E Genaud
2008-08-19 9:11 ` Matthieu Moy
2008-08-19 9:36 ` Mike Hommey
2008-08-19 10:09 ` Alexander E Genaud
2008-08-19 11:27 ` Pascal Obry
2008-08-21 14:15 ` Paolo Bonzini
2008-08-22 19:10 ` Elijah Newren
2008-08-19 10:16 ` "Peter Valdemar Mørch (Lists)"
2008-08-19 11:31 ` Mark Struberg
2008-08-19 12:04 ` Alexander E Genaud
2008-08-19 18:15 ` Junio C Hamano
2008-08-19 8:56 ` Teemu Likonen
2008-08-19 13:15 ` Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3k5ecrr6j.fsf@localhost.localdomain \
--to=jnareb@gmail.com \
--cc=barkalow@iabervon.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=neoeinstein@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).