From: Jakub Narebski <jnareb@gmail.com>
To: "Toralf Förster" <toralf.foerster@gmx.de>
Cc: git@vger.kernel.org
Subject: Re: webgit highlightes mem adresses as git versions
Date: Mon, 02 Feb 2009 14:54:20 -0800 (PST) [thread overview]
Message-ID: <m3ljsowisv.fsf@localhost.localdomain> (raw)
In-Reply-To: <200902022204.46651.toralf.foerster@gmx.de>
Toralf Förster <toralf.foerster@gmx.de> writes:
> As seen here
> http://git.kernel.org/?p=linux/kernel/git/stable/linux-2.6.27.y.git;a=commit;h=8ca2918f99b5861359de1805f27b08023c82abd2
> the strings [<c043d0f3>] and firends shouldn't be recognized as git hashes,
> isn't it ?
Gitweb, not webgit. And gitweb considers ([0-9a-fA-F]{8,40}) i.e.
from 8 to 40 hexadecimal characters to be (shortened) SHA-1. It
simply cannot afford checking if such object exists when displaying
commit message (for example in 'log' view).
--
Jakub Narebski
Poland
ShadeHawk on #git
next prev parent reply other threads:[~2009-02-02 22:55 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-02 21:04 webgit highlightes mem adresses as git versions Toralf Förster
2009-02-02 22:54 ` Jakub Narebski [this message]
2009-02-03 11:04 ` Toralf Förster
2009-02-03 12:31 ` Johannes Schindelin
2009-02-06 9:12 ` [PATCH] gitweb: Better regexp for SHA-1 committag match Jakub Narebski
2009-02-06 9:49 ` Rafael Garcia-Suarez
2009-02-06 10:26 ` Jakub Narebski
2009-02-06 10:31 ` Rafael Garcia-Suarez
2009-02-06 10:49 ` [PATCHv2] " Jakub Narebski
2009-02-06 13:03 ` Johannes Schindelin
2009-02-06 21:47 ` Jay Soffian
2009-02-06 22:00 ` Jakub Narebski
2009-02-07 7:48 ` Junio C Hamano
2009-02-07 8:34 ` Jakub Narebski
2009-02-07 8:48 ` Junio C Hamano
2009-02-07 9:25 ` Jakub Narebski
2009-02-07 9:32 ` demerphq
2009-02-07 10:09 ` Jakub Narebski
2009-02-07 14:01 ` Jakub Narebski
2009-02-07 9:22 ` [PATCH] " demerphq
2009-02-07 10:07 ` Jakub Narebski
2009-02-07 13:30 ` demerphq
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3ljsowisv.fsf@localhost.localdomain \
--to=jnareb@gmail.com \
--cc=git@vger.kernel.org \
--cc=toralf.foerster@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).