From: Jakub Narebski <jnareb@gmail.com>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [BUG?] t9500 --debug prints "sh: ++GIT_BINDIR++/git: not found"
Date: Wed, 27 Oct 2010 14:21:53 -0700 (PDT) [thread overview]
Message-ID: <m3ocafib6z.fsf@localhost.localdomain> (raw)
In-Reply-To: <20101027204954.GA31386@burratino>
Jonathan Nieder <jrnieder@gmail.com> writes:
> Trying to run t9500-gitweb-standalone-no-errors.sh, I find:
>
> $ sh t9500-gitweb-standalone-no-errors.sh --debug
> ok 1 - no commits: projects_list (implicit)
> sh: ++GIT_BINDIR++/git: not found
> ok 2 - no commits: projects_index
> sh: ++GIT_BINDIR++/git: not found
> ok 3 - no commits: .git summary (implicit)
> [...]
> Ideas? Is this expected behavior?
Fixed in 8ff76f4 (gitweb: Move call to evaluate_git_version after
evaluate_gitweb_config, 2010-09-26):
gitweb: Move call to evaluate_git_version after evaluate_gitweb_config
This means that call to evaluate_git_version() is now inside
run_request(), which means that is called for each request instead of
once per starting gitweb; this matter currently only when using
FastCGI interface (gitweb.fcgi).
This change was done becayse evaluate_git_version() uses $GIT
variable, which can be set / modified by gitweb config file... and it
is modified this way by gitweb config file used in gitweb tests.
Without this change there is spurious extra output from t9500 test
when tests are run with '--debug' option.
which is part of
* jn/gitweb-test (2010-09-26) 4 commits
- gitweb/Makefile: Include gitweb/config.mak
- gitweb/Makefile: Add 'test' and 'test-installed' targets
- t/gitweb-lib.sh: Add support for GITWEB_TEST_INSTALLED
- gitweb: Move call to evaluate_git_version after evaluate_gitweb_config
--
Jakub Narebski
Poland
ShadeHawk on #git
next prev parent reply other threads:[~2010-10-27 21:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-27 20:49 [BUG?] t9500 --debug prints "sh: ++GIT_BINDIR++/git: not found" Jonathan Nieder
2010-10-27 21:21 ` Jakub Narebski [this message]
2010-10-27 21:34 ` Jonathan Nieder
2010-10-27 22:32 ` Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3ocafib6z.fsf@localhost.localdomain \
--to=jnareb@gmail.com \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).