From: Jakub Narebski <jnareb@gmail.com>
To: "Jörg Sommer" <joerg@alea.gnuu.de>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>,
git@vger.kernel.org, jjengla@sandia.gov
Subject: Re: [PATCH] Pay attention to GIT_DIR when searching the git directory
Date: Mon, 05 May 2008 07:10:53 -0700 (PDT) [thread overview]
Message-ID: <m3r6cg6dur.fsf@localhost.localdomain> (raw)
In-Reply-To: <20080505125302.GA11523@alea.gnuu.de>
Jörg Sommer <joerg@alea.gnuu.de> writes:
> Johannes Schindelin schrieb am Mon 05. May, 12:36 (+0100):
> > If you do not say _what_ is affected by the change, you only confuse
> > the readers.
>
> Do you want something like “initialization: Pay attention to GIT_DIR when
> searching the git directory”?
I think the idea was to use
"contrib/hooks/setgitperms: Use GIT_DIR if set"
or something like that.
> Is there a document with guidelines for commit messages, e.g. write the
> first letter upper or lower case?
There are a few unwritten conventions. You can always check existing
commit messages, via
$ git log --pretty=oneline --abbrev-commit --no-merges
and see that commit title (first line of commit message) is either
short sentence starting with upper case, bt without fullstop, or
sentence preceded by the subsystem affected, using "<subsystem>:"
prefix.
Examples:
Fix use after free() in builtin-fetch
git-svn: detect and fail gracefully when dcommitting to a void
--
Jakub Narebski
Poland
ShadeHawk on #git
next prev parent reply other threads:[~2008-05-05 14:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-05 0:09 [PATCH] Pay attention to GIT_DIR when searching the git directory Jörg Sommer
2008-05-05 11:36 ` Johannes Schindelin
2008-05-05 12:53 ` Jörg Sommer
2008-05-05 13:39 ` Johannes Schindelin
2008-05-05 14:10 ` Jakub Narebski [this message]
2008-05-05 15:30 ` Jörg Sommer
2008-05-05 16:33 ` Johannes Schindelin
2008-05-05 16:48 ` Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3r6cg6dur.fsf@localhost.localdomain \
--to=jnareb@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=jjengla@sandia.gov \
--cc=joerg@alea.gnuu.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).