From: Jakub Narebski <jnareb@gmail.com>
To: "Jean-Baptiste Quenot" <jbq@caraldi.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] gitweb: Add hash parameter in feed URL when a hash is specified in the current request
Date: Fri, 21 Mar 2008 11:53:48 -0700 (PDT) [thread overview]
Message-ID: <m3skyjvrgr.fsf@localhost.localdomain> (raw)
In-Reply-To: <ae63f8b50803211138y6355fd11pa64cda50a1f53011@mail.gmail.com>
"Jean-Baptiste Quenot" <jbq@caraldi.com> writes:
> Hi list,
>
> I was annoyed with the RSS feed link at the bottom of gitweb because I
> couldn't find a way to have a specific feed for every branch. With
> this patch, the generated links include the hash parameter so that
> feeds are context-dependant.
>
> Hope it helps!
>
> ---
> gitweb/gitweb.perl | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
> index ec73cb1..7d013bd 100755
> --- a/gitweb/gitweb.perl
> +++ b/gitweb/gitweb.perl
> @@ -615,6 +615,7 @@ sub href(%) {
> my %mapping = @mapping;
>
> $params{'project'} = $project unless exists $params{'project'};
> + $params{'hash'} = $hash unless exists $params{'hash'};
>
> if ($params{-replay}) {
> while (my ($name, $symbol) = each %mapping) {
It is *a* solution, but I don't think it is a *correct* solution for
this problem. This adds 'hash' parameter to *every* link if parent
view had hash parameter passed or just defined $hash variable for
convenience.
The project parameter is added implicitely unless turned off
('project => undef) because almost all links need this parameter;
IMHO this is not the case for hash parameter.
Besides this solution doesn't address the naming of feed links.
I was planning to add context-dependent feed links, both in page
header (<link .../> elements in HTML <head>) and at the bottom of the
page. Unfortunately to do this *rigth* took me more time than I
though. (Additionally I got no responses to the post asking about
thoughs on how should this be done:)
"[RFC] gitweb: Use feed link according to current view"
Message-Id: <200802111900.12325.jnareb@gmail.com>
I was derailed for a bit, but I can try to do this... but after the
Easter.
--
Jakub Narebski
Poland
ShadeHawk on #git
next prev parent reply other threads:[~2008-03-21 18:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-21 18:38 [PATCH] gitweb: Add hash parameter in feed URL when a hash is specified in the current request Jean-Baptiste Quenot
2008-03-21 18:53 ` Jakub Narebski [this message]
2008-03-21 19:14 ` Jean-Baptiste Quenot
2008-03-21 19:53 ` Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3skyjvrgr.fsf@localhost.localdomain \
--to=jnareb@gmail.com \
--cc=git@vger.kernel.org \
--cc=jbq@caraldi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).