From: Jakub Narebski <jnareb@gmail.com>
To: Tay Ray Chuan <rctay89@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Mike Hommey <mh@glandium.org>
Subject: Re: [PATCH 03/23] http*: cleanup slot->local after fclose
Date: Fri, 05 Jun 2009 13:43:53 -0700 (PDT) [thread overview]
Message-ID: <m3vdna5s3d.fsf@localhost.localdomain> (raw)
In-Reply-To: <20090606000133.33101b1e.rctay89@gmail.com>
Tay Ray Chuan <rctay89@gmail.com> writes:
> Set slot->local to NULL after doing a fclose on the FILE* pointer it
> points to. This prevents an invalid FILE* pointer from being passed to
> ftell() in http.c::run_active_slot().
You mean here passing FILE* pointer to a fclosed file to ftell()?
>
> This issue was raised by Clemens Buchacher on 30th May:
Just in case: 30th May 2009?
>
> http://www.spinics.net/lists/git/msg104623.html
>
> Signed-off-by: Tay Ray Chuan <rctay89@gmail.com>
--
Jakub Narebski
Poland
ShadeHawk on #git
next prev parent reply other threads:[~2009-06-05 20:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-05 16:01 [PATCH 03/23] http*: cleanup slot->local after fclose Tay Ray Chuan
2009-06-05 20:43 ` Jakub Narebski [this message]
2009-06-06 1:15 ` Tay Ray Chuan
[not found] <cover.1244277116.git.rctay89@gmail.com>
2009-06-06 8:43 ` Tay Ray Chuan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3vdna5s3d.fsf@localhost.localdomain \
--to=jnareb@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=mh@glandium.org \
--cc=rctay89@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).