From: Jakub Narebski <jnareb@gmail.com>
To: Bruno Ribas <ribas@c3sl.ufpr.br>
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH] gitweb: Make use of the $git_dir variable at sub git_get_project_url_list
Date: Wed, 06 Feb 2008 11:37:51 -0800 (PST) [thread overview]
Message-ID: <m3ve51511t.fsf@localhost.localdomain> (raw)
In-Reply-To: <1202318112-8223-1-git-send-email-ribas@c3sl.ufpr.br>
Bruno Ribas <ribas@c3sl.ufpr.br> writes:
> @@ -1620,7 +1620,7 @@ sub git_get_project_url_list {
> my $path = shift;
>
> $git_dir = "$projectroot/$path";
> - open my $fd, "$projectroot/$path/cloneurl"
> + open my $fd, "$git_dir/cloneurl"
> or return wantarray ?
> @{ config_to_multi(git_get_project_config('url')) } :
> config_to_multi(git_get_project_config('url'));
Good catch (although it wasn't actually a bug).
--
Jakub Narebski
Poland
ShadeHawk on #git
next prev parent reply other threads:[~2008-02-06 19:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-06 17:15 [PATCH] gitweb: Make use of the $git_dir variable at sub git_get_project_url_list Bruno Ribas
2008-02-06 19:37 ` Jakub Narebski [this message]
2008-02-08 4:15 ` Bruno Cesar Ribas
2008-02-08 6:21 ` Junio C Hamano
2008-02-08 9:15 ` Jakub Narebski
2008-02-10 2:46 ` Bruno Cesar Ribas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3ve51511t.fsf@localhost.localdomain \
--to=jnareb@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=ribas@c3sl.ufpr.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).