From: Jakub Narebski <jnareb@gmail.com>
To: Tay Ray Chuan <rctay89@gmail.com>
Cc: "Git Mailing List" <git@vger.kernel.org>,
"Junio C Hamano" <gitster@pobox.com>,
"Shawn O. Pearce" <spearce@spearce.org>,
Dan McGee <dpmcgee@gmail.com>
Subject: Re: [PATCH v4 1/4] t5541-http-push: add test for chunked
Date: Wed, 04 May 2011 04:51:22 -0700 (PDT) [thread overview]
Message-ID: <m3wri6vg5h.fsf@localhost.localdomain> (raw)
In-Reply-To: <1304503896-5988-2-git-send-email-rctay89@gmail.com>
Tay Ray Chuan <rctay89@gmail.com> writes:
> +test_expect_success 'push (chunked)' '
> + git checkout master &&
> + test_commit commit path3 &&
> + HEAD=$(git rev-parse --verify HEAD) &&
> + git config http.postbuffer 4 &&
> + git push -v -v origin $BRANCH 2>err &&
> + grep "POST git-receive-pack (chunked)" err &&
> + (cd "$HTTPD_DOCUMENT_ROOT_PATH"/test_repo.git &&
> + test $HEAD = $(git rev-parse --verify HEAD)) &&
> + git config --unset http.postbuffer
> +'
It is a very minor issue, a nitpick really; but wouldn't it be better
to use
+ git config http.postbuffer 4 &&
+ test_when_finished "git config --unset http.postbuffer" &&
This way you would have `http.postBuffer` unset even if any of
intermediate commands fail, preparing clean state for next test.
Though in this case that doesn't matter, as it is the very last test.
--
Jakub Narebski
Poland
ShadeHawk on #git
next prev parent reply other threads:[~2011-05-04 11:51 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-03 15:47 [PATCH v3 0/4] http cleanups Tay Ray Chuan
2011-05-03 15:47 ` [PATCH v3 1/4] t5541-http-push: add test for chunked Tay Ray Chuan
2011-05-03 15:47 ` [PATCH v3 2/4] http: make curl callbacks match contracts from curl header Tay Ray Chuan
2011-05-03 15:47 ` [PATCH v3 3/4] http-push: use const for strings in signatures Tay Ray Chuan
2011-05-03 15:47 ` [PATCH v3 4/4] http-push: refactor curl_easy_setup madness Tay Ray Chuan
2011-05-03 16:32 ` [PATCH v3 1/4] t5541-http-push: add test for chunked Shawn Pearce
2011-05-03 17:18 ` Tay Ray Chuan
2011-05-04 4:07 ` Junio C Hamano
2011-05-04 4:09 ` [PATCH v3 0/4] http cleanups Junio C Hamano
2011-05-04 9:50 ` Tay Ray Chuan
2011-05-04 10:11 ` [PATCH v4 " Tay Ray Chuan
2011-05-04 10:11 ` [PATCH v4 1/4] t5541-http-push: add test for chunked Tay Ray Chuan
2011-05-04 10:11 ` [PATCH v4 2/4] http: make curl callbacks match contracts from curl header Tay Ray Chuan
2011-05-04 10:11 ` [PATCH v4 3/4] http-push: use const for strings in signatures Tay Ray Chuan
2011-05-04 10:11 ` [PATCH v4 4/4] http-push: refactor curl_easy_setup madness Tay Ray Chuan
2011-05-04 11:51 ` Jakub Narebski [this message]
2011-05-04 18:23 ` [PATCH v4 1/4] t5541-http-push: add test for chunked Junio C Hamano
[not found] ` <1304529590-1032-1-git-send-email-rctay89@gmail.com>
2011-05-04 18:23 ` [PATCH v5 " Junio C Hamano
2011-05-04 18:44 ` Junio C Hamano
2011-05-04 20:28 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3wri6vg5h.fsf@localhost.localdomain \
--to=jnareb@gmail.com \
--cc=dpmcgee@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=rctay89@gmail.com \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).