git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Narebski <jnareb@gmail.com>
To: Eli Barzilay <eli@barzilay.org>
Cc: git@vger.kernel.org
Subject: Re: gitweb.css
Date: Thu, 08 Jul 2010 09:07:00 -0700 (PDT)	[thread overview]
Message-ID: <m3y6dmklg0.fsf@localhost.localdomain> (raw)
In-Reply-To: <19509.15171.909921.769184@winooski.ccs.neu.edu>

Eli Barzilay <eli@barzilay.org> writes:

> I've been customizing a gitweb server to fit with the rest of our
> project pages (the result is http://git.racket-lang.org/).  This was
> relatively easy to do except for a few places where gitweb.css
> specifies formatting for generic tags like `body', `table', and `td',
> which messed up our header.
> 
> Maybe it makes sense to localize these styles to to gitweb specific
> classes?  (I know that I can just use my own css, but the file is big
> enough that I prefer avoiding manually merging in updates.)

Can't you just override gitweb's CSS by your own CSS?  Later CSS wins.
You can have more than one stylesheet in gitweb (@stylesheets).

We could give class to `body' element, and the use it for other
class-less selectors (`'table', `'td', `a'), but I don't know if this
solution would be enought for you.  It means replacing 'body' selector
by e.g. '.gitweb_body' selector, and e.g. 'a' selector by
'.gitweb_body a' selector.


I'd rather not add 'gitweb' class (or similar) to every element just
to have common style for all links, tables, table header cells, table
cells.


P.S. while changing static/gitweb.css we could optimize it by removing
unnecessary parts of selector.  Contrary to what I thought more
detailed selector decreases rather than improves performance.

-- 
Jakub Narebski
Poland
ShadeHawk on #git

  reply	other threads:[~2010-07-08 16:07 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-08  2:43 gitweb.css Eli Barzilay
2010-07-08 16:07 ` Jakub Narebski [this message]
2010-07-08 17:42   ` gitweb.css Eli Barzilay
2010-07-08 18:49     ` gitweb.css Jakub Narebski
2010-07-08 18:57       ` gitweb.css Eli Barzilay
2010-07-08 19:25         ` gitweb.css Jakub Narebski
2010-07-08 19:30           ` gitweb.css Eli Barzilay

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3y6dmklg0.fsf@localhost.localdomain \
    --to=jnareb@gmail.com \
    --cc=eli@barzilay.org \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).