From: Jakub Narebski <jnareb@gmail.com>
To: Matthieu Moy <Matthieu.Moy@imag.fr>
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH 1/5] diff: parse separate options like -S foo
Date: Thu, 05 Aug 2010 05:16:38 -0700 (PDT) [thread overview]
Message-ID: <m3zkx1ntkk.fsf@localhost.localdomain> (raw)
In-Reply-To: <1280996576-1165-1-git-send-email-Matthieu.Moy@imag.fr>
Matthieu Moy <Matthieu.Moy@imag.fr> writes:
> +static inline int short_opt(char opt, const char **argv,
> + const char **optarg)
[...]
> +int parse_long_opt(const char *opt, const char **argv,
> + const char **optarg)
Just a nitpick question: why it is 'parse_long_opt' but just 'short_opt'?
--
Jakub Narebski
Poland
ShadeHawk on #git
next prev parent reply other threads:[~2010-08-05 12:16 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-04 22:24 What's cooking in git.git (Aug 2010, #01; Wed, 4) Junio C Hamano
2010-08-05 0:16 ` jk/tag-contains: stalled Ted Ts'o
2010-08-05 16:29 ` Junio C Hamano
2010-08-05 17:05 ` Junio C Hamano
2010-08-05 17:36 ` Jeff King
2010-08-05 18:47 ` Junio C Hamano
2010-08-05 19:06 ` Jeff King
2010-08-05 19:18 ` Jay Soffian
2010-08-05 19:27 ` Jeff King
2010-08-05 20:00 ` Jay Soffian
2010-08-05 20:36 ` Ted Ts'o
2010-08-05 20:53 ` Junio C Hamano
2010-08-05 21:38 ` Thomas Rast
2010-08-05 22:15 ` Junio C Hamano
2010-08-06 5:44 ` Junio C Hamano
2010-08-05 6:53 ` tc/checkout-B Jonathan Nieder
2010-08-05 10:18 ` tc/checkout-B Tay Ray Chuan
2010-08-05 8:20 ` What's cooking in git.git (Aug 2010, #01; Wed, 4) Matthieu Moy
2010-08-05 8:22 ` [PATCH 1/5] diff: parse separate options like -S foo Matthieu Moy
2010-08-05 12:16 ` Jakub Narebski [this message]
2010-08-05 12:24 ` Matthieu Moy
2010-08-05 8:22 ` [PATCH 2/5] diff: split off a function for --stat-* option parsing Matthieu Moy
2010-08-05 8:22 ` [PATCH 3/5] diff: parse separate options --stat-width n, --stat-name-width n Matthieu Moy
2010-08-05 8:22 ` [PATCH 4/5] log: parse separate options like git log --grep foo Matthieu Moy
2010-08-05 8:22 ` [PATCH 5/5] log: parse separate option for --glob Matthieu Moy
2010-08-05 11:41 ` mm/shortopt-detached Jonathan Nieder
2010-08-05 21:12 ` jc/sha1-name-find-fix Dmitry V. Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3zkx1ntkk.fsf@localhost.localdomain \
--to=jnareb@gmail.com \
--cc=Matthieu.Moy@imag.fr \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).