From: Zach Welch <zw@superlucidity.net>
To: git@vger.kernel.org
Subject: [PATCH 5/8] init-db.c: refactor mkdir logic
Date: Tue, 19 Apr 2005 02:09:39 -0700 [thread overview]
Message-ID: <mailbox-23311-1113901779-730821@spoon> (raw)
In-Reply-To: mailbox-23311-1113901779-711084@spoon
Move redundant mkdir call logic into helper function.
This patch applies on top of:
[PATCH 0/8] init-db.c cleanup, add INDEX_FILE_DIRECTORY support
[PATCH 1/8] init-db.c: [RESEND] remove redundant getenv call
[PATCH 2/8] init-db.c: [RESEND] make init-db work with common objects
[PATCH 3/8] init-db.c: refactor directory creation
[PATCH 4/8] init-db.c: add INDEX_FILE_DIRECTORY support
init-db.c | 24 ++++++++++++------------
1 files changed, 12 insertions(+), 12 deletions(-)
Signed-Off-By: Zach Welch <zw@superlucidity.net>
--- a/init-db.c 2005-04-19 01:36:58.000000000 -0700
+++ b/init-db.c 2005-04-19 01:37:03.000000000 -0700
@@ -11,6 +11,16 @@
* be the judge. The default case is to have a DB per managed directory.
*/
+static void create_dir(char *path)
+{
+ if (mkdir(dir, 0755) < 0) {
+ if (errno != EEXIST) {
+ perror(dir);
+ exit(1);
+ }
+ }
+}
+
static char* init_dir(char *env, char *std, char *label, int *len)
{
char *dir;
@@ -26,12 +36,7 @@
dir = std;
fprintf(stderr, "defaulting to private %s area\n", label);
}
- if (mkdir(dir, 0755) < 0) {
- if (errno != EEXIST) {
- perror(dir);
- exit(1);
- }
- }
+ create_dir(dir);
if (len)
*len = strlen(dir);
return dir;
@@ -49,12 +54,7 @@
memcpy(path, sha1_dir, len);
for (i = 0; i < 256; i++) {
sprintf(path+len, "/%02x", i);
- if (mkdir(path, 0755) < 0) {
- if (errno != EEXIST) {
- perror(path);
- exit(1);
- }
- }
+ create_dir(path);
}
return 0;
}
reply other threads:[~2005-04-19 9:07 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mailbox-23311-1113901779-730821@spoon \
--to=zw@superlucidity.net \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).