From: Alex Riesen <raa.lkml@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Andreas Gruenbacher <agruen@suse.de>, git@vger.kernel.org
Subject: Re: [BUG] Git add <device file> silently fails
Date: Sat, 17 Apr 2010 19:32:22 +0200 [thread overview]
Message-ID: <n2i81b0412b1004171032v713f156ase295cbe7bbedf1f6@mail.gmail.com> (raw)
In-Reply-To: <7v4oja3uh7.fsf@alter.siamese.dyndns.org>
On Sat, Apr 17, 2010 at 18:38, Junio C Hamano <gitster@pobox.com> wrote:
> Alex Riesen <raa.lkml@gmail.com> writes:
>
>> I think something like this should make the accident more
>> noticable:
>
> The early skippage done in dir.c (read-directory-recursive) should treat
> these as ignored just like paths that are ignored with .gitignore
> mechanism, and if we do so, we shouldn't need this patch to add another
> codepath to give notification to the user (we would however still need
> to reword "'add -f' if you really want to add it", though).
>
I see. Special files are not treated as ignored yet (and there will be
no way to un-ignore them). I have to read the code for a while,
ignored pathnames are sometimes stored for later use too.
next prev parent reply other threads:[~2010-04-17 17:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-17 14:24 [BUG] Git add <device file> silently fails Andreas Gruenbacher
2010-04-17 14:44 ` Alex Riesen
2010-04-17 15:00 ` Andreas Gruenbacher
2010-04-17 15:27 ` Alex Riesen
2010-04-17 16:38 ` Junio C Hamano
2010-04-17 17:32 ` Alex Riesen [this message]
2010-04-17 18:23 ` Alex Riesen
2010-04-17 17:57 ` Andreas Gruenbacher
2010-04-19 5:15 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=n2i81b0412b1004171032v713f156ase295cbe7bbedf1f6@mail.gmail.com \
--to=raa.lkml@gmail.com \
--cc=agruen@suse.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).