Re: [Patch 001/GSoC] Move static files into subdir

[Pavan Kumar Sunkara <pavan.sss1991@gmail.com>]

I will try to follow them from next time onwards.

Thanks

- Pavan

On Sun, May 9, 2010 at 10:40 PM, Christian Couder
<chriscool@tuxfamily.org> wrote:
> On Sunday 09 May 2010 15:56:30 Pavan Kumar Sunkara wrote:
> Hi,
>
>> Hi,
>>
>> It's been a while I mail to this list since I got GSoC. But I have
>> been in contact with Christian and Petr (mentors) everyday. As I am
>> having my vacation, I decided to statrt the project earlier itself.
>> Here's is my first patch in the process of my GSoC.
>>
>> One of my project goals is to split gitweb. This patch initiates the
>>  splitting.
>
> All of the above should go after the three dashes and before the diffstat
> bellow.
>
> Please try to look at the submitting patch documentation and what other
> people's patches look like.
>
>> From e25db0b62b481e029354ad33af8f0615a8353633 Mon Sep 17 00:00:00 2001
>> From: Pavan Kumar Sunkara <pavan.sss1991@gmail.com>
>> Date: Wed, 5 May 2010 21:44:57 -0700
>
> The above line should not appear.
>
>> Subject: [PATCH] Gitweb: Move all static files into a seperate directory
>
> This line should be the subject of your email.
> If you really want to say that it's a GSoC patch you can use [PATCH GSoC]
> instead of [PATCH] but please don't put "001/GSoC".
>
>> This commit creates a new subdirectory called 'static' in gitweb
>> which will contain all the static files required by gitweb.cgi
>> while executing. By doing so, the gitweb source will be more
>> readable and maintainable.
>>
>> Also changed INSTALL, README, Makefile and test files
>> according to this change.
>>
>> Signed-off-by: Pavan Kumar Sunkara <pavan.sss1991@gmail.com>
>> ---
>
> The comments that you put on top of the patch should go here.
>
>>  gitweb/INSTALL                      |   20 ++++++++++----------
>>  gitweb/Makefile                     |   20 ++++++++++----------
>>  gitweb/README                       |    8 ++++----
>>  gitweb/{ => static}/git-favicon.png |  Bin 115 -> 115 bytes
>>  gitweb/{ => static}/git-logo.png    |  Bin 207 -> 207 bytes
>>  gitweb/{ => static}/gitweb.css      |    0
>>  gitweb/{ => static}/gitweb.js       |    0
>>  t/gitweb-lib.sh                     |    6 +++---
>>  8 files changed, 27 insertions(+), 27 deletions(-)
>>  rename gitweb/{ => static}/git-favicon.png (100%)
>>  rename gitweb/{ => static}/git-logo.png (100%)
>>  rename gitweb/{ => static}/gitweb.css (100%)
>>  rename gitweb/{ => static}/gitweb.js (100%)
>
> [...]
>
> Regards,
> Christian.
>