* Re: Sanity check of git-commit patch, was Re: [PATCH] Making CFLAGS compilant with GNU Coding Standards
From: Junio C Hamano @ 2005-08-10 5:45 UTC (permalink / raw)
To: Johannes Schindelin; +Cc: Pavel Roskin, git
In-Reply-To: <7vu0hzw9sx.fsf@assigned-by-dhcp.cox.net>
Junio C Hamano <junkio@cox.net> writes:
>> - Multiple -m options was actually a feature of my version of the patch.
>
> Ah, OK.
I said "OK" and thought about it again. While thinking about
what is the right inter-message-piece separator for multiple -m
parameters (you use "\n"), I got a headache. I decided to keep
what is already there after all ;-).
I'll push things out tonight and expect to tag things tomorrow
late afternoon to declare 0.99.4
^ permalink raw reply
* Re: gitweb - feature request
From: Sam Ravnborg @ 2005-08-10 5:18 UTC (permalink / raw)
To: Kay Sievers; +Cc: Kay Sievers, git
In-Reply-To: <20050810020013.GA27506@vrfy.org>
> Sam,
> try it! :)
Works excellent - and less than 12 hours after I posted my feautre
reqest. That was quick!
Thanks,
Sam
^ permalink raw reply
* [PATCH] Fix git-rev-parse's parent handling
From: Johannes Schindelin @ 2005-08-10 3:07 UTC (permalink / raw)
To: git
git-rev-parse HEAD^1 would fail, because of an off-by-one bug (but HEAD^
would yield the expected result). Also, when the parent does not exist, do
not silently return an incorrect SHA1. Of course, this no longer applies
to git-rev-parse alone, but every user of get_sha1().
While at it, add a test.
Signed-off-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>
---
sha1_name.c | 9 ++++++---
t/t6101-rev-parse-parents.sh | 33 +++++++++++++++++++++++++++++++++
2 files changed, 39 insertions(+), 3 deletions(-)
create mode 100644 t/t6101-rev-parse-parents.sh
83c1ab3e9bcba4eca5e055e27f8f4fb0b78518a5
diff --git a/sha1_name.c b/sha1_name.c
--- a/sha1_name.c
+++ b/sha1_name.c
@@ -202,15 +202,18 @@ static int get_sha1_1(const char *name,
parent = name[len-1] - '0';
len -= 2;
}
- else if (len > 1 && name[len-1] == '^')
+ else if (len > 1 && name[len-1] == '^') {
parent = 1;
- else
+ len--;
+ } else
parent = -1;
if (0 <= parent) {
- ret = get_parent(name, len-1, sha1, parent);
+ ret = get_parent(name, len, sha1, parent);
if (!ret)
return 0;
+ else if(parent>0)
+ return ret;
}
ret = get_sha1_basic(name, len, sha1);
if (!ret)
diff --git a/t/t6101-rev-parse-parents.sh b/t/t6101-rev-parse-parents.sh
new file mode 100644
--- /dev/null
+++ b/t/t6101-rev-parse-parents.sh
@@ -0,0 +1,33 @@
+#!/bin/sh
+#
+# Copyright (c) 2005 Johannes Schindelin
+#
+
+test_description='Test git-rev-parse with different parent options'
+
+. ./test-lib.sh
+. ../t6000lib.sh # t6xxx specific functions
+
+date >path0
+git-update-cache --add path0
+save_tag tree git-write-tree
+hide_error save_tag start unique_commit "start" tree
+save_tag second unique_commit "second" tree -p start
+hide_error save_tag start2 unique_commit "start2" tree
+save_tag two_parents unique_commit "next" tree -p second -p start2
+save_tag final unique_commit "final" tree -p two_parents
+
+test_expect_success 'start is valid' 'git-rev-parse start | grep "^[0-9a-f]\{40\}$"'
+test_expect_success 'start^0' "test $(cat .git/refs/tags/start) = $(git-rev-parse start^0)"
+test_expect_success 'start^1 not valid' "test $(git-rev-parse start^1) = start^1"
+test_expect_success 'second^1 = second^' "test $(git-rev-parse second^1) = $(git-rev-parse second^)"
+test_expect_success 'final^1^1^1' "test $(git-rev-parse start) = $(git-rev-parse final^1^1^1)"
+test_expect_success 'final^1^1^1 = final^^^' "test $(git-rev-parse final^1^1^1) = $(git-rev-parse final^^^)"
+test_expect_success 'final^1^2' "test $(git-rev-parse start2) = $(git-rev-parse final^1^2)"
+test_expect_success 'final^1^2 != final^1^1' "test $(git-rev-parse final^1^2) != $(git-rev-parse final^1^1)"
+test_expect_success 'final^1^3 not valid' "test $(git-rev-parse final^1^3) = final^1^3"
+test_expect_failure '--verify start2^1' 'git-rev-parse --verify start2^1'
+test_expect_success '--verify start2^0' 'git-rev-parse --verify start2^0'
+
+test_done
+
^ permalink raw reply
* Re: gitweb - feature request
From: Kay Sievers @ 2005-08-10 2:00 UTC (permalink / raw)
To: Sam Ravnborg; +Cc: Kay Sievers, git
In-Reply-To: <20050809211402.GA21194@vrfy.org>
On Tue, Aug 09, 2005 at 11:14:02PM +0200, Kay Sievers wrote:
> On Tue, Aug 09, 2005 at 10:18:36PM +0200, Sam Ravnborg wrote:
> > On Tue, Aug 09, 2005 at 09:58:18PM +0200, Kay Sievers wrote:
> > > On Tue, Aug 09, 2005 at 09:31:04PM +0200, Sam Ravnborg wrote:
> > > > Hi Kay.
> > > >
> > > > When browsing http://www.kernel.org/git I often find myself looking for
> > > > the most recently changed tree.
> > > > For this it is very good that you have the "last change" in italic and
> > > > bolded if newer than a few hours (I think).
> > >
> > > Hmm, if last change is "minutes" it's bold, if it's "hours" old it's green.
> > > What do you miss?
> > For this part I do not miss anything - the opposite actually. I like
> > this highlighting you do.
> >
> > >
> > > > A nice additional feature would be the possibility to sort the output
> > > > according to last change, owner and description.
> > > > Using a click-able table heading would be the most intuitive way.
> > > >
> > > > I have not looked into the source for gitweb, so I really do not know
> > > > how difficult this would be.
> > >
> > > I was hoping people that want stuff like this would use a RSS reader. :)
> > Some day I will try to use such a beast...
>
> Well, I don't use these beasts myself. :) I will try the sorting with the
> next round - sounds like a nice feature.
Sam,
try it! :)
Kay
^ permalink raw reply
* Re: Newbie question: equiv of: cvs co -p <filename> ?
From: Linus Torvalds @ 2005-08-10 0:36 UTC (permalink / raw)
To: John Ellson; +Cc: git
In-Reply-To: <ddb8vl$ifq$1@sea.gmane.org>
On Tue, 9 Aug 2005, John Ellson wrote:
>
> I hacked this:
>
> #!/bin/bash
> ID=`git-ls-files -s | grep $1 | cut -d ' ' -f 2`
No. "git-ls-files" shows the latest _index_ state, not the latest
committed state.
Use "git-ls-tree HEAD pathname" to get the latest committed state for the
pathname, and then pick out the SHA1 from there, use
git-cat-file blob <sha1>
to cat the result.
Of course, this will work with any revision, not just HEAD. So you could
do something like
git-ls-tree $(git-rev-parse --default HEAD "$@") |
while read mode type sha name
do
case "$type" in
blob)
git-cat-file blob "$sha"
;;
tree)
git-ls-tree "$sha"
;;
*)
exit 1
done
(totally untested)
Linus
^ permalink raw reply
* Re: Cannot install git RPM
From: Ryan Anderson @ 2005-08-10 0:30 UTC (permalink / raw)
To: Junio C Hamano; +Cc: Wolfgang Denk, git
In-Reply-To: <7vr7d3uj7n.fsf@assigned-by-dhcp.cox.net>
On Tue, Aug 09, 2005 at 10:13:32AM -0700, Junio C Hamano wrote:
> Junio C Hamano <junkio@cox.net> writes:
>
> >> But the resulting RPM cannot be installed either, at least not in
> >> standard Fedora Core 2/3/4 installations:
> >> ...
> >> Is there at least some documentation which external packages are
> >> needed, and where to find these?
>
> The problematic one is git-send-email-script.
Yup. I'll take the blame for that one - I forget how inclusive the
Debian packaging is compared to the other distributions.
> I have to admit that it was a mistake to take that patch; I was
> trying to be _too_ inclusive. The script does not even read
> from nor write into a git repository, and the only relevance to
> git is that it is useful for people to patchbomb the list with
> git generated patches. In other words, the program may be
> useful, but its usefulness does not have much to do with git, so
> it does not belong to git.
Well, here I think I disagree. I think it's a valid, possibly vital,
part of the suggested workflow for maintainers of projects. Admittedly,
the emails can be sent by hand in many cases - but for the "clean up the
history" goal of exporting things out as patches, the email step is
important.
> My short-term plan is to downgrade it to "contrib" status, and
> not touch it from the main Makefile. It will be in the 0.99.4
> sources but will not be installed nor made into binary package.
> I hope Ryan does not mind this decision.
Not at all. I agree that the RPM dependency problem is a good reason to
not install it by default. What I will do is make this the beginning
of my directory structure reorganization. I'll probably also convert
the Debian package to a multi-package system, so we have a demonstration
of splitting these two items up.
--
Ryan Anderson
sometimes Pug Majere
^ permalink raw reply
* Re: gitweb - feature request
From: Linus Torvalds @ 2005-08-10 0:19 UTC (permalink / raw)
To: Kay Sievers; +Cc: Johannes Schindelin, Sam Ravnborg, Git Mailing List
In-Reply-To: <20050810001116.GA22489@vrfy.org>
On Wed, 10 Aug 2005, Kay Sievers wrote:
>
> Firefox may need a plugin to be able to read it, I don't really know...
Firefox definitely needs a separate plugin, at least for me.
Linus
^ permalink raw reply
* Re: gitweb - feature request
From: Kay Sievers @ 2005-08-10 0:11 UTC (permalink / raw)
To: Linus Torvalds; +Cc: Johannes Schindelin, Sam Ravnborg, Git Mailing List
In-Reply-To: <Pine.LNX.4.58.0508091447080.3258@g5.osdl.org>
On Tue, Aug 09, 2005 at 02:53:58PM -0700, Linus Torvalds wrote:
>
>
> On Tue, 9 Aug 2005, Johannes Schindelin wrote:
> >
> > You have Firefox, don't you? Next time you surf to gitweb, right click on
> > the funny yellow symbol in the lower right corner of your Firefox. It
> > should say something like "Subscribe to...". Do it.
>
> Left-click. And you need to be inside the project you want to rss (it
> would be nice if you could be at the "projects" page and it would give you
> a list of things to subscribe to, but that may not be possible).
Sure, it is that way. It is called OPML and I once tested it with a RSS
reader and it was able to read the list of offered feeds in with a single
request.
Just click on the RSS pict in the footer and it will return the overview
of the index page. Firefox may need a plugin to be able to read it, I don't
really know...
Kay
^ permalink raw reply
* Re: Newbie question: equiv of: cvs co -p <filename> ?
From: Rene Scharfe @ 2005-08-09 22:18 UTC (permalink / raw)
To: Johannes Schindelin; +Cc: John Ellson, git
In-Reply-To: <Pine.LNX.4.63.0508100009210.10311@wgmdd8.biozentrum.uni-wuerzburg.de>
Johannes Schindelin wrote:
> On Tue, 9 Aug 2005, John Ellson wrote:
>>How can we cat the latest committed state of a file to stdout?
>>
>>I hacked this:
>>
>> #!/bin/bash
>> ID=`git-ls-files -s | grep $1 | cut -d ' ' -f 2`
>
>
> and now:
>
> git-cat-file blob $ID
Still not pretty. How about this?
#!/bin/sh
git-ls-tree HEAD "$@" | while read mode type hash filename; do
[ "$type" = "blob" ] && git-cat-file blob "$hash"
done
Rene
^ permalink raw reply
* Re: Newbie question: equiv of: cvs co -p <filename> ?
From: Johannes Schindelin @ 2005-08-09 22:10 UTC (permalink / raw)
To: John Ellson; +Cc: git
In-Reply-To: <ddb8vl$ifq$1@sea.gmane.org>
Hi,
On Tue, 9 Aug 2005, John Ellson wrote:
> How can we cat the latest committed state of a file to stdout?
>
> I hacked this:
>
> #!/bin/bash
> ID=`git-ls-files -s | grep $1 | cut -d ' ' -f 2`
and now:
git-cat-file blob $ID
Voila,
Dscho
^ permalink raw reply
* Newbie question: equiv of: cvs co -p <filename> ?
From: John Ellson @ 2005-08-09 21:59 UTC (permalink / raw)
To: git
How can we cat the latest committed state of a file to stdout?
I hacked this:
#!/bin/bash
ID=`git-ls-files -s | grep $1 | cut -d ' ' -f 2`
TMP=`git-unpack-file $ID`
cat $TMP
rm $TMP
but its really ugly! It must be easier than this?
John
^ permalink raw reply
* Re: gitweb - feature request
From: Linus Torvalds @ 2005-08-09 21:53 UTC (permalink / raw)
To: Johannes Schindelin; +Cc: Sam Ravnborg, Kay Sievers, Git Mailing List
In-Reply-To: <Pine.LNX.4.63.0508092224580.9849@wgmdd8.biozentrum.uni-wuerzburg.de>
On Tue, 9 Aug 2005, Johannes Schindelin wrote:
>
> You have Firefox, don't you? Next time you surf to gitweb, right click on
> the funny yellow symbol in the lower right corner of your Firefox. It
> should say something like "Subscribe to...". Do it.
Left-click. And you need to be inside the project you want to rss (it
would be nice if you could be at the "projects" page and it would give you
a list of things to subscribe to, but that may not be possible).
Linus
^ permalink raw reply
* Re: gitweb - feature request
From: Kay Sievers @ 2005-08-09 21:14 UTC (permalink / raw)
To: Sam Ravnborg; +Cc: Kay Sievers, git
In-Reply-To: <20050809201836.GA11051@mars.ravnborg.org>
On Tue, Aug 09, 2005 at 10:18:36PM +0200, Sam Ravnborg wrote:
> On Tue, Aug 09, 2005 at 09:58:18PM +0200, Kay Sievers wrote:
> > On Tue, Aug 09, 2005 at 09:31:04PM +0200, Sam Ravnborg wrote:
> > > Hi Kay.
> > >
> > > When browsing http://www.kernel.org/git I often find myself looking for
> > > the most recently changed tree.
> > > For this it is very good that you have the "last change" in italic and
> > > bolded if newer than a few hours (I think).
> >
> > Hmm, if last change is "minutes" it's bold, if it's "hours" old it's green.
> > What do you miss?
> For this part I do not miss anything - the opposite actually. I like
> this highlighting you do.
>
> >
> > > A nice additional feature would be the possibility to sort the output
> > > according to last change, owner and description.
> > > Using a click-able table heading would be the most intuitive way.
> > >
> > > I have not looked into the source for gitweb, so I really do not know
> > > how difficult this would be.
> >
> > I was hoping people that want stuff like this would use a RSS reader. :)
> Some day I will try to use such a beast...
Well, I don't use these beasts myself. :) I will try the sorting with the
next round - sounds like a nice feature.
Kay
^ permalink raw reply
* Re: gitweb - feature request
From: Kay Sievers @ 2005-08-09 21:09 UTC (permalink / raw)
To: John Benes; +Cc: git
In-Reply-To: <42F91759.8010008@gmail.com>
On Tue, Aug 09, 2005 at 03:51:37PM -0500, John Benes wrote:
> Sam Ravnborg wrote:
> >> You have Firefox, don't you? Next time you surf to gitweb, right click on
> >> the funny yellow symbol in the lower right corner of your Firefox. It
> >> should say something like "Subscribe to...". Do it.
> >
> > Unfortunately not on my firefox. 1.0.6 on gentoo.
> > Puzzled...
>
> I don't see it either with Firefox/1.0+ ID:2005080905.
>
> For it to work, this code needs to be added to the HEAD (slightly modified)
>
> <link rel="alternate" type="application/rss+xml" title="GIT Trees"
> href="http://www.kernel.org/git/?a=opml" />
Are you sure that firefox handles opml without a plugin?
Kay
^ permalink raw reply
* Re: [PATCH] Use $DESTDIR instead of $dest
From: Petr Baudis @ 2005-08-09 20:57 UTC (permalink / raw)
To: Junio C Hamano; +Cc: git
In-Reply-To: <7v4qa4geiq.fsf@assigned-by-dhcp.cox.net>
Dear diary, on Sat, Aug 06, 2005 at 01:17:17AM CEST, I got a letter
where Junio C Hamano <junkio@cox.net> told me that...
> Petr Baudis <pasky@suse.cz> writes:
>
> > $DESTDIR is more usual during the build than $dest and is what is usually
> > used in the makefiles, so let's use it too.
>
> While I do not have much preference either way, I do not want to
> make this kind of change without making corresponding changes to
> the spec.in and debian/rules file in the same commit, or another
> commit that immediately follow it. And I wanted to do a 0.99.4
> tomorrow, so I hope you would not mind if I placed this on
> hold...
No problem, this was just some of the last tidbits wrt. synchronization
of the makefiles with Cogito.
--
Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
If you want the holes in your knowledge showing up try teaching
someone. -- Alan Cox
^ permalink raw reply
* [PATCH] Warning fix for gcc 4
From: Pavel Roskin @ 2005-08-09 20:54 UTC (permalink / raw)
To: git
Hello!
This patch fixes the only warning reported by gcc 4.0.1 on Fedora Core 4
for x86_64:
sha1_file.c:1391: warning: pointer targets in assignment differ in
signedness
Signed-off-by: Pavel Roskin <proski@gnu.org>
diff --git a/sha1_file.c b/sha1_file.c
--- a/sha1_file.c
+++ b/sha1_file.c
@@ -1388,7 +1388,7 @@ int write_sha1_from_fd(const unsigned ch
ssize_t size;
if (*bufposn) {
stream.avail_in = *bufposn;
- stream.next_in = buffer;
+ stream.next_in = (unsigned char *) buffer;
do {
stream.next_out = discard;
stream.avail_out = sizeof(discard);
--
Regards,
Pavel Roskin
^ permalink raw reply
* Re: gitweb - feature request
From: John Benes @ 2005-08-09 20:51 UTC (permalink / raw)
To: git
In-Reply-To: <20050809204347.GB11132@mars.ravnborg.org>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Sam Ravnborg wrote:
>> You have Firefox, don't you? Next time you surf to gitweb, right click on
>> the funny yellow symbol in the lower right corner of your Firefox. It
>> should say something like "Subscribe to...". Do it.
>
> Unfortunately not on my firefox. 1.0.6 on gentoo.
> Puzzled...
I don't see it either with Firefox/1.0+ ID:2005080905.
For it to work, this code needs to be added to the HEAD (slightly modified)
<link rel="alternate" type="application/rss+xml" title="GIT Trees"
href="http://www.kernel.org/git/?a=opml" />
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iQIVAwUBQvkXWGF0oWcU9kCNAQLNiA//aeblC39Vlc6z6e3GjG84+9V/vPcXjrE9
MdCllzb9D5aITJSWTxK7Ow5Y1nat0g9Cnf1AgrG6wPT6Uvm+7j61EqH5rcjYx/mU
kNe+251cHHBnGohdXyV4n20KCoEnXKZOQX7p7R3dJWifR4eyUzacSQiA51WmNPIl
vkV+JpTD6lPAIcZxJMXOJWUblaDA0reMPoCQ2nz7gqZOsQP7qWvzi0uyIAxjhaPd
AQ5UzEE9l9Wt5J7Oyx/ldz9i5e54EZxFgkaDWlLpDwVpUChmlVBx5V1ltTRh3Ymp
7lCPfy7JFN7eIQpAKp2/rldxvWK2gobSErTJR6nfs3ohSxe6WPLEpVS5Bfxrjo+8
a0LUOi/9E2+Kj1ja1Wf165GkQlI7ZfQgrmFRm8pVWS9WwkjlDvZbHjArv4lg6X6w
02yGuiyT2P0MIhia7SJF7xFM+lUi8mDdT/psnrZQ1++UhckuGPwWTa0EJ8nVWfk2
KkN3G3R1RVdSSgQSlh71ngNzwyFmxvMjHAZHB5ETtiO+/Of6TMkW+o3S8oJrbJSh
9M7WjDlKSUl7R3NcBE2iqx9NUyz7ldwPme+iG/w3aTAsvNaMOgjzsVloEosVeDIh
I/GOOujl+ym2IiJsAX9YRyaKmcBTZGEjfnUNWhf14hMDeM5fB5N8P6f+6JsMOB/N
s8U1L/LUiCc=
=ai+1
-----END PGP SIGNATURE-----
^ permalink raw reply
* Re: Template files location
From: Petr Baudis @ 2005-08-09 20:42 UTC (permalink / raw)
To: Junio C Hamano; +Cc: Chris Wright, Linus Torvalds, git
In-Reply-To: <7vpsssjnld.fsf@assigned-by-dhcp.cox.net>
Dear diary, on Fri, Aug 05, 2005 at 07:33:02PM CEST, I got a letter
where Junio C Hamano <junkio@cox.net> told me that...
> *2* And I am sure many others shared the same objection but did
> not even bother to say anything because what Johannes said made
> a lot of sense and what the patch did was obviously wrong.
Me too, actually. I just didn't step out to see the big picture when
writing the grandparent. Now I agree with everything you said.
--
Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
If you want the holes in your knowledge showing up try teaching
someone. -- Alan Cox
^ permalink raw reply
* Re: gitweb - feature request
From: Sam Ravnborg @ 2005-08-09 20:43 UTC (permalink / raw)
To: Johannes Schindelin; +Cc: Kay Sievers, Kay Sievers, git
In-Reply-To: <Pine.LNX.4.63.0508092224580.9849@wgmdd8.biozentrum.uni-wuerzburg.de>
> You have Firefox, don't you? Next time you surf to gitweb, right click on
> the funny yellow symbol in the lower right corner of your Firefox. It
> should say something like "Subscribe to...". Do it.
Unfortunately not on my firefox. 1.0.6 on gentoo.
Puzzled...
Sam
^ permalink raw reply
* Re: gitweb - feature request
From: Johannes Schindelin @ 2005-08-09 20:27 UTC (permalink / raw)
To: Sam Ravnborg; +Cc: Kay Sievers, Kay Sievers, git
In-Reply-To: <20050809201836.GA11051@mars.ravnborg.org>
Hi,
On Tue, 9 Aug 2005, Sam Ravnborg wrote:
> On Tue, Aug 09, 2005 at 09:58:18PM +0200, Kay Sievers wrote:
> >
> > I was hoping people that want stuff like this would use a RSS reader. :)
> Some day I will try to use such a beast...
You have Firefox, don't you? Next time you surf to gitweb, right click on
the funny yellow symbol in the lower right corner of your Firefox. It
should say something like "Subscribe to...". Do it.
Then, in you bookmark menu, you should see the entry, with a small arrow
to the right. Click on the entry...
Ciao,
Dscho
^ permalink raw reply
* Re: gitweb - feature request
From: Sam Ravnborg @ 2005-08-09 20:18 UTC (permalink / raw)
To: Kay Sievers; +Cc: Kay Sievers, git
In-Reply-To: <20050809195818.GA19284@vrfy.org>
On Tue, Aug 09, 2005 at 09:58:18PM +0200, Kay Sievers wrote:
> On Tue, Aug 09, 2005 at 09:31:04PM +0200, Sam Ravnborg wrote:
> > Hi Kay.
> >
> > When browsing http://www.kernel.org/git I often find myself looking for
> > the most recently changed tree.
> > For this it is very good that you have the "last change" in italic and
> > bolded if newer than a few hours (I think).
>
> Hmm, if last change is "minutes" it's bold, if it's "hours" old it's green.
> What do you miss?
For this part I do not miss anything - the opposite actually. I like
this highlighting you do.
>
> > A nice additional feature would be the possibility to sort the output
> > according to last change, owner and description.
> > Using a click-able table heading would be the most intuitive way.
> >
> > I have not looked into the source for gitweb, so I really do not know
> > how difficult this would be.
>
> I was hoping people that want stuff like this would use a RSS reader. :)
Some day I will try to use such a beast...
Sam
^ permalink raw reply
* Re: gitweb - feature request
From: Kay Sievers @ 2005-08-09 19:58 UTC (permalink / raw)
To: Sam Ravnborg; +Cc: Kay Sievers, git
In-Reply-To: <20050809193104.GA10858@mars.ravnborg.org>
On Tue, Aug 09, 2005 at 09:31:04PM +0200, Sam Ravnborg wrote:
> Hi Kay.
>
> When browsing http://www.kernel.org/git I often find myself looking for
> the most recently changed tree.
> For this it is very good that you have the "last change" in italic and
> bolded if newer than a few hours (I think).
Hmm, if last change is "minutes" it's bold, if it's "hours" old it's green.
What do you miss?
> A nice additional feature would be the possibility to sort the output
> according to last change, owner and description.
> Using a click-able table heading would be the most intuitive way.
>
> I have not looked into the source for gitweb, so I really do not know
> how difficult this would be.
I was hoping people that want stuff like this would use a RSS reader. :)
Kay
^ permalink raw reply
* gitweb - feature request
From: Sam Ravnborg @ 2005-08-09 19:31 UTC (permalink / raw)
To: Kay Sievers, git
Hi Kay.
When browsing http://www.kernel.org/git I often find myself looking for
the most recently changed tree.
For this it is very good that you have the "last change" in italic and
bolded if newer than a few hours (I think).
A nice additional feature would be the possibility to sort the output
according to last change, owner and description.
Using a click-able table heading would be the most intuitive way.
I have not looked into the source for gitweb, so I really do not know
how difficult this would be.
Sam
^ permalink raw reply
* Re: [PATCH] -Werror fixes
From: Timo Sirainen @ 2005-08-09 18:11 UTC (permalink / raw)
To: git
In-Reply-To: <1123601422.21306.46.camel@hurina>
[-- Attachment #1: Type: text/plain, Size: 289 bytes --]
On Tue, 2005-08-09 at 18:30 +0300, Timo Sirainen wrote:
> GCC's format __attribute__ is good for checking errors, especially with
> -Werror=2 parameter. Patch below fixes most of the reported problems
> against 2005-08-09 snapshot.
Eh. -Wformat=2 of course. What was I thinking..
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
^ permalink raw reply
* Re: Cannot install git RPM
From: Junio C Hamano @ 2005-08-09 17:13 UTC (permalink / raw)
To: Wolfgang Denk; +Cc: git
In-Reply-To: <7v3bpjxoi1.fsf@assigned-by-dhcp.cox.net>
Junio C Hamano <junkio@cox.net> writes:
>> But the resulting RPM cannot be installed either, at least not in
>> standard Fedora Core 2/3/4 installations:
>> ...
>> Is there at least some documentation which external packages are
>> needed, and where to find these?
The problematic one is git-send-email-script.
I have to admit that it was a mistake to take that patch; I was
trying to be _too_ inclusive. The script does not even read
from nor write into a git repository, and the only relevance to
git is that it is useful for people to patchbomb the list with
git generated patches. In other words, the program may be
useful, but its usefulness does not have much to do with git, so
it does not belong to git.
My short-term plan is to downgrade it to "contrib" status, and
not touch it from the main Makefile. It will be in the 0.99.4
sources but will not be installed nor made into binary package.
I hope Ryan does not mind this decision.
After we audit the set of tools we currently ship, along with
some other scripts/programs, either we remove it altogether from
our source tree, or create a contrib/ subdirectory and move it
there.
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox