* [PATCH 14/17] Documentation/git-http-fetch.txt: Document the commit-id argument.
From: Nikolai Weibull @ 2005-12-08 23:28 UTC (permalink / raw)
To: git; +Cc: Nikolai Weibull
In-Reply-To: <11340844852496-git-send-email-mailing-lists.git@rawuncut.elitemail.org>
Signed-off-by: Nikolai Weibull <nikolai@bitwi.se>
---
Documentation/git-http-fetch.txt | 6 ++++++
1 files changed, 6 insertions(+), 0 deletions(-)
3bd76463c218402e883fc5c173ba9b9af77640bf
diff --git a/Documentation/git-http-fetch.txt b/Documentation/git-http-fetch.txt
index 088624f..1116e85 100644
--- a/Documentation/git-http-fetch.txt
+++ b/Documentation/git-http-fetch.txt
@@ -14,6 +14,12 @@ DESCRIPTION
-----------
Downloads a remote git repository via HTTP.
+OPTIONS
+-------
+commit-id::
+ Either the hash or the filename under [URL]/refs/ to
+ pull.
+
-c::
Get the commit objects.
-t::
--
0.99.9l
^ permalink raw reply related
* [PATCH 12/17] Documentation/git-ls-remote.txt: Add -h and -t.
From: Nikolai Weibull @ 2005-12-08 23:28 UTC (permalink / raw)
To: git; +Cc: Nikolai Weibull
In-Reply-To: <11340844853961-git-send-email-mailing-lists.git@rawuncut.elitemail.org>
-h and -t are aliases for --heads and --tags to git-ls-remote.
Signed-off-by: Nikolai Weibull <nikolai@bitwi.se>
---
Documentation/git-ls-remote.txt | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
763853d9c9f2b9c0f5c76138f081d13640a24666
diff --git a/Documentation/git-ls-remote.txt b/Documentation/git-ls-remote.txt
index c0a80d4..66fe60f 100644
--- a/Documentation/git-ls-remote.txt
+++ b/Documentation/git-ls-remote.txt
@@ -17,7 +17,7 @@ Displays the references other repository
OPTIONS
-------
---heads --tags::
+-h|--heads, -t|--tags::
Limit to only refs/heads and refs/tags, respectively.
These options are _not_ mutually exclusive; when given
both, references stored in refs/heads and refs/tags are
--
0.99.9l
^ permalink raw reply related
* [PATCH 13/17] Documentation/git-repack.txt: Add -l and -n.
From: Nikolai Weibull @ 2005-12-08 23:28 UTC (permalink / raw)
To: git; +Cc: Nikolai Weibull
In-Reply-To: <11340844853230-git-send-email-mailing-lists.git@rawuncut.elitemail.org>
This adds documentation for the -l and -n options to git-repack.
Signed-off-by: Nikolai Weibull <nikolai@bitwi.se>
---
Documentation/git-repack.txt | 9 ++++++++-
1 files changed, 8 insertions(+), 1 deletions(-)
74b49b4c4f2e04066f36011215106627f3405338
diff --git a/Documentation/git-repack.txt b/Documentation/git-repack.txt
index 0c1ae49..9060fe8 100644
--- a/Documentation/git-repack.txt
+++ b/Documentation/git-repack.txt
@@ -9,7 +9,7 @@ objects into pack files.
SYNOPSIS
--------
-'git-repack' [-a] [-d]
+'git-repack' [-a] [-d] [-l] [-n]
DESCRIPTION
-----------
@@ -39,6 +39,13 @@ OPTIONS
After packing, if the newly created packs make some
existing packs redundant, remove the redundant packs.
+-l::
+ Pass the `--local` option to `git pack-objects`, see
+ gitlink:git-pack-objects[1].
+
+-n::
+ Do not update the server information with
+ `git update-server-info`.
Author
------
--
0.99.9l
^ permalink raw reply related
* [PATCH 7/17] Documentation/git-cvsimport.txt: Fix a slight glitch in description heading.
From: Nikolai Weibull @ 2005-12-08 23:28 UTC (permalink / raw)
To: git; +Cc: Nikolai Weibull
In-Reply-To: <1134084485869-git-send-email-mailing-lists.git@rawuncut.elitemail.org>
Signed-off-by: Nikolai Weibull <nikolai@bitwi.se>
---
Documentation/git-cvsimport.txt | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
98723ba21e0ffdbfc183a2b878938ab17744317d
diff --git a/Documentation/git-cvsimport.txt b/Documentation/git-cvsimport.txt
index 88bd3b0..f89b251 100644
--- a/Documentation/git-cvsimport.txt
+++ b/Documentation/git-cvsimport.txt
@@ -60,7 +60,7 @@ the old cvs2git tool.
+
If you need to pass multiple options, separate them with a comma.
--P:: <cvsps-output-file>
+-P <cvsps-output-file>::
Instead of calling cvsps, read the provided cvsps output file. Useful
for debugging or when cvsps is being handled outside cvsimport.
--
0.99.9l
^ permalink raw reply related
* [PATCH 6/17] Document the [<head>...] and -- arguments to git-prune.
From: Nikolai Weibull @ 2005-12-08 23:28 UTC (permalink / raw)
To: git; +Cc: Nikolai Weibull
In-Reply-To: <1134084485547-git-send-email-mailing-lists.git@rawuncut.elitemail.org>
The documentation for git-prune was lacking descriptions of the head
arguments and the -- option.
Signed-off-by: Nikolai Weibull <nikolai@bitwi.se>
---
Documentation/git-prune.txt | 10 +++++++++-
1 files changed, 9 insertions(+), 1 deletions(-)
b4491eee9b9e371f4c9ea65c93be998a4f37498c
diff --git a/Documentation/git-prune.txt b/Documentation/git-prune.txt
index 3367c9b..04cea76 100644
--- a/Documentation/git-prune.txt
+++ b/Documentation/git-prune.txt
@@ -8,7 +8,7 @@ git-prune - Prunes all unreachable objec
SYNOPSIS
--------
-'git-prune' [-n]
+'git-prune' [-n] [--] [<head>...]
DESCRIPTION
-----------
@@ -26,7 +26,15 @@ OPTIONS
-n::
Do not remove anything; just report what it would
remove.
+--::
+ Do not interpret any more arguments as options.
+<head>...::
+ The heads to look for unreachable objects in. This is
+ relative to $GIT_DIR (e.g., "HEAD", "refs/heads/master").
+ When unspecified, all heads are updated to match the
+ remote repository.
+
Author
------
--
0.99.9l
^ permalink raw reply related
* [PATCH 3/17] Use uniform description for the '--' option.
From: Nikolai Weibull @ 2005-12-08 23:28 UTC (permalink / raw)
To: git; +Cc: Nikolai Weibull
In-Reply-To: <11340844854119-git-send-email-mailing-lists.git@rawuncut.elitemail.org>
All descriptions of the '--' option were the same except for that in
Documentation/git-merge-index.txt.
Signed-off-by: Nikolai Weibull <nikolai@bitwi.se>
---
Documentation/git-merge-index.txt | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
54160acf1b953d34c161b27aa2b320bbf61ac86e
diff --git a/Documentation/git-merge-index.txt b/Documentation/git-merge-index.txt
index 6030642..fbc986a 100644
--- a/Documentation/git-merge-index.txt
+++ b/Documentation/git-merge-index.txt
@@ -20,7 +20,7 @@ files are passed as arguments 5, 6 and 7
OPTIONS
-------
--::
- Interpret all following arguments as filenames.
+ Do not interpret any more arguments as options.
-a::
Run merge against all files in the index that need merging.
--
0.99.9l
^ permalink raw reply related
* [PATCH 0/17] Documentation fixes in response to my previous listing
From: Nikolai Weibull @ 2005-12-08 23:28 UTC (permalink / raw)
To: git
This is a series of patches that fix small issues with the documentation.
This includes missing option-aliases, missing options, and broken formatting.
nikolai
---
Documentation/git-am.txt | 2 +-
Documentation/git-cherry-pick.txt | 6 ++---
Documentation/git-commit.txt | 18 +++++++++-----
Documentation/git-cvsimport.txt | 2 +-
Documentation/git-format-patch.txt | 23 +++++++++++++----
Documentation/git-http-fetch.txt | 6 +++++
Documentation/git-ls-remote.txt | 2 +-
Documentation/git-merge-index.txt | 2 +-
Documentation/git-pack-objects.txt | 6 ++++-
Documentation/git-prune.txt | 10 +++++++-
Documentation/git-read-tree.txt | 2 +-
Documentation/git-repack.txt | 9 ++++++-
Documentation/git-revert.txt | 4 ++-
Documentation/git-show-branch.txt | 8 +++++-
Documentation/git-tag.txt | 40 +++++++++++++++---------------
Documentation/git-update-server-info.txt | 2 +-
Documentation/git-verify-pack.txt | 4 ++-
git-revert.sh | 2 +-
pack-objects.c | 2 +-
show-branch.c | 2 +-
20 files changed, 101 insertions(+), 51 deletions(-)
^ permalink raw reply
* [PATCH 4/17] Documentation/git-commit.txt: Add long options and -- to documentation.
From: Nikolai Weibull @ 2005-12-08 23:28 UTC (permalink / raw)
To: git; +Cc: Nikolai Weibull
In-Reply-To: <11340844852030-git-send-email-mailing-lists.git@rawuncut.elitemail.org>
Added the following long options to documentation:
* --all
* --signoff
* --verify
* --no-verify
* --edit
Also added documentation for the -- option for terminating option parsing.
Signed-off-by: Nikolai Weibull <nikolai@bitwi.se>
---
Documentation/git-commit.txt | 18 ++++++++++++------
1 files changed, 12 insertions(+), 6 deletions(-)
f0cc0137f124e36fd31acb8d0d543bdc84923586
diff --git a/Documentation/git-commit.txt b/Documentation/git-commit.txt
index 1edc278..b92cf48 100644
--- a/Documentation/git-commit.txt
+++ b/Documentation/git-commit.txt
@@ -7,7 +7,7 @@ git-commit - Record your changes
SYNOPSIS
--------
-'git-commit' [-a] [-s] [-v] [(-c | -C) <commit> | -F <file> | -m <msg>] [-e] <file>...
+'git-commit' [-a] [-s] [-v] [(-c | -C) <commit> | -F <file> | -m <msg>] [-e] [--] <file>...
DESCRIPTION
-----------
@@ -22,7 +22,7 @@ information.
OPTIONS
-------
--a::
+-a|--all::
Update all paths in the index file.
-c or -C <commit>::
@@ -39,23 +39,29 @@ OPTIONS
-m <msg>::
Use the given <msg> as the commit message.
--s::
+-s|--signoff::
Add Signed-off-by line at the end of the commit message.
--v::
+-v|--verify::
Look for suspicious lines the commit introduces, and
abort committing if there is one. The definition of
'suspicious lines' is currently the lines that has
trailing whitespaces, and the lines whose indentation
has a SP character immediately followed by a TAB
- character.
+ character. This is the default.
--e::
+-n|--no-verify::
+ The opposite of `--verify`.
+
+-e|--edit::
The message taken from file with `-F`, command line with
`-m`, and from file with `-C` are usually used as the
commit log message unmodified. This option lets you
further edit the message taken from these sources.
+--::
+ Do not interpret any more arguments as options.
+
<file>...::
Update specified paths in the index file before committing.
--
0.99.9l
^ permalink raw reply related
* [PATCH 1/17] Document the --non-empty command-line option to git-pack-objects.
From: Nikolai Weibull @ 2005-12-08 23:28 UTC (permalink / raw)
To: git; +Cc: Nikolai Weibull
In-Reply-To: <11340844841342-git-send-email-mailing-lists.git@rawuncut.elitemail.org>
This provides (minimal) documentation for the --non-empty command-line
option to the pack-objects command.
Signed-off-by: Nikolai Weibull <nikolai@bitwi.se>
---
Documentation/git-pack-objects.txt | 6 +++++-
pack-objects.c | 2 +-
2 files changed, 6 insertions(+), 2 deletions(-)
50543554f2945443c10434fcfe6689bc7cc5c3e8
diff --git a/Documentation/git-pack-objects.txt b/Documentation/git-pack-objects.txt
index d1e93db..009ec5a 100644
--- a/Documentation/git-pack-objects.txt
+++ b/Documentation/git-pack-objects.txt
@@ -8,7 +8,7 @@ git-pack-objects - Create a packed archi
SYNOPSIS
--------
-'git-pack-objects' [--local] [--incremental] [--window=N] [--depth=N] {--stdout | base-name} < object-list
+'git-pack-objects' [--non-empty] [--local] [--incremental] [--window=N] [--depth=N] {--stdout | base-name} < object-list
DESCRIPTION
@@ -70,6 +70,10 @@ base-name::
that are packed and not in the local object store
(i.e. borrowed from an alternate).
+--non-empty::
+ Only create a packed archive if it would contain at
+ least one object.
+
Author
------
Written by Linus Torvalds <torvalds@osdl.org>
diff --git a/pack-objects.c b/pack-objects.c
index a62c9f8..caf3b6b 100644
--- a/pack-objects.c
+++ b/pack-objects.c
@@ -4,7 +4,7 @@
#include "pack.h"
#include "csum-file.h"
-static const char pack_usage[] = "git-pack-objects [--local] [--incremental] [--window=N] [--depth=N] {--stdout | base-name} < object-list";
+static const char pack_usage[] = "git-pack-objects [--non-empty] [--local] [--incremental] [--window=N] [--depth=N] {--stdout | base-name} < object-list";
struct object_entry {
unsigned char sha1[20];
--
0.99.9l
^ permalink raw reply related
* Re: gitweb.cgi in C
From: Andreas Ericsson @ 2005-12-08 22:48 UTC (permalink / raw)
To: Junio C Hamano; +Cc: Petr Baudis, git
In-Reply-To: <7vfyp3b4ki.fsf@assigned-by-dhcp.cox.net>
Junio C Hamano wrote:
> Petr Baudis <pasky@suse.cz> writes:
>
>
>>Dear diary, on Thu, Dec 08, 2005 at 07:59:37PM CET, I got a letter
>>where Majkls <majkls@tiscali.cz> said that...
>>
>>>What do you think about gitweb.cgi in C?
>>
>>To add to the collective dismay - why bother?
>
>
> It _might_ make sense to do gitweb using libified git Smurf is
> working on, in order to reduce forks and execs, but that is
> mostly independent of rewriting that in C.
>
In that case it would be better and way cooler to have mod_git for Apache.
--
Andreas Ericsson andreas.ericsson@op5.se
OP5 AB www.op5.se
Tel: +46 8-230225 Fax: +46 8-230231
^ permalink raw reply
* Re: gitweb.cgi in C
From: Petr Baudis @ 2005-12-08 22:46 UTC (permalink / raw)
To: Junio C Hamano; +Cc: git
In-Reply-To: <7vfyp3b4ki.fsf@assigned-by-dhcp.cox.net>
Dear diary, on Thu, Dec 08, 2005 at 11:35:09PM CET, I got a letter
where Junio C Hamano <junkio@cox.net> said that...
> Petr Baudis <pasky@suse.cz> writes:
>
> > Dear diary, on Thu, Dec 08, 2005 at 07:59:37PM CET, I got a letter
> > where Majkls <majkls@tiscali.cz> said that...
> >> What do you think about gitweb.cgi in C?
> >
> > To add to the collective dismay - why bother?
>
> It _might_ make sense to do gitweb using libified git Smurf is
> working on, in order to reduce forks and execs, but that is
> mostly independent of rewriting that in C.
I'd see having Perl XS for libgit as something much more sensible. And
you could do cute porcelain stuff with that as well.
--
Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
VI has two modes: the one in which it beeps and the one in which
it doesn't.
^ permalink raw reply
* Re: gitweb.cgi in C
From: H. Peter Anvin @ 2005-12-08 22:39 UTC (permalink / raw)
To: Majkls; +Cc: git
In-Reply-To: <43988299.4090101@tiscali.cz>
Majkls wrote:
> What do you think about gitweb.cgi in C?
I guess you could implement and benchmark it and see how much faster it is.
-hpa
^ permalink raw reply
* Re: gitweb.cgi in C
From: Junio C Hamano @ 2005-12-08 22:35 UTC (permalink / raw)
To: Petr Baudis; +Cc: git
In-Reply-To: <20051208222759.GO22159@pasky.or.cz>
Petr Baudis <pasky@suse.cz> writes:
> Dear diary, on Thu, Dec 08, 2005 at 07:59:37PM CET, I got a letter
> where Majkls <majkls@tiscali.cz> said that...
>> What do you think about gitweb.cgi in C?
>
> To add to the collective dismay - why bother?
It _might_ make sense to do gitweb using libified git Smurf is
working on, in order to reduce forks and execs, but that is
mostly independent of rewriting that in C.
^ permalink raw reply
* Re: gitweb.cgi in C
From: Petr Baudis @ 2005-12-08 22:27 UTC (permalink / raw)
To: Majkls; +Cc: git
In-Reply-To: <43988299.4090101@tiscali.cz>
Dear diary, on Thu, Dec 08, 2005 at 07:59:37PM CET, I got a letter
where Majkls <majkls@tiscali.cz> said that...
> What do you think about gitweb.cgi in C?
To add to the collective dismay - why bother?
--
Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
VI has two modes: the one in which it beeps and the one in which
it doesn't.
^ permalink raw reply
* Re: as promised, docs: git for the confused
From: H. Peter Anvin @ 2005-12-08 22:02 UTC (permalink / raw)
To: Junio C Hamano; +Cc: linux, git
In-Reply-To: <7vk6efb6ib.fsf@assigned-by-dhcp.cox.net>
Junio C Hamano wrote:
> linux@horizon.com writes:
>
>
>>* Terminology - heads, branches, refs, and revisions
>>
>>(This is a supplement to what's already in "man git".)
>>
>>The most common object needed by git primitives is a tree. Since a
>>commit points to a tree and a tag points to a commit, both of these are
>>acceptable "tree-ish" objects and can be used interchangeably. Likewise,
>>a tag is "commit-ish" and can be used where a commit is required.
>
>
> I am unsure if we want to further confuse readers by saying
> this, but technically, "Likewise, a tag which is commit-ish can
> be used in place of commit". Not all tags are necessarily
> commit-ish. v2.6.11 tag is tree-ish but not commit-ish for
> example. Typically, however, a tag is commit-ish.
>
Saying they can be used interchangably is just plain wrong, however.
It's not a bijective relation.
Something like:
>> The most common object needed by git primitives is a tree. Since a
>> commit points and tags uniquely identify a tree, a commit or tag can
>> be used anywhere a tree is expected.
>> Likewise, most tags point to commits and can be used anywhere a
>> commit is expected.
... might be better, and avoids the colloquialisms.
-hpa
^ permalink raw reply
* Re: as promised, docs: git for the confused
From: Junio C Hamano @ 2005-12-08 21:53 UTC (permalink / raw)
To: linux; +Cc: git
In-Reply-To: <20051208063409.31967.qmail@science.horizon.com>
linux@horizon.com writes:
> * Terminology - heads, branches, refs, and revisions
>
> (This is a supplement to what's already in "man git".)
>
> The most common object needed by git primitives is a tree. Since a
> commit points to a tree and a tag points to a commit, both of these are
> acceptable "tree-ish" objects and can be used interchangeably. Likewise,
> a tag is "commit-ish" and can be used where a commit is required.
I am unsure if we want to further confuse readers by saying
this, but technically, "Likewise, a tag which is commit-ish can
be used in place of commit". Not all tags are necessarily
commit-ish. v2.6.11 tag is tree-ish but not commit-ish for
example. Typically, however, a tag is commit-ish.
^ permalink raw reply
* Re: [PATCH] use "git init-db" in tests
From: Junio C Hamano @ 2005-12-08 21:24 UTC (permalink / raw)
To: Alex Riesen; +Cc: git
In-Reply-To: <20051208210251.GB19423@steel.home>
Alex Riesen <raa.lkml@gmail.com> writes:
> You do miss something. glibc will happily continue lookup if
> git-init-db in the top of the build directory is not executable, and
> it will take the next one it finds (and people _will_ have git-init-db
> in PATH).
And the reason git-init-db we just built is not executable
is...?
^ permalink raw reply
* gitk error on a single commit
From: M_ @ 2005-12-08 20:20 UTC (permalink / raw)
To: git
Pointing gitk (git version 0.99.9l) on commit
5569bf9bbedd63a00780fc5c110e0cfab3aa97b9
gives this error:
can't read "treediffs(5569bf9bbedd63a00780fc5c110e0cfab3aa97b9
fae22ac9d7b5fd8bbf0fcfb01aab01c27d84912f)": no such element in array
can't read "treediffs(5569bf9bbedd63a00780fc5c110e0cfab3aa97b9
fae22ac9d7b5fd8bbf0fcfb01aab01c27d84912f)": no such element in array
while executing
"set files $treediffs([list $diffmergeid $p])"
(procedure "contmergediff" line 42)
invoked from within
"contmergediff {}"
(procedure "mergediff" line 12)
invoked from within
"mergediff $id"
(procedure "selectline" line 113)
invoked from within
"selectline $l 1"
(procedure "selcanvline" line 16)
invoked from within
"selcanvline .ctop.top.clist.canv 258 218"
(command bound to event)
...and I think this doesn't happen with any other commit in git's history (so
far). What could the reason be?
^ permalink raw reply
* Re: [PATCH] use "git init-db" in tests
From: Alex Riesen @ 2005-12-08 21:02 UTC (permalink / raw)
To: Junio C Hamano; +Cc: git
In-Reply-To: <7vu0dje2oi.fsf@assigned-by-dhcp.cox.net>
Junio C Hamano, Thu, Dec 08, 2005 21:47:41 +0100:
>
> > Unless there was a special reason to use git-init-db from $PATH, could
> > the patch below be accepted? It makes the test suite use git-init-db
> > from the "the binaries we have just built".
>
> A few lines above what you patched we do make sure the PATH
> starts with the top of the build directory where you would find
> git-init-db we have just built, so unless I am missing something...
>
You do miss something. glibc will happily continue lookup if
git-init-db in the top of the build directory is not executable, and
it will take the next one it finds (and people _will_ have git-init-db
in PATH).
^ permalink raw reply
* Re: [PATCH] use "git init-db" in tests
From: Alex Riesen @ 2005-12-08 20:59 UTC (permalink / raw)
To: git; +Cc: Junio C Hamano
In-Reply-To: <20051208202555.GA3046@steel.home>
Alex Riesen, Thu, Dec 08, 2005 21:25:55 +0100:
> -git-init-db --template=../../templates/blt/ 2>/dev/null ||
> -error "cannot run git-init-db"
> +git init-db --template=../../templates/blt/ 2>/dev/null ||
> +error "cannot run git init-db"
"$GIT_EXEC_PATH/git init-db", of course.
Signed-off-by: Alex Riesen <fork0@users.sf.net>
---
t/test-lib.sh | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
33dbb3dacf1b38c40f091dd800ea2dafdfa1fd3f
diff --git a/t/test-lib.sh b/t/test-lib.sh
index 0539dac..777c748 100755
--- a/t/test-lib.sh
+++ b/t/test-lib.sh
@@ -190,8 +190,8 @@ test=trash
rm -fr "$test"
mkdir "$test"
cd "$test"
-git-init-db --template=../../templates/blt/ 2>/dev/null ||
-error "cannot run git-init-db"
+"$GIT_EXEC_PATH/git" init-db --template=../../templates/blt/ 2>/dev/null ||
+error "cannot run $GIT_EXEC_PATH/git init-db"
mv .git/hooks .git/hooks-disabled
--
0.99.9.GIT
^ permalink raw reply related
* Re: [PATCH] use "git init-db" in tests
From: Junio C Hamano @ 2005-12-08 20:47 UTC (permalink / raw)
To: Alex Riesen; +Cc: git
In-Reply-To: <20051208202555.GA3046@steel.home>
Alex Riesen <raa.lkml@gmail.com> writes:
> Unless there was a special reason to use git-init-db from $PATH, could
> the patch below be accepted? It makes the test suite use git-init-db
> from the "the binaries we have just built".
A few lines above what you patched we do make sure the PATH
starts with the top of the build directory where you would find
git-init-db we have just built, so unless I am missing something...
^ permalink raw reply
* [PATCH] use "git init-db" in tests
From: Alex Riesen @ 2005-12-08 20:25 UTC (permalink / raw)
To: git; +Cc: Junio C Hamano
Unless there was a special reason to use git-init-db from $PATH, could
the patch below be accepted? It makes the test suite use git-init-db
from the "the binaries we have just built".
The reason, why we need the patch even if the $PATH is set, will be
better explained by glibc's sources: the lookup does not stop if the
file exists but has no execute permission.
See file posix/execvp.c, the loop iterating over elements in $PATH:
switch (errno)
{
case EACCES:
/* Record the we got a `Permission denied' error. If we end
up finding no executable we can use, we want to diagnose
that we did find one but were denied access. */
got_eacces = true;
...
break;
...
}
...
/* We tried every element and none of them worked. */
if (got_eacces)
/* At least one failure was due to permissions, so report that
error. */
__set_errno (EACCES);
Signed-off-by: Alex Riesen <raa.lkml@gmail.com>
---
By the same reason, the whole testsuite should be reviewed to use
"git <command>" notation.
t/test-lib.sh | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
4417503d10870c913cff4f635acf274b7da75864
diff --git a/t/test-lib.sh b/t/test-lib.sh
index 0539dac..3704e5f 100755
--- a/t/test-lib.sh
+++ b/t/test-lib.sh
@@ -190,8 +190,8 @@ test=trash
rm -fr "$test"
mkdir "$test"
cd "$test"
-git-init-db --template=../../templates/blt/ 2>/dev/null ||
-error "cannot run git-init-db"
+git init-db --template=../../templates/blt/ 2>/dev/null ||
+error "cannot run git init-db"
mv .git/hooks .git/hooks-disabled
--
0.99.9.GIT
^ permalink raw reply related
* Re: gitweb.cgi in C
From: Johannes Schindelin @ 2005-12-08 19:51 UTC (permalink / raw)
To: Kay Sievers; +Cc: Majkls, git
In-Reply-To: <20051208185503.GA16258@vrfy.org>
Hi,
On Thu, 8 Dec 2005, Kay Sievers wrote:
> On Thu, Dec 08, 2005 at 07:59:37PM +0100, Majkls wrote:
> > What do you think about gitweb.cgi in C?
>
> It's horribly stupid, I think. :)
It is as stupid as you make it :-)
Ciao,
Dscho
^ permalink raw reply
* Re: gitweb.cgi in C
From: Ryan Anderson @ 2005-12-08 19:46 UTC (permalink / raw)
To: Majkls; +Cc: git
In-Reply-To: <43988299.4090101@tiscali.cz>
On Thu, Dec 08, 2005 at 07:59:37PM +0100, Majkls wrote:
> What do you think about gitweb.cgi in C?
I've seen CGI programs in C before.
I don't recommend it. I think it will give most security people
nightmares, heh.
--
Ryan Anderson
sometimes Pug Majere
^ permalink raw reply
* Re: gitweb.cgi in C
From: Kay Sievers @ 2005-12-08 18:55 UTC (permalink / raw)
To: Majkls; +Cc: git
In-Reply-To: <43988299.4090101@tiscali.cz>
On Thu, Dec 08, 2005 at 07:59:37PM +0100, Majkls wrote:
> What do you think about gitweb.cgi in C?
It's horribly stupid, I think. :)
Kay
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox