* Re: [PATCH] Use a strbuf for copying the command line for the reflog.
From: Kristian Høgsberg @ 2007-12-04 15:46 UTC (permalink / raw)
To: gitster; +Cc: git
In-Reply-To: <1196753147-20073-1-git-send-email-krh@redhat.com>
Doh, I forgot -n to git-format-patch again for this two patch series.
Maybe git-format-patch should default to -n when there's more than one
patch? Anyway, it should have been:
[PATCH 1/2] Use a strbuf for copying the command line for the reflog.
[PATCH 2/2] Rewrite builtin-fetch option parsing to use parse_options().
cheers,
Kristian
^ permalink raw reply
* Re: [PATCH] t9600: require cvsps 2.1 to perform tests
From: Jeff King @ 2007-12-04 15:44 UTC (permalink / raw)
To: Junio C Hamano; +Cc: gitzilla, Johannes Schindelin, git
In-Reply-To: <7v1wa3aukt.fsf@gitster.siamese.dyndns.org>
On Mon, Dec 03, 2007 at 09:37:54PM -0800, Junio C Hamano wrote:
> I wonder if it is better to grep for ' [-A] ' instead, like:
>
> cvsps_supports_A=$(cvsps -h 2>&1 | sed -ne '/\[-A\]/p')
> case "$cvsps_supports_A" in
> '')
> say 'skipping cvsimport tests, lacking cvsps that supports -A option'
> test_done
> exit
> esac
I am not too opposed to that, but I felt that checking the version was a
little bit more future proof. I.e., I have no idea if it is only -A that
we need, but I know that 2.1 works and prior to 2.1 doesn't.
-Jeff
^ permalink raw reply
* Re: Building git-1.5.3.7 on HP-UX 11.00
From: Johannes Schindelin @ 2007-12-04 15:39 UTC (permalink / raw)
To: H.Merijn Brand; +Cc: Andreas Ericsson, git, Sam Vilain
In-Reply-To: <20071204152240.6cb6018e@pc09.procura.nl>
Hi,
On Tue, 4 Dec 2007, H.Merijn Brand wrote:
> + + pwd
> GIT_EXEC_PATH=/pro/3gl/LINUX/git-1.5.3.7/t/..
> + + pwd
> GIT_TEMPLATE_DIR=/pro/3gl/LINUX/git-1.5.3.7/t/../templates/blt
> + GIT_CONFIG=.git/config
> + export PATH GIT_EXEC_PATH GIT_TEMPLATE_DIR GIT_CONFIG
> + + pwd
> + pwd
> GITPERLLIB=/pro/3gl/LINUX/git-1.5.3.7/t/../perl/blib/lib:/pro/3gl/LINUX/git-1.5.3.7/t/../perl/blib/arch/auto/Git
> + export GITPERLLIB
> + test -d ../templates/blt
> + test -x ../test-chmtime
> + test=trash
> + rm -fr trash
> + test_create_repo trash
> + cd trash
> + + expr ./t0001-init.sh : .*/\(t[0-9]*\)-[^/]*$
> this_test=t0001
> + test_expect_success plain
> (
> unset GIT_DIR GIT_WORK_TREE &&
> mkdir plain &&
> cd plain &&
> git init
> ) &&
> check_config plain/.git false unset
>
> * expecting success:
> (
> unset GIT_DIR GIT_WORK_TREE &&
> mkdir plain &&
> cd plain &&
> git init
> ) &&
> check_config plain/.git false unset
>
> * FAIL 1: plain
>
> (
> unset GIT_DIR GIT_WORK_TREE &&
> mkdir plain &&
> cd plain &&
> git init
> ) &&
> check_config plain/.git false unset
That's not good. The relevant part here reads:
-- snip --
+ test_description='git init'
+ . ./test-lib.sh
++ LANG=C
++ LC_ALL=C
++ PAGER=cat
++ TZ=UTC
++ export LANG LC_ALL PAGER TZ
++ EDITOR=:
++ VISUAL=:
++ unset GIT_EDITOR
++ unset AUTHOR_DATE
++ unset AUTHOR_EMAIL
++ unset AUTHOR_NAME
++ unset COMMIT_AUTHOR_EMAIL
++ unset COMMIT_AUTHOR_NAME
++ unset EMAIL
++ unset GIT_ALTERNATE_OBJECT_DIRECTORIES
++ unset GIT_AUTHOR_DATE
++ GIT_AUTHOR_EMAIL=author@example.com
++ GIT_AUTHOR_NAME='A U Thor'
++ unset GIT_COMMITTER_DATE
++ GIT_COMMITTER_EMAIL=committer@example.com
++ GIT_COMMITTER_NAME='C O Mitter'
++ unset GIT_DIFF_OPTS
++ unset GIT_DIR
++ unset GIT_WORK_TREE
++ unset GIT_EXTERNAL_DIFF
++ unset GIT_INDEX_FILE
++ unset GIT_OBJECT_DIRECTORY
++ unset SHA1_FILE_DIRECTORIES
++ unset SHA1_FILE_DIRECTORY
++ GIT_MERGE_VERBOSITY=5
++ export GIT_MERGE_VERBOSITY
++ export GIT_AUTHOR_EMAIL GIT_AUTHOR_NAME
++ export GIT_COMMITTER_EMAIL GIT_COMMITTER_NAME
++ export EDITOR VISUAL
++ unset CDPATH
++ case $(echo $GIT_TRACE |tr "[A-Z]" "[a-z]") in
+++ echo
+++ tr '[A-Z]' '[a-z]'
++ '[' xxterm '!=' xdumb ']'
++ '[' -t 1 ']'
++ test 2 -ne 0
++ case "$1" in
++ immediate=t
++ shift
++ test 1 -ne 0
++ case "$1" in
++ verbose=t
++ shift
++ test 0 -ne 0
++ test -n ''
++ test 'git init' '!=' ''
++ test '' = t
++ exec
++ test t = t
++ exec
++ test_failure=0
++ test_count=0
++ trap 'echo >&5 "FATAL: Unexpected exit with code $?"; exit 1' exit
+++ pwd
++ PATH=/home/gitte/my/git/t/..:/home/gene099/bin:/usr/local/bin:/usr/bin:/usr/X11R6/bin:/bin:/usr/games:/opt/gnome/bin:/opt/kde3/bin:/usr/lib/mit/bin:/usr/lib/mit/sbin:/usr/lib/qt3/bin
+++ pwd
++ GIT_EXEC_PATH=/home/gitte/my/git/t/..
+++ pwd
++ GIT_TEMPLATE_DIR=/home/gitte/my/git/t/../templates/blt
++ GIT_CONFIG=.git/config
++ export PATH GIT_EXEC_PATH GIT_TEMPLATE_DIR GIT_CONFIG
+++ pwd
+++ pwd
++ GITPERLLIB=/home/gitte/my/git/t/../perl/blib/lib:/home/gene099/my/git/t/../perl/blib/arch/auto/Git
++ export GITPERLLIB
++ test -d ../templates/blt
++ test -x ../test-chmtime
++ test=trash
++ rm -fr trash
++ test_create_repo trash
++ test 1 = 1
+++ pwd
++ owd=/home/gitte/my/git/t
++ repo=trash
++ mkdir trash
++ cd trash
++ /home/gitte/my/git/t/../git init --template=/home/gene099/my/git/t/../templates/blt/
++ mv .git/hooks .git/hooks-disabled
++ cd /home/gitte/my/git/t
++ cd trash
+++ expr ./t0001-init.sh : '.*/\(t[0-9]*\)-[^/]*$'
++ this_test=t0001
+ test_expect_success plain '
(
unset GIT_DIR GIT_WORK_TREE &&
mkdir plain &&
cd plain &&
git init
) &&
check_config plain/.git false unset
'
+ test 2 = 2
+ test_skip plain '
(
unset GIT_DIR GIT_WORK_TREE &&
mkdir plain &&
cd plain &&
git init
) &&
check_config plain/.git false unset
'
-- snap --
So I get way more information. Which let's me suspect that your shell
might be the culprit? Can you try with bash?
Ciao,
Dscho
^ permalink raw reply
* Re: [PATCH] Set OLD_ICONV on Cygwin.
From: Pascal Obry @ 2007-12-04 13:39 UTC (permalink / raw)
To: Andreas Ericsson, Pascal Obry; +Cc: Pascal Obry, git, Junio C Hamano
Andreas Ericsson wrote:
> Only one, insofar as I can see; You didn't CC Junio. He probably missed it.
Hum, I don't think this is a requirement. At least nothing is said about
CCing Junio on the Git Web site.
Anyway, now Junio is CCed :)
Pascal.
^ permalink raw reply
* Re: [PATCH] git-stash: Display help message if git-stash is run with wrong sub-commands
From: Wayne Davison @ 2007-12-04 15:28 UTC (permalink / raw)
To: Johannes Schindelin; +Cc: Kevin Leung, Git ML
In-Reply-To: <Pine.LNX.4.64.0712031023480.27959@racer.site>
On Mon, Dec 03, 2007 at 10:25:17AM +0000, Johannes Schindelin wrote:
> But those are not really options, are they? They are commands, which
> exclude each other.
Option syntax is often used to represent exclusive commands, especially
when those commands need to be distinguished from free-form arg words.
The "git checkout" command is another example of this in git, and there
are plenty of non-git examples of such a use of option syntax around.
Such a syntax makes it easier to have a default action while still
taking a free-form arg. I personally think that using option syntax
for its behavior choices would be preferable with git stash.
..wayne..
^ permalink raw reply
* Re: Building git-1.5.3.7 on HP-UX 11.00
From: H.Merijn Brand @ 2007-12-04 15:22 UTC (permalink / raw)
To: Andreas Ericsson; +Cc: Johannes Schindelin, git, Sam Vilain
In-Reply-To: <47556EE2.6040105@op5.se>
On Tue, 04 Dec 2007 16:14:42 +0100, Andreas Ericsson <ae@op5.se> wrote:
> H.Merijn Brand wrote:
> >
> > I also meanwhile forced copied the git binaries to my bin dir
> >
>
> That's no good. "make test" will test binaries residing in ..
> relative to where the tests are executed.
OK, I removed those again :)
I also removed the -ldce in the HP-UX piece, which was there to
support unsetenv, but using NO_UNSETENV seems to be safer
ifeq ($(uname_S),HP-UX)
# HP-UX
BASIC_LDFLAGS += -L/usr/local/ssl/lib -L/usr/local/lib
#EXTLIBS += -ldce
NO_HSTRERROR = YesPlease
NO_ICONV = YesPlease
NO_INET_NTOP = YesPlease
NO_INET_PTON = YesPlease
NO_UNSETENV = YesPlease
endif
causes a clean build
+ + pwd
GIT_EXEC_PATH=/pro/3gl/LINUX/git-1.5.3.7/t/..
+ + pwd
GIT_TEMPLATE_DIR=/pro/3gl/LINUX/git-1.5.3.7/t/../templates/blt
+ GIT_CONFIG=.git/config
+ export PATH GIT_EXEC_PATH GIT_TEMPLATE_DIR GIT_CONFIG
+ + pwd
+ pwd
GITPERLLIB=/pro/3gl/LINUX/git-1.5.3.7/t/../perl/blib/lib:/pro/3gl/LINUX/git-1.5.3.7/t/../perl/blib/arch/auto/Git
+ export GITPERLLIB
+ test -d ../templates/blt
+ test -x ../test-chmtime
+ test=trash
+ rm -fr trash
+ test_create_repo trash
+ cd trash
+ + expr ./t0001-init.sh : .*/\(t[0-9]*\)-[^/]*$
this_test=t0001
+ test_expect_success plain
(
unset GIT_DIR GIT_WORK_TREE &&
mkdir plain &&
cd plain &&
git init
) &&
check_config plain/.git false unset
* expecting success:
(
unset GIT_DIR GIT_WORK_TREE &&
mkdir plain &&
cd plain &&
git init
) &&
check_config plain/.git false unset
* FAIL 1: plain
(
unset GIT_DIR GIT_WORK_TREE &&
mkdir plain &&
cd plain &&
git init
) &&
check_config plain/.git false unset
/pro/3gl/LINUX/git-1.5.3.7/t 130 > ldd ../git
/usr/lib/libc.2 => /usr/lib/libc.2
/usr/lib/libdld.2 => /usr/lib/libdld.2
/usr/lib/libc.2 => /usr/lib/libc.2
/usr/local/ssl/lib/libcrypto.sl => /usr/local/ssl/lib/libcrypto.sl
/usr/local/lib/libz.sl => /usr/local/lib/libz.sl
I will leave for a meeting in 30 minutes, so don't think I don't want
to communicate any further :)
Sam is pretty enthusiastic on IRC, he's to blame!
--
H.Merijn Brand Amsterdam Perl Mongers (http://amsterdam.pm.org/)
using & porting perl 5.6.2, 5.8.x, 5.10.x on HP-UX 10.20, 11.00, 11.11,
& 11.23, SuSE 10.1 & 10.2, AIX 5.2, and Cygwin. http://qa.perl.org
http://mirrors.develooper.com/hpux/ http://www.test-smoke.org
http://www.goldmark.org/jeff/stupid-disclaimers/
^ permalink raw reply
* Re: Building git-1.5.3.7 on HP-UX 11.00
From: Andreas Ericsson @ 2007-12-04 15:14 UTC (permalink / raw)
To: H.Merijn Brand; +Cc: Johannes Schindelin, git, Sam Vilain
In-Reply-To: <20071204150102.7f3ec3e9@pc09.procura.nl>
H.Merijn Brand wrote:
>
> I also meanwhile forced copied the git binaries to my bin dir
>
That's no good. "make test" will test binaries residing in ..
relative to where the tests are executed.
--
Andreas Ericsson andreas.ericsson@op5.se
OP5 AB www.op5.se
Tel: +46 8-230225 Fax: +46 8-230231
^ permalink raw reply
* Re: Building git-1.5.3.7 on HP-UX 11.00
From: H.Merijn Brand @ 2007-12-04 15:11 UTC (permalink / raw)
To: Johannes Schindelin; +Cc: git, Sam Vilain
In-Reply-To: <Pine.LNX.4.64.0712041439590.27959@racer.site>
On Tue, 4 Dec 2007 14:40:47 +0000 (GMT), Johannes Schindelin
<Johannes.Schindelin@gmx.de> wrote:
> Hi,
>
> On Tue, 4 Dec 2007, H.Merijn Brand wrote:
>
> > On Tue, 4 Dec 2007 13:44:02 +0000 (GMT), Johannes Schindelin
> > <Johannes.Schindelin@gmx.de> wrote:
> >
> > > Hi,
> > >
> > > On Tue, 4 Dec 2007, H.Merijn Brand wrote:
> > >
> > > > make test then fails:
> > >
> > > Could you run the failing test manually with -i -v, like so:
> > >
> > > $ cd t/
> > > $ sh t0001*.sh -i -v
> >
> > /pro/3gl/LINUX/git-1.5.3.7 183 > cd t
> > /pro/3gl/LINUX/git-1.5.3.7/t 184 > sh t0001*.sh -i -v
> > * error: cannot run git init -- have you built things yet?
> > Exit 1
> > /pro/3gl/LINUX/git-1.5.3.7/t 185 >
>
> Next step: add the sh option -x:
>
> $ sh -x t0001*.sh -i -v
After I did # make git
and # make test
# cd t
# h -x t0001*.sh -i -v
:
:
+ + pwd
GIT_EXEC_PATH=/pro/3gl/LINUX/git-1.5.3.7/t/..
+ + pwd
GIT_TEMPLATE_DIR=/pro/3gl/LINUX/git-1.5.3.7/t/../templates/blt
+ GIT_CONFIG=.git/config
+ export PATH GIT_EXEC_PATH GIT_TEMPLATE_DIR GIT_CONFIG
+ + pwd
+ pwd
GITPERLLIB=/pro/3gl/LINUX/git-1.5.3.7/t/../perl/blib/lib:/pro/3gl/LINUX/git-1.5.
3.7/t/../perl/blib/arch/auto/Git
+ export GITPERLLIB
+ test -d ../templates/blt
+ test -x ../test-chmtime
+ test=trash
+ rm -fr trash
+ test_create_repo trash
+ cd trash
+ + expr ./t0001-init.sh : .*/\(t[0-9]*\)-[^/]*$
this_test=t0001
+ test_expect_success plain
(
unset GIT_DIR GIT_WORK_TREE &&
mkdir plain &&
cd plain &&
git init
) &&
check_config plain/.git false unset
* expecting success:
(
unset GIT_DIR GIT_WORK_TREE &&
mkdir plain &&
cd plain &&
git init
) &&
check_config plain/.git false unset
* FAIL 1: plain
(
unset GIT_DIR GIT_WORK_TREE &&
mkdir plain &&
cd plain &&
git init
) &&
check_config plain/.git false unset
> to find out what made it fail.
>
> Thanks,
> Dscho
>
>
--
H.Merijn Brand Amsterdam Perl Mongers (http://amsterdam.pm.org/)
using & porting perl 5.6.2, 5.8.x, 5.10.x on HP-UX 10.20, 11.00, 11.11,
& 11.23, SuSE 10.1 & 10.2, AIX 5.2, and Cygwin. http://qa.perl.org
http://mirrors.develooper.com/hpux/ http://www.test-smoke.org
http://www.goldmark.org/jeff/stupid-disclaimers/
^ permalink raw reply
* Re: Building git-1.5.3.7 on HP-UX 11.00
From: H.Merijn Brand @ 2007-12-04 15:01 UTC (permalink / raw)
To: Johannes Schindelin; +Cc: git, Sam Vilain
In-Reply-To: <Pine.LNX.4.64.0712041439590.27959@racer.site>
On Tue, 4 Dec 2007 14:40:47 +0000 (GMT), Johannes Schindelin
<Johannes.Schindelin@gmx.de> wrote:
> Hi,
>
> On Tue, 4 Dec 2007, H.Merijn Brand wrote:
>
> > On Tue, 4 Dec 2007 13:44:02 +0000 (GMT), Johannes Schindelin
> > <Johannes.Schindelin@gmx.de> wrote:
> >
> > > Hi,
> > >
> > > On Tue, 4 Dec 2007, H.Merijn Brand wrote:
> > >
> > > > make test then fails:
> > >
> > > Could you run the failing test manually with -i -v, like so:
> > >
> > > $ cd t/
> > > $ sh t0001*.sh -i -v
> >
> > /pro/3gl/LINUX/git-1.5.3.7 183 > cd t
> > /pro/3gl/LINUX/git-1.5.3.7/t 184 > sh t0001*.sh -i -v
> > * error: cannot run git init -- have you built things yet?
> > Exit 1
> > /pro/3gl/LINUX/git-1.5.3.7/t 185 >
>
> Next step: add the sh option -x:
I also meanwhile forced copied the git binaries to my bin dir
/pro/3gl/LINUX/git-1.5.3.7/t 106 > git --version
git version 1.5.3.7
> $ sh -x t0001*.sh -i -v
/pro/3gl/LINUX/git-1.5.3.7/t 105 > sh -x t0001*.sh -i -v
+ test_description=git init
+ . ./test-lib.sh
+ LANG=C
+ LC_ALL=C
+ PAGER=cat
+ TZ=UTC
+ export LANG LC_ALL PAGER TZ
+ EDITOR=:
+ VISUAL=:
+ unset GIT_EDITOR
+ unset AUTHOR_DATE
+ unset AUTHOR_EMAIL
+ unset AUTHOR_NAME
+ unset COMMIT_AUTHOR_EMAIL
+ unset COMMIT_AUTHOR_NAME
+ unset EMAIL
+ unset GIT_ALTERNATE_OBJECT_DIRECTORIES
+ unset GIT_AUTHOR_DATE
+ GIT_AUTHOR_EMAIL=author@example.com
+ GIT_AUTHOR_NAME=A U Thor
+ unset GIT_COMMITTER_DATE
+ GIT_COMMITTER_EMAIL=committer@example.com
+ GIT_COMMITTER_NAME=C O Mitter
+ unset GIT_DIFF_OPTS
+ unset GIT_DIR
+ unset GIT_WORK_TREE
+ unset GIT_EXTERNAL_DIFF
+ unset GIT_INDEX_FILE
+ unset GIT_OBJECT_DIRECTORY
+ unset SHA1_FILE_DIRECTORIES
+ unset SHA1_FILE_DIRECTORY
+ GIT_MERGE_VERBOSITY=5
+ export GIT_MERGE_VERBOSITY
+ export GIT_AUTHOR_EMAIL GIT_AUTHOR_NAME
+ export GIT_COMMITTER_EMAIL GIT_COMMITTER_NAME
+ export EDITOR VISUAL
+ unset CDPATH
+ tr [A-Z] [a-z]
+ echo
+ test git init !=
+ test 2 -ne 0
+ immediate=t
+ shift
+ test 1 -ne 0
+ verbose=t
+ shift
+ test 0 -ne 0
+ exec
+ 5>& 1
+ test t = t
+ exec
+ 4>& 2 3>& 1
+ test_failure=0
+ test_count=0
+ trap echo >&5 "FATAL: Unexpected exit with code $?"; exit 1 exit
+ + pwd
PATH=/pro/3gl/LINUX/git-1.5.3.7/t/..:.:/u/usr/merijn/bin/private:/u/usr/merijn/bin:/pro/local/bin:/pro/bin:/usr/hosts:/usr/bin:/opt/ansic/bin:/usr/ccs/bin:/usr/contrib/bin:/opt/nettladm/bin:/opt/fc/bin:/opt/fcms/bin:/opt/upgrade/bin:/opt/pd/bin:/usr/bin/X11:/usr/contrib/bin/X11:/opt/resmon/bin:/usr/sbin/diag/contrib:/opt/pred/bin:/opt/hparray/bin:/opt/perf/bin:/opt/langtools/bin:/opt/imake/bin:/opt/ignite/bin:/opt/sec_mgmt/spc/bin:/usr/local/bin:/usr/local/sbin:/opt/java1.5/jre/bin:/opt/graphics/common/bin:/pro/local/libexec:/pro/local/sbin:/pro/local/samba/bin:/pro/local/samba/sbin:/opt/hpnpl/bin:/pro/tu/bin:/usr/sbin:/sbin:/usr/local/pa20_64/bin:/pro/3gl/CPAN/bin
+ + pwd
GIT_EXEC_PATH=/pro/3gl/LINUX/git-1.5.3.7/t/..
+ + pwd
GIT_TEMPLATE_DIR=/pro/3gl/LINUX/git-1.5.3.7/t/../templates/blt
+ GIT_CONFIG=.git/config
+ export PATH GIT_EXEC_PATH GIT_TEMPLATE_DIR GIT_CONFIG
+ + pwd
+ pwd
GITPERLLIB=/pro/3gl/LINUX/git-1.5.3.7/t/../perl/blib/lib:/pro/3gl/LINUX/git-1.5.3.7/t/../perl/blib/arch/auto/Git
+ export GITPERLLIB
+ test -d ../templates/blt
+ test -x ../test-chmtime
+ test=trash
+ rm -fr trash
+ test_create_repo trash
* error: cannot run git init -- have you built things yet?
Exit 1
pro/3gl/LINUX/git-1.5.3.7/t 108 > ll /pro/local/bin/git*
127035 -rwxrwxrwx 1 merijn softwr 1081204 Dec 4 15:19 /pro/local/bin/git
86787 -rwxrwxrwx 1 merijn softwr 16467 Dec 4 15:22 /pro/local/bin/git-add--interactive
86627 -rwxrwxrwx 1 merijn softwr 11285 Dec 4 15:22 /pro/local/bin/git-am
86909 -rwxrwxrwx 1 merijn softwr 36968 Dec 4 15:22 /pro/local/bin/git-archimport
86420 -rwxrwxrwx 1 merijn softwr 8508 Dec 4 15:22 /pro/local/bin/git-bisect
86423 -rwxrwxrwx 1 merijn softwr 6905 Dec 4 15:22 /pro/local/bin/git-checkout
86424 -rwxrwxrwx 1 merijn softwr 1972 Dec 4 15:22 /pro/local/bin/git-clean
86427 -rwxrwxrwx 1 merijn softwr 11560 Dec 4 15:22 /pro/local/bin/git-clone
86428 -rwxrwxrwx 1 merijn softwr 14693 Dec 4 15:22 /pro/local/bin/git-commit
127036 -rwxrwxrwx 1 merijn softwr 327540 Dec 4 15:19 /pro/local/bin/git-convert-objects
87086 -rwxrwxrwx 1 merijn softwr 9394 Dec 4 15:22 /pro/local/bin/git-cvsexportcommit
86968 -rwxrwxrwx 1 merijn softwr 26590 Dec 4 15:22 /pro/local/bin/git-cvsimport
86997 -rwxrwxrwx 1 merijn softwr 101558 Dec 4 15:22 /pro/local/bin/git-cvsserver
86356 -rwxrwxrwx 1 merijn softwr 343924 Dec 4 15:22 /pro/local/bin/git-daemon
86355 -rwxrwxrwx 1 merijn softwr 420048 Dec 4 15:22 /pro/local/bin/git-fast-import
86440 -rwxrwxrwx 1 merijn softwr 9083 Dec 4 15:22 /pro/local/bin/git-fetch
87107 -rwxrwxrwx 1 merijn softwr 360308 Dec 4 15:22 /pro/local/bin/git-fetch-pack
86724 -rwxrwxrwx 1 merijn softwr 10240 Dec 4 15:22 /pro/local/bin/git-filter-branch
86351 -rwxrwxrwx 1 merijn softwr 323444 Dec 4 15:22 /pro/local/bin/git-hash-object
86390 -rwxrwxrwx 1 merijn softwr 343924 Dec 4 15:22 /pro/local/bin/git-imap-send
87114 -rwxrwxrwx 1 merijn softwr 348020 Dec 4 15:22 /pro/local/bin/git-index-pack
87100 -rwxrwxrwx 1 merijn softwr 177519 Dec 4 15:22 /pro/local/bin/git-instaweb
86342 -rwxrwxrwx 1 merijn softwr 339828 Dec 4 15:22 /pro/local/bin/git-local-fetch
86680 -rwxrwxrwx 1 merijn softwr 473 Dec 4 15:22 /pro/local/bin/git-lost-found
86444 -rwxrwxrwx 1 merijn softwr 2544 Dec 4 15:22 /pro/local/bin/git-ls-remote
86633 -rwxrwxrwx 1 merijn softwr 11464 Dec 4 15:22 /pro/local/bin/git-merge
86359 -rwxrwxrwx 1 merijn softwr 323444 Dec 4 15:22 /pro/local/bin/git-merge-index
86636 -rwxrwxrwx 1 merijn softwr 2415 Dec 4 15:22 /pro/local/bin/git-merge-octopus
86445 -rwxrwxrwx 1 merijn softwr 3364 Dec 4 15:22 /pro/local/bin/git-merge-one-file
86656 -rwxrwxrwx 1 merijn softwr 338 Dec 4 15:22 /pro/local/bin/git-merge-ours
86391 -rwxrwxrwx 1 merijn softwr 491380 Dec 4 15:22 /pro/local/bin/git-merge-recursive
86643 -rwxrwxrwx 1 merijn softwr 954 Dec 4 15:22 /pro/local/bin/git-merge-resolve
86634 -rwxrwxrwx 1 merijn softwr 1456 Dec 4 15:22 /pro/local/bin/git-merge-stupid
86399 -rwxrwxrwx 1 merijn softwr 491380 Dec 4 15:21 /pro/local/bin/git-merge-subtree
86389 -rwxrwxrwx 1 merijn softwr 348020 Dec 4 15:22 /pro/local/bin/git-merge-tree
86446 -rwxrwxrwx 1 merijn softwr 8649 Dec 4 15:22 /pro/local/bin/git-mergetool
86361 -rwxrwxrwx 1 merijn softwr 323444 Dec 4 15:22 /pro/local/bin/git-mktag
86363 -rwxrwxrwx 1 merijn softwr 323444 Dec 4 15:22 /pro/local/bin/git-mktree
86387 -rwxrwxrwx 1 merijn softwr 331636 Dec 4 15:22 /pro/local/bin/git-pack-redundant
86447 -rwxrwxrwx 1 merijn softwr 5892 Dec 4 15:22 /pro/local/bin/git-parse-remote
86365 -rwxrwxrwx 1 merijn softwr 319348 Dec 4 15:22 /pro/local/bin/git-patch-id
86367 -rwxrwxrwx 1 merijn softwr 348020 Dec 4 15:22 /pro/local/bin/git-peek-remote
86450 -rwxrwxrwx 1 merijn softwr 3868 Dec 4 15:22 /pro/local/bin/git-pull
86692 -rwxrwxrwx 1 merijn softwr 3203 Dec 4 15:22 /pro/local/bin/git-quiltimport
86454 -rwxrwxrwx 1 merijn softwr 8737 Dec 4 15:22 /pro/local/bin/git-rebase
86456 -rwxrwxrwx 1 merijn softwr 11642 Dec 4 15:22 /pro/local/bin/git-rebase--interactive
86369 -rwxrwxrwx 1 merijn softwr 335732 Dec 4 15:22 /pro/local/bin/git-receive-pack
86988 -rwxrwxrwx 1 merijn softwr 4189 Dec 4 15:22 /pro/local/bin/git-relink
87012 -rwxrwxrwx 1 merijn softwr 9524 Dec 4 15:22 /pro/local/bin/git-remote
86457 -rwxrwxrwx 1 merijn softwr 2886 Dec 4 15:22 /pro/local/bin/git-repack
86458 -rwxrwxrwx 1 merijn softwr 1364 Dec 4 15:22 /pro/local/bin/git-request-pull
86591 -rwxrwxrwx 1 merijn softwr 2304 Dec 4 15:22 /pro/local/bin/git-reset
87087 -rwxrwxrwx 1 merijn softwr 20052 Dec 4 15:22 /pro/local/bin/git-send-email
86371 -rwxrwxrwx 1 merijn softwr 356212 Dec 4 15:22 /pro/local/bin/git-send-pack
86616 -rwxrwxrwx 1 merijn softwr 2960 Dec 4 15:22 /pro/local/bin/git-sh-setup
86372 -rwxrwxrwx 1 merijn softwr 319348 Dec 4 15:22 /pro/local/bin/git-shell
86375 -rwxrwxrwx 1 merijn softwr 323444 Dec 4 15:22 /pro/local/bin/git-show-index
86376 -rwxrwxrwx 1 merijn softwr 335732 Dec 4 15:22 /pro/local/bin/git-ssh-fetch
86392 -rwxrwxrwx 1 merijn softwr 335732 Dec 4 15:22 /pro/local/bin/git-ssh-pull
86414 -rwxrwxrwx 1 merijn softwr 327540 Dec 4 15:22 /pro/local/bin/git-ssh-push
86379 -rwxrwxrwx 1 merijn softwr 327540 Dec 4 15:22 /pro/local/bin/git-ssh-upload
86749 -rwxrwxrwx 1 merijn softwr 4613 Dec 4 15:22 /pro/local/bin/git-stash
87098 -rwxrwxrwx 1 merijn softwr 14693 Dec 4 15:22 /pro/local/bin/git-status
86697 -rwxrwxrwx 1 merijn softwr 6388 Dec 4 15:22 /pro/local/bin/git-submodule
87097 -rwxrwxrwx 1 merijn softwr 119623 Dec 4 15:22 /pro/local/bin/git-svn
87085 -rwxrwxrwx 1 merijn softwr 24869 Dec 4 15:22 /pro/local/bin/git-svnimport
86381 -rwxrwxrwx 1 merijn softwr 319348 Dec 4 15:22 /pro/local/bin/git-unpack-file
86382 -rwxrwxrwx 1 merijn softwr 327540 Dec 4 15:22 /pro/local/bin/git-update-server-info
86386 -rwxrwxrwx 1 merijn softwr 487284 Dec 4 15:22 /pro/local/bin/git-upload-pack
86388 -rwxrwxrwx 1 merijn softwr 319348 Dec 4 15:22 /pro/local/bin/git-var
> to find out what made it
--
H.Merijn Brand Amsterdam Perl Mongers (http://amsterdam.pm.org/)
using & porting perl 5.6.2, 5.8.x, 5.10.x on HP-UX 10.20, 11.00, 11.11,
& 11.23, SuSE 10.1 & 10.2, AIX 5.2, and Cygwin. http://qa.perl.org
http://mirrors.develooper.com/hpux/ http://www.test-smoke.org
http://www.goldmark.org/jeff/stupid-disclaimers/
^ permalink raw reply
* Re: Building git-1.5.3.7 on HP-UX 11.00
From: Johannes Schindelin @ 2007-12-04 14:40 UTC (permalink / raw)
To: H.Merijn Brand; +Cc: git, Sam Vilain
In-Reply-To: <20071204140326.14d9e7a0@pc09.procura.nl>
Hi,
On Tue, 4 Dec 2007, H.Merijn Brand wrote:
> On Tue, 4 Dec 2007 13:44:02 +0000 (GMT), Johannes Schindelin
> <Johannes.Schindelin@gmx.de> wrote:
>
> > Hi,
> >
> > On Tue, 4 Dec 2007, H.Merijn Brand wrote:
> >
> > > make test then fails:
> >
> > Could you run the failing test manually with -i -v, like so:
> >
> > $ cd t/
> > $ sh t0001*.sh -i -v
>
> /pro/3gl/LINUX/git-1.5.3.7 183 > cd t
> /pro/3gl/LINUX/git-1.5.3.7/t 184 > sh t0001*.sh -i -v
> * error: cannot run git init -- have you built things yet?
> Exit 1
> /pro/3gl/LINUX/git-1.5.3.7/t 185 >
Next step: add the sh option -x:
$ sh -x t0001*.sh -i -v
to find out what made it fail.
Thanks,
Dscho
^ permalink raw reply
* Re: msysGit on FAT32
From: Johannes Schindelin @ 2007-12-04 14:37 UTC (permalink / raw)
To: Johannes Sixt; +Cc: Jakub Narebski, git
In-Reply-To: <47555A9E.3090902@viscovery.net>
Hi,
On Tue, 4 Dec 2007, Johannes Sixt wrote:
> Johannes Schindelin schrieb:
> > On Tue, 4 Dec 2007, Jakub Narebski wrote:
> >
> > > Johannes Sixt <j.sixt@viscovery.net> writes:
> > >
> > > > BTW, we do use hardlinks on Windows; even the MsysGit installer creates
> > > > them (as long as the filesystem is NTFS). So, the fallout you are
> > > > expecting/hoping for will not be in the first round of MinGW port
> > > > patches. ;)
> > > Would it be possible to add option to an installer to _not_ install
> > > git-cmd form for builtins when installing on FAT28^W FAT32?
> >
> > It is the InnoSetup based installer that does that. MSys has no way (yet)
> > to create hard links (at least that's the state of my knowledge).
>
> I don't know about MSys, the runtime, but MSys's 'ln' and 'cp -l' both create
> hardlinks on NTFS. And for this reason, 'git clone -l' does, too.
Does it? *goestocheck* Indeed it works! (The hardest part was to verify
it; seems like you have to use MSys' stat.exe, as regular Windows seems to
have _no_ tool to find that out.)
Thanks,
Dscho
^ permalink raw reply
* Re: Building git-1.5.3.7 on HP-UX 11.00
From: H.Merijn Brand @ 2007-12-04 14:03 UTC (permalink / raw)
To: Johannes Schindelin; +Cc: git, Sam Vilain
In-Reply-To: <Pine.LNX.4.64.0712041343040.27959@racer.site>
On Tue, 4 Dec 2007 13:44:02 +0000 (GMT), Johannes Schindelin
<Johannes.Schindelin@gmx.de> wrote:
> Hi,
>
> On Tue, 4 Dec 2007, H.Merijn Brand wrote:
>
> > make test then fails:
>
> Could you run the failing test manually with -i -v, like so:
>
> $ cd t/
> $ sh t0001*.sh -i -v
/pro/3gl/LINUX/git-1.5.3.7 183 > cd t
/pro/3gl/LINUX/git-1.5.3.7/t 184 > sh t0001*.sh -i -v
* error: cannot run git init -- have you built things yet?
Exit 1
/pro/3gl/LINUX/git-1.5.3.7/t 185 >
--
H.Merijn Brand Amsterdam Perl Mongers (http://amsterdam.pm.org/)
using & porting perl 5.6.2, 5.8.x, 5.10.x on HP-UX 10.20, 11.00, 11.11,
& 11.23, SuSE 10.1 & 10.2, AIX 5.2, and Cygwin. http://qa.perl.org
http://mirrors.develooper.com/hpux/ http://www.test-smoke.org
http://www.goldmark.org/jeff/stupid-disclaimers/
^ permalink raw reply
* Re: msysGit on FAT32
From: Johannes Sixt @ 2007-12-04 13:48 UTC (permalink / raw)
To: Johannes Schindelin; +Cc: Jakub Narebski, git
In-Reply-To: <Pine.LNX.4.64.0712041329230.27959@racer.site>
Johannes Schindelin schrieb:
> On Tue, 4 Dec 2007, Jakub Narebski wrote:
>
>> Johannes Sixt <j.sixt@viscovery.net> writes:
>>
>>> BTW, we do use hardlinks on Windows; even the MsysGit installer
>>> creates them (as long as the filesystem is NTFS). So, the fallout you
>>> are expecting/hoping for will not be in the first round of MinGW port
>>> patches. ;)
>> Would it be possible to add option to an installer to _not_ install
>> git-cmd form for builtins when installing on FAT28^W FAT32?
>
> It is the InnoSetup based installer that does that. MSys has no way (yet)
> to create hard links (at least that's the state of my knowledge).
I don't know about MSys, the runtime, but MSys's 'ln' and 'cp -l' both
create hardlinks on NTFS. And for this reason, 'git clone -l' does, too.
-- Hannes
^ permalink raw reply
* Re: Building git-1.5.3.7 on HP-UX 11.00
From: Johannes Schindelin @ 2007-12-04 13:44 UTC (permalink / raw)
To: H.Merijn Brand; +Cc: git, Sam Vilain
In-Reply-To: <20071204130922.731c407a@pc09.procura.nl>
Hi,
On Tue, 4 Dec 2007, H.Merijn Brand wrote:
> make test then fails:
Could you run the failing test manually with -i -v, like so:
$ cd t/
$ sh t0001*.sh -i -v
Thanks,
Dscho
^ permalink raw reply
* Re: [PATCH] Set OLD_ICONV on Cygwin.
From: Andreas Ericsson @ 2007-12-04 13:43 UTC (permalink / raw)
To: Pascal Obry; +Cc: Pascal Obry, Pascal Obry, git, Junio C Hamano
In-Reply-To: <21977191.137171196775591804.JavaMail.www@wwinf1621>
Pascal Obry wrote:
> Andreas Ericsson wrote:
>> Only one, insofar as I can see; You didn't CC Junio. He probably missed it.
>
> Hum, I don't think this is a requirement. At least nothing is said about
> CCing Junio on the Git Web site.
>
It's not a requirement, but he won't act on things he doesn't see, and CC'ing
him directly is the recommended way of getting his attention. Most people do
so for patches that aren't directly related to a sub-part of git primarily
maintained by someone else (Shawn O. Pearce for git-gui, Eric Wong for git-svn,
etc., etc.)
> Anyway, now Junio is CCed :)
>
Nice. If my suspicions are correct and he missed your patch the first time
around, you should probably resend it though.
--
Andreas Ericsson andreas.ericsson@op5.se
OP5 AB www.op5.se
Tel: +46 8-230225 Fax: +46 8-230231
^ permalink raw reply
* Re: msysGit on FAT32 (was: What's cooking in git.git (topics))
From: Johannes Schindelin @ 2007-12-04 13:30 UTC (permalink / raw)
To: Jakub Narebski; +Cc: Johannes Sixt, git
In-Reply-To: <m3hciyvklt.fsf_-_@roke.D-201>
Hi,
On Tue, 4 Dec 2007, Jakub Narebski wrote:
> Johannes Sixt <j.sixt@viscovery.net> writes:
>
> > BTW, we do use hardlinks on Windows; even the MsysGit installer
> > creates them (as long as the filesystem is NTFS). So, the fallout you
> > are expecting/hoping for will not be in the first round of MinGW port
> > patches. ;)
>
> Would it be possible to add option to an installer to _not_ install
> git-cmd form for builtins when installing on FAT28^W FAT32?
It is the InnoSetup based installer that does that. MSys has no way (yet)
to create hard links (at least that's the state of my knowledge).
Ciao,
Dscho
^ permalink raw reply
* Building git-1.5.3.7 on HP-UX 11.00
From: H.Merijn Brand @ 2007-12-04 13:09 UTC (permalink / raw)
To: git; +Cc: Sam Vilain
1. It won't compile at all with HP C-ANSI-C, so I have to use gcc-3.4.6
I added this to Makefile to get it compiled
ifeq ($(uname_S),HP-UX)
# HP-UX
BASIC_LDFLAGS += -L/usr/local/ssl/lib -L/usr/local/lib
EXTLIBS += -ldce
NO_HSTRERROR = YesPlease
NO_ICONV = YesPlease
NO_INET_NTOP = YesPlease
NO_INET_PTON = YesPlease
endif
make test then fails:
/pro/3gl/LINUX/git-1.5.3.7 178 > make test
LINK git-convert-objects
LINK git
BUILTIN git-format-patch
BUILTIN git-show
BUILTIN git-whatchanged
BUILTIN git-cherry
BUILTIN git-get-tar-commit-id
BUILTIN git-init
BUILTIN git-repo-config
BUILTIN git-fsck-objects
BUILTIN git-cherry-pick
BUILTIN git-add
BUILTIN git-annotate
BUILTIN git-apply
BUILTIN git-archive
BUILTIN git-blame
BUILTIN git-branch
BUILTIN git-bundle
BUILTIN git-cat-file
BUILTIN git-check-attr
BUILTIN git-checkout-index
BUILTIN git-check-ref-format
BUILTIN git-commit-tree
BUILTIN git-count-objects
BUILTIN git-describe
BUILTIN git-diff
BUILTIN git-diff-files
BUILTIN git-diff-index
BUILTIN git-diff-tree
BUILTIN git-fetch--tool
BUILTIN git-fmt-merge-msg
BUILTIN git-for-each-ref
BUILTIN git-fsck
BUILTIN git-gc
BUILTIN git-grep
BUILTIN git-init-db
BUILTIN git-log
BUILTIN git-ls-files
BUILTIN git-ls-tree
BUILTIN git-mailinfo
BUILTIN git-mailsplit
BUILTIN git-merge-base
BUILTIN git-merge-file
BUILTIN git-mv
BUILTIN git-name-rev
BUILTIN git-pack-objects
BUILTIN git-prune
BUILTIN git-prune-packed
BUILTIN git-push
BUILTIN git-read-tree
BUILTIN git-reflog
BUILTIN git-config
BUILTIN git-rerere
BUILTIN git-rev-list
BUILTIN git-rev-parse
BUILTIN git-revert
BUILTIN git-rm
BUILTIN git-runstatus
BUILTIN git-shortlog
BUILTIN git-show-branch
BUILTIN git-stripspace
BUILTIN git-symbolic-ref
BUILTIN git-tag
BUILTIN git-tar-tree
BUILTIN git-unpack-objects
BUILTIN git-update-index
BUILTIN git-update-ref
BUILTIN git-upload-archive
BUILTIN git-verify-pack
BUILTIN git-verify-tag
BUILTIN git-write-tree
BUILTIN git-show-ref
BUILTIN git-pack-refs
SUBDIR git-gui
INDEX lib/
SUBDIR perl
SUBDIR templates
make -C t/ all
make[1]: Entering directory `/pro/3gl/LINUX/git-1.5.3.7/t'
*** t0000-basic.sh ***
* ok 1: .git/objects should be empty after git init in an empty repo.
* ok 2: .git/objects should have 3 subdirectories.
* ok 3: git update-index without --add should fail adding.
* ok 4: git update-index with --add should succeed.
* ok 5: writing tree out with git write-tree
* ok 6: validate object ID of a known tree.
* ok 7: git update-index without --remove should fail removing.
* ok 8: git update-index with --remove should be able to remove.
* ok 9: git write-tree should be able to write an empty tree.
* ok 10: validate object ID of a known tree.
* ok 11: adding various types of objects with git update-index --add.
* ok 12: showing stage with git ls-files --stage
* ok 13: validate git ls-files output for a known tree.
* ok 14: writing tree out with git write-tree.
* ok 15: validate object ID for a known tree.
* ok 16: showing tree with git ls-tree
* ok 17: git ls-tree output for a known tree.
* ok 18: showing tree with git ls-tree -r
* ok 19: git ls-tree -r output for a known tree.
* ok 20: showing tree with git ls-tree -r -t
* ok 21: git ls-tree -r output for a known tree.
* ok 22: writing partial tree out with git write-tree --prefix.
* ok 23: validate object ID for a known tree.
* ok 24: writing partial tree out with git write-tree --prefix.
* ok 25: validate object ID for a known tree.
* ok 26: put invalid objects into the index.
* ok 27: writing this tree without --missing-ok.
* ok 28: writing this tree with --missing-ok.
* ok 29: git read-tree followed by write-tree should be idempotent.
* ok 30: validate git diff-files output for a know cache/work tree state.
* ok 31: git update-index --refresh should succeed.
* ok 32: no diff after checkout and git update-index --refresh.
* ok 33: git commit-tree records the correct tree in a commit.
* ok 34: git commit-tree records the correct parent in a commit.
* ok 35: git commit-tree omits duplicated parent in a commit.
* ok 36: update-index D/F conflict
* ok 37: absolute path works as expected
* passed all 37 test(s)
*** t0001-init.sh ***
* FAIL 1: plain
(
unset GIT_DIR GIT_WORK_TREE &&
mkdir plain &&
cd plain &&
git init
) &&
check_config plain/.git false unset
* ok 2: plain with GIT_WORK_TREE
* FAIL 3: plain bare
(
unset GIT_DIR GIT_WORK_TREE GIT_CONFIG &&
mkdir plain-bare-1 &&
cd plain-bare-1 &&
git --bare init
) &&
check_config plain-bare-1 true unset
* ok 4: plain bare with GIT_WORK_TREE
* ok 5: GIT_DIR bare
* ok 6: GIT_DIR non-bare
* ok 7: GIT_DIR & GIT_WORK_TREE (1)
* ok 8: GIT_DIR & GIT_WORK_TREE (2)
* failed 2 among 8 test(s)
make[1]: *** [t0001-init.sh] Error 1
make[1]: Leaving directory `/pro/3gl/LINUX/git-1.5.3.7/t'
make: *** [test] Error 2
Exit 2
and make install probably expects a broken^Wdifferent install than HP-UX has:
/pro/3gl/LINUX/git-1.5.3.7 181 > make install
SUBDIR git-gui
INDEX lib/
SUBDIR perl
SUBDIR templates
install -d -m755 '/pro/local/bin'
rm: /pro/local/bin/ directory
Usage: mv [-f] [-i] [-e warn|force|ignore] f1 f2
mv [-f] [-i] [-e warn|force|ignore] f1 ... fn d1
mv [-f] [-i] [-e warn|force|ignore] d1 d2
install -d -m755 '/pro/local/bin'
rm: /pro/local/bin/ directory
Usage: mv [-f] [-i] [-e warn|force|ignore] f1 f2
mv [-f] [-i] [-e warn|force|ignore] f1 ... fn d1
mv [-f] [-i] [-e warn|force|ignore] d1 d2
install git-convert-objects git-fetch-pack git-hash-object git-index-pack git-local-fetch git-fast-import git-daemon git-merge-index git-mktag git-mktree git-patch-id git-peek-remote git-receive-pack git-send-pack git-shell git-show-index git-ssh-fetch git-ssh-upload git-unpack-file git-update-server-info git-upload-pack git-pack-redundant git-var git-merge-tree git-imap-send git-merge-recursive git-ssh-pull git-ssh-push git-bisect git-checkout git-clean git-clone git-commit git-fetch git-ls-remote git-merge-one-file git-mergetool git-parse-remote git-pull git-rebase git-rebase--interactive git-repack git-request-pull git-reset git-sh-setup git-am git-merge git-merge-stupid git-merge-octopus git-merge-resolve git-merge-ours git-lost-found git-quiltimport git-submodule git-filter-branch gi
t-stash git-add--interactive git-archimport git-cvsimport git-relink git-cvsserver git-remote git-svnimport git-cvsexportcommit git-send-email git-svn git-status git-instaweb git-merge-subt!
ree '/pro/local/bin'
install git '/pro/local/bin'
make -C templates DESTDIR='' install
make[1]: Entering directory `/pro/3gl/LINUX/git-1.5.3.7/templates'
install -d -m755 '/pro/local/share/git-core/templates/'
Usage: mv [-f] [-i] [-e warn|force|ignore] f1 f2
mv [-f] [-i] [-e warn|force|ignore] f1 ... fn d1
mv [-f] [-i] [-e warn|force|ignore] d1 d2
(cd blt && tar cf - .) | \
(cd '/pro/local/share/git-core/templates/' && tar xf -)
/bin/sh: /pro/local/share/git-core/templates/: not found.
make[1]: *** [install] Error 1
make[1]: Leaving directory `/pro/3gl/LINUX/git-1.5.3.7/templates'
make: *** [install] Error 2
Exit 2
I have two:
14241 100555 -r-x 1 bin 1888 12 Jun 2002 10:58 /opt/imake/bin/install
634 100555 -r-x 1 bin 5147 7 Nov 1997 09:00 /usr/sbin/install
--
H.Merijn Brand Amsterdam Perl Mongers (http://amsterdam.pm.org/)
using & porting perl 5.6.2, 5.8.x, 5.10.x on HP-UX 10.20, 11.00, 11.11,
& 11.23, SuSE 10.1 & 10.2, AIX 5.2, and Cygwin. http://qa.perl.org
http://mirrors.develooper.com/hpux/ http://www.test-smoke.org
http://www.goldmark.org/jeff/stupid-disclaimers/
^ permalink raw reply
* Re: [PATCH] Include diff options in the git-log manpage
From: Miklos Vajna @ 2007-12-04 12:28 UTC (permalink / raw)
To: Junio C Hamano; +Cc: git
In-Reply-To: <1193929060-6183-2-git-send-email-vmiklos@frugalware.org>
[-- Attachment #1: Type: text/plain, Size: 485 bytes --]
On Thu, Nov 01, 2007 at 03:57:40PM +0100, Miklos Vajna <vmiklos@frugalware.org> wrote:
> Recently I wanted to see what git log -M does but actually I was not able to
> find it in the manpage, finally figured out that all the diff options are
> missing from here.
>
> Removing -p as it's already in diff-options.txt.
could you please have a look at this patch? this also fixes the "-C is
missing from man git-log" issue which was reported on IRC today.
thanks,
- VMiklos
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
^ permalink raw reply
* Re: git-add--interactive works only in top level
From: Jakub Narebski @ 2007-12-04 12:21 UTC (permalink / raw)
To: Wincent Colaiuta; +Cc: Johannes Schindelin, Junio C Hamano, Reid Barton, git
In-Reply-To: <404A9328-65CF-479E-A109-0C8B09CA43D5@wincent.com>
Wincent Colaiuta <win@wincent.com> writes:
> El 4/12/2007, a las 12:48, Johannes Schindelin escribió:
>
> > You know, without patches you will not convince me ;-)
>
> A number of patches have already been submitted (by Nguy…n Tha
> Ngc Duy, I believe); you know, the "Move all dashed form git
> commands to libexecdir" thread and its precursors. I was just arguing
> in support of the rationale behind them.
I think creating separate libexecdir, and moving there _helpers_ first
(i.e. command which are neither plumbing, nor porcelain, but are
meant to be called _only_ by other commands) would be a good idea,
perhaps even pre 1.5.4.
By the way, if (when) dashed form of commands would get moved to
libexecdir, the INSTALL fragment below talking about removin wrapper
script would have to be changed. But does anyone use GNU Interactive
Tools anymore (IIRC the package name was changed to gitfm or sth.)
<quote src="INSTALL">
- git normally installs a helper script wrapper called "git", which
conflicts with a similarly named "GNU interactive tools" program.
Tough. Either don't use the wrapper script, or delete the old GNU
interactive tools. None of the core git stuff needs the wrapper,
it's just a convenient shorthand and while it is documented in some
places, you can always replace "git commit" with "git-commit"
instead.
But let's face it, most of us don't have GNU interactive tools, and
even if we had it, we wouldn't know what it does. I don't think it
has been actively developed since 1997, and people have moved over to
graphical file managers.
</quote>
--
Jakub Narebski
^ permalink raw reply
* Re: git-add--interactive works only in top level
From: Wincent Colaiuta @ 2007-12-04 11:56 UTC (permalink / raw)
To: Johannes Schindelin; +Cc: Junio C Hamano, Reid Barton, git
In-Reply-To: <Pine.LNX.4.64.0712041148310.27959@racer.site>
El 4/12/2007, a las 12:48, Johannes Schindelin escribió:
> You know, without patches you will not convince me ;-)
A number of patches have already been submitted (by Nguyễn Thái
Ngọc Duy, I believe); you know, the "Move all dashed form git
commands to libexecdir" thread and its precursors. I was just arguing
in support of the rationale behind them.
Cheers,
Wincent
^ permalink raw reply
* Re: [PATCH] Make Git accept absolute path names for files within the work tree
From: Johannes Schindelin @ 2007-12-04 11:50 UTC (permalink / raw)
To: Robin Rosenberg
Cc: Jeff King, Junio C Hamano, Anatol Pomozov, git, Linus Torvalds
In-Reply-To: <200712040742.24728.robin.rosenberg.lists@dewire.com>
Hi,
On Tue, 4 Dec 2007, Robin Rosenberg wrote:
> tisdag 04 december 2007 skrev Johannes Schindelin:
>
> > On Mon, 3 Dec 2007, Jeff King wrote:
> >
> > > On Mon, Dec 03, 2007 at 09:53:30PM +0100, Robin Rosenberg wrote:
> > >
> > > > code did not pass). Like Linus, this code does not resolve
> > > > symlinks, but I forgot to state that it is by design. It solves my
> > > > problem and
> > >
> > > By design meaning "I didn't feel like implemening it because I do
> > > not personally care" or "I have some reason not to resolve
> > > symlinks"?
> >
> > IMHO those symlinks would be a nice thing in some corner cases, but
> > penalise the common case. So I tend to believe the latter. (See also
> > Linus' message why he talks about his preference for the die() code
> > path.)
>
> Actually the forme.... I don't mind it being fixed if it doesn't cost
> too much.
I do remember the hassles I went through with get_relative_cwd() until I
broke down and used chdir() two times (ugly). So the latter reason is
good enough that you do not even have to admit to the former reason ;-)
Ciao,
Dscho
^ permalink raw reply
* Re: git-add--interactive works only in top level
From: Johannes Schindelin @ 2007-12-04 11:48 UTC (permalink / raw)
To: Wincent Colaiuta; +Cc: Junio C Hamano, Reid Barton, git
In-Reply-To: <9AADB5DF-15FA-4A5F-BF4B-509135E486B6@wincent.com>
Hi,
On Tue, 4 Dec 2007, Wincent Colaiuta wrote:
> El 4/12/2007, a las 7:22, Junio C Hamano escribi?:
>
> > Reid Barton <rwbarton@MIT.EDU> writes:
> >
> > > I understand that programs such as git-add--interactive will be
> > > moved out of the executable path not too long from now, which will
> > > also ameliorate the situation.
> >
> > Honestly, there is nothing to ameliorate. We do not even document
> > git-add--interactive on purpose.
> >
> > Once I saw somebody who somehow got a root account on a shared UNIX
> > box and tryed running everything he found under /sbin one after
> > another without understanding what he was doing. Needless to say, the
> > box did not last too long. Somehow that "tab completion" comment
> > reminds of him.
>
> Here he have two options: blame the user for his/her stupidity, or look
> at this a UI problem and try to make the UI "idiot proof".
>
> In this particular case I see no impediment to favouring the second
> option, because we're not talking about making changes that would make
> Git less powerful or useful for "non-idiots", "power users" or "real
> men" (whatever you want to call them). In other words, we are not
> talking about "dumbing down" Git for the sake of the ignorant. This is
> an opportunity to polish the UI in the same way that we polish the
> internal pack format.
You know, without patches you will not convince me ;-)
Ciao,
Dscho
^ permalink raw reply
* Re: If you would write git from scratch now, what would you change?
From: Andy Parkins @ 2007-12-04 11:00 UTC (permalink / raw)
To: git
In-Reply-To: <Pine.LNX.4.64.0711271747210.27959@racer.site>
Johannes Schindelin wrote:
> Tcl/Tk was easier to install on a lot more platforms in my life than Qt.
I wasn't really thinking of the install; that's a packaging problem. I was
speaking of the toolkit itself. I know what you mean, but I wasn't even
thinking of cross-platform in a "number of places it can run" sense. What
I meant (although my point is irrelevant and way off the original question)
was the facilities available in the toolkit with a cross-platform
interface.
Qt puts a common face on threading, process control, networking, file
systems, internationalisation, rendering, openGL, and of course the GUI
itself. Tcl/Tk (to take the most wicked example) gives you applications
that are much harder to make run on Windows than on UNIX.
Anyway, I don't want to sound like a strange Qt fan boy; the above is simply
my justification for putting "git-gui in Qt" on my wish list.
Andy
--
Dr Andy Parkins, M Eng (hons), MIET
andyparkins@gmail.com
^ permalink raw reply
* Re: git-add--interactive works only in top level
From: Wincent Colaiuta @ 2007-12-04 10:37 UTC (permalink / raw)
To: Junio C Hamano; +Cc: Reid Barton, git
In-Reply-To: <7vmysr9dxg.fsf@gitster.siamese.dyndns.org>
El 4/12/2007, a las 7:22, Junio C Hamano escribió:
> Reid Barton <rwbarton@MIT.EDU> writes:
>
>> I understand that programs such as git-add--interactive will be moved
>> out of the executable path not too long from now, which will also
>> ameliorate the situation.
>
> Honestly, there is nothing to ameliorate. We do not even document
> git-add--interactive on purpose.
>
> Once I saw somebody who somehow got a root account on a shared UNIX
> box
> and tryed running everything he found under /sbin one after another
> without understanding what he was doing. Needless to say, the box did
> not last too long. Somehow that "tab completion" comment reminds of
> him.
Here he have two options: blame the user for his/her stupidity, or
look at this a UI problem and try to make the UI "idiot proof".
In this particular case I see no impediment to favouring the second
option, because we're not talking about making changes that would make
Git less powerful or useful for "non-idiots", "power users" or "real
men" (whatever you want to call them). In other words, we are not
talking about "dumbing down" Git for the sake of the ignorant. This is
an opportunity to polish the UI in the same way that we polish the
internal pack format.
And while it's not a good idea to login as root and try everything
under "/sbin" without knowing what it does, stumbling across "git-add--
interactive" via tab completion is easier to understand. It's an easy
enough mistake to make and it would be nice if we shielded the user
from making it.
I think it is (and always was) an error to expose things like git-add--
interactive which are fundamentally implementation details *internal*
to Git. The user shouldn't even know that it exists. It's one thing to
have a bunch of high-level commands (porcelain) mixed together with
low-level ones (plumbing) in the user's PATH, but it's another
entirely to also stick internal implementation stuff which should
*never* be directly executed in there too. At least in the case of
plumbing there are reasons why you might sometimes directly execute
it, but that's not the case with stuff like git-add--interactive.
So I do think there is something to ameliorate, and moving this stuff
out of the PATH will do exactly that.
Cheers,
Wincent
^ permalink raw reply
* Re: Fix UTF Encoding issue
From: Wincent Colaiuta @ 2007-12-04 10:11 UTC (permalink / raw)
To: Ismail Dönmez
Cc: Martin Koegler, Jakub Narebski, Junio C Hamano,
Alexandre Julliard, Benjamin Close, git,
Perl Unicode Mailing List, Dan Kogai
In-Reply-To: <200712041055.41593.ismail@pardus.org.tr>
El 4/12/2007, a las 9:55, Ismail Dönmez escribió:
> Tuesday 04 December 2007 10:47:39 Ismail Dönmez yazmıştı:
>> Tuesday 04 December 2007 10:44:12 Martin Koegler yazmıştı:
>>> On Tue, Dec 04, 2007 at 10:33:39AM +0200, Ismail Dönmez wrote:
>>>> Following to_utf8 function works for me :
>>>
>>> For me too (Debian sarge+etch).
>>
>> Thanks for testing.
>
> Use Perl built-in utf8 function for UTF-8 decoding.
>
> Signed-off-by: İsmail Dönmez <ismail@pardus.org.tr>
>
> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
> index ff5daa7..db255c1 100755
> --- a/gitweb/gitweb.perl
> +++ b/gitweb/gitweb.perl
> @@ -695,10 +695,9 @@ sub validate_refname {
> # in utf-8 thanks to "binmode STDOUT, ':utf8'" at beginning
> sub to_utf8 {
> my $str = shift;
> - my $res;
> - eval { $res = decode_utf8($str, Encode::FB_CROAK); };
> - if (defined $res) {
> - return $res;
> + if (utf8::valid($str)) {
> + utf8::decode($str);
> + return $str;
This is good as it fixes another problem which some may have
encountered. On at least one distro that I use (Red Hat Enterprise
Linux 3) the Encode module is very old (it's 1.83; the latest release
is 2.23), and so gitweb won't even run, dying during compilation with
this:
Too many arguments for Encode::decode_utf8 at gitweb.cgi line 686,
near "Encode::FB_CROAK)"
Of course, the workaround is to install a newer version of the module,
but this patch eliminates that dependency which is IMO a good thing.
Cheers,
Wincent
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox