* Pull request for sub-tree merge into /contrib/gitstats
From: Sverre Rabbelier @ 2008-10-29 23:06 UTC (permalink / raw)
To: Junio C Hamano, Git Mailinglist
My work is available in the git repository at:
git://repo.or.cz/git-stats.git master
Please use a subtree merge to put this in contrib/gitstats.
David Symonds (2):
Insert the git_stats path to the start of os.sys.path, not 1 element in.
Fix some spelling mistakes.
Sverre Rabbelier (237):
Created a script to setup a repo to test metrics on.
Converted the setupRepo script to python to allow creating the same repo.
Added the use cases in text form.
Added a README.
Initial commit for notes branch
Changelog for 28-05-2008
Changelog for 29-05-2008
Changelog for 30-05-2008
Changelog for 31-05-2008
Created a script that aggregates author activity in one part of
the content.
Updated the script to handle merges and to treat '-' as 0.
Modified author.activityInArea to take a list of strings instead
of a file.
Added a module containing the wrappers for the commands.
Replaced funny characters in use-cases.txt with whitespace.
Created a script that handles index related activities.
Added a script to handle data mining related to commit history.
Created a 'touched' command in the wrapper module.
Added pathsTouched to the history module.
Created a commitTouched function and a prettyPrint helper function
Wrapped the use-cases.txt document at ~72 characters.
Created a list of metrics that can be used to indentify fixes.
Added three more data mining functions to the history module
Gave the setupRepo script some major TLC.
Added commitdiffEqual functionality to the history module.
Creating the repository in a temp directory, use tempfile.gettempdir().
Improved the metrics documentation.
Use 'os.path.join(a, b)' rather than 'a + os.sep + b'.
Removed try/except from setupRepo but added a manual raise
Use the same configurations as test-lib.sh in setupRepo
Copied the test-lib.sh script from git.git/t
Modified test-lib.sh to use ~/code/git as git dir.
Added a basic test that sets up our test repository.
Added a test that verifies the HEAD revision hash
There is now a testcase to check HEAD, don't do it in setupRepo
Added a basic dispatcher to stats.py.
Moved things around a lot, and made commitTouches fixup nonrelative paths
Added basic dispatching functionality for diff
Added a __init__.py file since every module needs one
Made stats.py add the directory containing git_stats to the path
Moved stats.py up one directory
We no longer require running from the root of the repository
Prefixed private methods with _ and and made parseFileDiff
accept larger diffs
Change 'PATHS' to 'COMMIT COMMIT' in the usage text
Finished the dispatching function for commit.
Moved stats.py back to the git_stats directory
Removed the $GIT_STATS_PATH related code
Removed extra newlines and replaced import with 'from .. import ..'
Moved stats.py back up again.
Moved diff.diffContains to commit.logContains
Removed the executable bit on author.py and index.py
Added dispatching to branch and finished branchList
Added dispatching to the author module
Added dispatching to the index module
Started on testing author.py and found the first bug so far
Bugfix for the author filter in author.py
Created a test case to point out an unimplemented function
Added a testcase to point out wrong output for 'stats.py branch -c'
Bugfix for the branchList output in branch.py
Finished the branch testcases, but no test for -r switch yet
The testcases require two patches to git-python to run successfully
Changelog for 01-06-2008
Changelog for 02-06-2008
Changelog for 02-06-2008 (2)
Changelog for 03-06-2008
Changelog for 04-06-2008
Changelog for 05-06-2008
Changelog for 06-06-2008
Changelog for 07-06-2008
Changelog for 08-06-2008
Changelog for 09-06-2008
Changelog for 10-06-2008
Made GitStats compatible with the latest version of git-python
Patches to git-python, since its latest changes, are no longer required
Added testcases for 'commit'
Changelog for 10-06-2008 (2)
Changelog for 11-06-2008
Bugfix for commitdiffMatches
Usability enhancement: print help msg on 'stats.py subcmd'
Merge branch 'notes'
Moved the changelog into the doc subdirectory
Changelog for 12-06-2008
Added testcases for diff and pointed out a bug and some output problems
Bugfix for diff -i, also removed debug output
Improved the dispatching in index.py
Added tests for index.py
Improved the test descriptions
Expanded the setupRepo script to generate a more elaborate tree
Made use of with_keep_cwd now that git-python runs from the top dir
Added tests for "commit -r" and pointed out a bug
Added a todo to check the file passed to "stats.py commit"
Stripped down test-lib.sh to the bits we need
Changelog for 13-06-2008
Changelog for 14-06-2008
Refactored the custom parser into it's own file
Bugfix for commit -t, now checks if the specified file is sane
Changelog for 15-06-2008
Bugfix, created a missing test for "diff -n"
Slight usability improvement
Expanded setupRepo and refactored 'addFile' into it's own function
Bugfix for the testsuite, added tests for 'index -a'
Changelog for 16-06-2008
Created a remote branch in the setupRepo script
Bugfix, added a testcase for "branch -r -c"
Changelog for 17-06-2008
Extended the description of the 'branch contains' metric
Refactored setupRepo a bit to make room for a metrics repo
Added a little more documentation on the branch metric
Extended setupRepo to create the repo as specified in metrics.txt
Updated the metrics repo to have two commits on the topic branch
Initial draft of the 'belongs to' metric
Typo, 'dilate' should be 'dilute'
Changelog for 19-06-2008
Described a more complex tree in metrics.txt
Added a bumpTime to make the commit history look a bit more sane
Changelog for 20-06-2008
Added with_exceptions=False to 'git rev-parse --verify'
Added a GIT_STATS_PRETTY_PRINT environmental variable
Added a '-v' option to stats.py
Added more tags to the generated test repo
Bail out when the testrepo couldn't be set up
Use the new GIT_STATS_PRETTY_PRINT and added tags features
When specifying kwargs they should be in quotes when not part of
a function call.
Use Repo(".").git instead of Git(".")
Updated the metrics repo to match the documented tree
Changelog for 24-06-2008
Changelog for 27-06-2008
Made the 'belongs to' metric recursive
Added tests for the 'belongs to' metric
First gather all parentage information, then run metrics
Changelog for 28-06-2008
Moved isUnique into parse.py so that other modules may use it
Added a "author -f" aggregation, and a test case.
Changelog for 29-06-2008
Minor cleanups, added documentation
Added a switch that lists only reverts of a specified commit
Changelog for 02-07-2008
Changelog for 02-07-2008
When parsing the parent listing take into account parentless commits
Print the usage help sorted and added some documentation
Use a stack-based approach instead of a recursive algorithm
Added a simple 'stats.py bug' command
Disable debug output, print minimum dilution
Optimizations to the 'belongs to' metric
Bugfix to only ignore if dilution was 'worse'
Optimion to the 'belongs to' metric
Don't filter out subsets in the belongs to metric
Optimization in the 'belongs to' metric
Changelog for 06-07-2008
Improved the output of 'branch -b' with '-d'
Added aggregation and showing all activity
Add a config parser and an example configuration
Bugfix to _parseFileDiff so that it handles diffs with mode changes only
Made use of the new config parser in bug.py
Changelog for 10-07-2008
When the specified path was not found, return an empty dict
Don't die when an option is not specified at all
Moved the commit information into a seperate class
Restructured the commit and diff module so that diff depends on commit
Refactored bug.py to allow for a trivial aggregation function
Refactored stats.py to use a main function
Allow for checking deleted files in commitsThatTouched
Check for empty diffs
Add a diff memory to diff.py and use it in bug.py
Don't look before we leap in getting the commit diff
Add a 'commits that touch' memory to commit.py
Two more memories were added and some refactoring
Print authors sorted in 'author -e'
Added an option to disable line numbering in diff parsing
Added a proof of concept matcher
Changelog for 12-07-2008
Add an option to ignore parent in the 'belongs to' metric
Added an option to limit the amount of commits checked
Allow specifying True, False, or None in the config file
Allow specifying True, False, or None on the command line
General cleanups in bug.py
Bugfix for branchContains Fix the branch
Make use of the ignore_parents option to belongsTo
Changelog for 14-07-2008
Provide a default empty dict to pretty names
Refactored bug.py to use a Memory and Options class
Make config.py more versatile
Teach config.py to read multiple verses
Introduce a bugfixRating to bug.py
Changelog for 15-07-2008
Refactoring, cleanups and documentation
Changelog for 16-07-2008
Updated the README to include specific installation instructions
Added a 'net loc' to 'author -a'
Updated the tests to match the new output of 'author -a'
Official 0.1.4 release of git-python
Removed the redundant setupRepo.sh script
Added an option to print the path for setupRepo.py
Added a way to specify the path to use instead of the default
Don't assume the temp path is /tmp
Make use of the 'sorted' built-in
Changelog for 17-07-2008
Added a unit-test framework for GitStats
Use 'key in dict' instead of 'dict.has_key(key)'
Renamed fileDiff to FileDiff
Bugfix for diff.py, don't die on empty diffs
Make use of getattr instead of just trying
Use format specifiers instead of appending to a string
Replace backslashes with parens to do line continuation
Don't asume setupRepo.py is executable
Remove unneeded executionable bit on setupRepo.py
Replace check_file with checkFile
Use dashed_form for variable names instead of camelCase
Changelog for 23-07-2008
Made config.read take a bunch of strings instead of a path
Improved testing.py output and removed manual parsing of arguments
Added a module to dispatch unit-testing commands
Hooked up the test suite in stats.py
Do not require lines to end with a '\n' in the config parser
Refactor config.py to make it more testable
Wrote unittests for the config module and hooked them up
Changelog for 24-07-2008
Don't require stats.py to be in $PATH when running the regression tests
Renamed README to INSTALL
Expanded the INSTALL file to include usage information
Added a README describing GitStats purpose
Convert matcher.py to use optparse
Add a description about the branch module
Add a description about the author module
Add a description about the commit module
Add a general note about the 'stats.py'
Add a description about the diff module
Add a description about the index module
Add a description about the matcher module
Add a description about the tests module
Renamed the GitStats to include a gitstats- prefix
Add a description about the bug module
Renamed Memory->GitCache and Options->OptionList
Expanded the documentation of the bug module
Ran ispell on all non gitstats-* files in doc/
Ran ispell on all gitstats-* files in doc/
Added some example values to gitstats-bug.txt
Bugfix for the config parsing mechanism
INSTALL | 33 ++
README | 59 ++++
doc/changelog.txt | 335 +++++++++++++++++++++
doc/gitstats-author.txt | 30 ++
doc/gitstats-branch.txt | 35 +++
doc/gitstats-bug.txt | 109 +++++++
doc/gitstats-commit.txt | 44 +++
doc/gitstats-diff.txt | 24 ++
doc/gitstats-index.txt | 19 ++
doc/gitstats-matcher.txt | 19 ++
doc/gitstats-stats.txt | 36 +++
doc/gitstats-tests.txt | 8 +
doc/metrics.txt | 83 ++++++
doc/use-cases.txt | 160 ++++++++++
src/git_stats/author.py | 315 ++++++++++++++++++++
src/git_stats/branch.py | 420 ++++++++++++++++++++++++++
src/git_stats/bug.py | 306 +++++++++++++++++++
src/git_stats/commit.py | 343 ++++++++++++++++++++++
src/git_stats/config | 5 +
src/git_stats/config.py | 219 ++++++++++++++
src/git_stats/config_tests.py | 245 +++++++++++++++
src/git_stats/diff.py | 515 ++++++++++++++++++++++++++++++++
src/git_stats/index.py | 102 +++++++
src/git_stats/matcher.py | 130 ++++++++
src/git_stats/parse.py | 109 +++++++
src/git_stats/testing.py | 212 +++++++++++++
src/git_stats/tests.py | 96 ++++++
src/scripts/setupRepo.py | 652 +++++++++++++++++++++++++++++++++++++++++
src/scripts/setupRepo.sh | 31 --
src/stats.py | 112 +++++++
src/t/t8100-stats.sh | 333 +++++++++++++++++++++
src/t/t8101-metrics.sh | 163 ++++++++++
src/t/test-lib.sh | 372 +++++++++++++++++++++++
33 files changed, 5643 insertions(+), 31 deletions(-)
create mode 100644 INSTALL
create mode 100644 README
create mode 100644 doc/changelog.txt
create mode 100644 doc/gitstats-author.txt
create mode 100644 doc/gitstats-branch.txt
create mode 100644 doc/gitstats-bug.txt
create mode 100644 doc/gitstats-commit.txt
create mode 100644 doc/gitstats-diff.txt
create mode 100644 doc/gitstats-index.txt
create mode 100644 doc/gitstats-matcher.txt
create mode 100644 doc/gitstats-stats.txt
create mode 100644 doc/gitstats-tests.txt
create mode 100644 doc/metrics.txt
create mode 100644 doc/use-cases.txt
create mode 100644 src/git_stats/__init__.py
create mode 100644 src/git_stats/author.py
create mode 100644 src/git_stats/branch.py
create mode 100644 src/git_stats/bug.py
create mode 100644 src/git_stats/commit.py
create mode 100644 src/git_stats/config
create mode 100644 src/git_stats/config.py
create mode 100644 src/git_stats/config_tests.py
create mode 100644 src/git_stats/diff.py
create mode 100644 src/git_stats/index.py
create mode 100644 src/git_stats/matcher.py
create mode 100644 src/git_stats/parse.py
create mode 100644 src/git_stats/testing.py
create mode 100755 src/git_stats/tests.py
create mode 100644 src/scripts/setupRepo.py
delete mode 100755 src/scripts/setupRepo.sh
create mode 100755 src/stats.py
create mode 100755 src/t/t8100-stats.sh
create mode 100755 src/t/t8101-metrics.sh
create mode 100644 src/t/test-lib.sh
^ permalink raw reply
* Re: jgit as a jira plugin
From: Shawn O. Pearce @ 2008-10-29 23:08 UTC (permalink / raw)
To: J. Longman; +Cc: git
In-Reply-To: <5915DAE3-7BDF-4296-9DB3-6FBEE504A317@xiplink.com>
"J. Longman" <longman@xiplink.com> wrote:
> I've integrated jgit into a plugin for the Jira Issue tracking system.
> There is more information here:
> http://confluence.atlassian.com/display/JIRAEXT/Jira+Git+Plugin
Cool!
> 1) I noticed that there is a maven pom file. Are you present in a maven
> repository? Also any problem with embedding a working snapshot in my
> plugin?
No, we aren't hosted in any repository yet. The pom file exists to
make it easier for people who prefer maven to build, but its not the
primary build system for jgit.
> 2) I'd like to find out the jgit way to achieve the equivalent of 'svn
> update'. I understand that fetch can do this but being new to git, I
> don't really understand quite what I need yet. The goal is to have git
> the latest commits from the origin before indexing.
Use a Transport instance to execute a default fetch (no args) on say
the "remote" origin. That will download the objects to the local
database, but it won't update a working directory. But I'm not sure
you would care about the working directory in the backend of Jira.
> Thanks for jgit - it took me a day or two to wrap my head around getting
> the list of files changed in a commit but otherwise its great to have
> something that can be integrated into jira.
Yea, about that, we wanted to write more tutorials on the API... ;-)
--
Shawn.
^ permalink raw reply
* Re: Pull request for sub-tree merge into /contrib/gitstats
From: Shawn O. Pearce @ 2008-10-29 23:12 UTC (permalink / raw)
To: sverre; +Cc: Junio C Hamano, Git Mailinglist
In-Reply-To: <bd6139dc0810291606o2efe4254me378335b76861340@mail.gmail.com>
Sverre Rabbelier <alturin@gmail.com> wrote:
> Please use a subtree merge to put this in contrib/gitstats.
Yea, about that...
> Sverre Rabbelier (237):
> Created a script to setup a repo to test metrics on.
> Converted the setupRepo script to python to allow creating the same repo.
> Added the use cases in text form.
> Added a README.
> Initial commit for notes branch
> Changelog for 28-05-2008
> Changelog for 29-05-2008
> Changelog for 30-05-2008
> Changelog for 31-05-2008
...
How is this going to look in the "What's in git.git" email?
We don't use ChangeLog files in git.git and we don't have
notes branches, and we already have a README.
Most stuff in contrib/ has its commit messages with a prefix string
to make it more clear when looking at the shortlog what is being
impacted. Maybe this should be re-written with filter-branch to
include a prefix before it merges.
--
Shawn.
^ permalink raw reply
* Re: Pull request for sub-tree merge into /contrib/gitstats
From: Nicolas Pitre @ 2008-10-29 23:31 UTC (permalink / raw)
To: sverre; +Cc: Junio C Hamano, Git Mailinglist
In-Reply-To: <bd6139dc0810291606o2efe4254me378335b76861340@mail.gmail.com>
On Thu, 30 Oct 2008, Sverre Rabbelier wrote:
> My work is available in the git repository at:
>
> git://repo.or.cz/git-stats.git master
>
> Please use a subtree merge to put this in contrib/gitstats.
[...]
Why do you have commits such as:
> Changelog for 01-06-2008
> Changelog for 02-06-2008
> Changelog for 02-06-2008 (2)
> Changelog for 03-06-2008
> Changelog for 04-06-2008
> Changelog for 05-06-2008
> Changelog for 06-06-2008
> Changelog for 07-06-2008
> Changelog for 08-06-2008
> Changelog for 09-06-2008
> Changelog for 10-06-2008
?
If those are not significant enough to have a proper description, then
I'd suggest you use 'git rebase -i' and its "squash" command to fold
them into the appropriate commit.
Nicolas
^ permalink raw reply
* Re: Pull request for sub-tree merge into /contrib/gitstats
From: Sverre Rabbelier @ 2008-10-29 23:38 UTC (permalink / raw)
To: Nicolas Pitre; +Cc: Junio C Hamano, Git Mailinglist
In-Reply-To: <alpine.LFD.2.00.0810291922320.13034@xanadu.home>
On Thu, Oct 30, 2008 at 00:31, Nicolas Pitre <nico@cam.org> wrote:
> If those are not significant enough to have a proper description, then
> I'd suggest you use 'git rebase -i' and its "squash" command to fold
> them into the appropriate commit.
They are there because the work was done incrementally, having them as
seperate commits shows when the changelog was modified. Having a
description for a change to the changelog is pretty senseless, since
it would be the same text as what is in the diff.
That said, sure, I can squash those commits no problem.
--
Cheers,
Sverre Rabbelier
^ permalink raw reply
* Re: Pull request for sub-tree merge into /contrib/gitstats
From: Sverre Rabbelier @ 2008-10-29 23:39 UTC (permalink / raw)
To: Shawn O. Pearce; +Cc: Junio C Hamano, Git Mailinglist
In-Reply-To: <20081029231251.GB31926@spearce.org>
On Thu, Oct 30, 2008 at 00:12, Shawn O. Pearce <spearce@spearce.org> wrote:
> Most stuff in contrib/ has its commit messages with a prefix string
> to make it more clear when looking at the shortlog what is being
> impacted. Maybe this should be re-written with filter-branch to
> include a prefix before it merges.
Sure, I'm fine with rewriting all commit messages to have a "gitstats:" prefix.
--
Cheers,
Sverre Rabbelier
^ permalink raw reply
* Re: jgit as a jira plugin
From: J. Longman @ 2008-10-29 23:49 UTC (permalink / raw)
To: Shawn O. Pearce; +Cc: git
In-Reply-To: <20081029230816.GA31926@spearce.org>
On 29-Oct-08, at 7:08 PM, Shawn O. Pearce wrote:
> "J. Longman" <longman@xiplink.com> wrote:
>> 2) I'd like to find out the jgit way to achieve the equivalent of
>> 'svn
>> update'. I understand that fetch can do this but being new to git, I
>> don't really understand quite what I need yet. The goal is to have
>> git
>> the latest commits from the origin before indexing.
> Use a Transport instance to execute a default fetch (no args) on say
> the "remote" origin. That will download the objects to the local
> database, but it won't update a working directory. But I'm not sure
> you would care about the working directory in the backend of Jira.
Basically I stole the pgm.Fetch code:
Transport tn = Transport.open(repository, "origin");
final FetchResult r;
List<RefSpec> toget = new ArrayList<RefSpec>();
try {
r = tn.fetch(new TextProgressMonitor(), toget);
} finally {
tn.close();
}
Can I assume that this enough to update the database? If so I think
I'm doing what you're suggesting. After this (and not shown) is some
logging code taken from Fetch, which results in the following:
From /Users/longman/workspace2/work/../masterRepo/
131dcf5..078d43f master -> origin/master
but there doesn't appear to be any specific mention of the incoming
changes.
>> Thanks for jgit - it took me a day or two to wrap my head around
>> getting
>> the list of files changed in a commit but otherwise its great to have
>> something that can be integrated into jira.
> Yea, about that, we wanted to write more tutorials on the API... ;-)
Well, the egit does provide some examples, just there's another API
involved which can be confusing. The code in the jira git plugin the
key classes are GitManagerImpl and RevisionIndexer, but the
RevisionIndexer has some Lucene (text search engine) API mixed-in.
Plus I'm still even learning about git much less the jgit api so I
can't vouch for quality or correctness ;-). I could snip some code
out and send it to you off-list for inclusion in the wiki maybe.
later, j
--
J. Longman
longman@xiplink.com
The information transmitted is intended only for the person or entity to
which it is addressed and may contain confidential and/or privileged
material. If you have received this in error, please contact the sender
and delete this communication and any copy immediately. Thank you.
^ permalink raw reply
* Re: jgit as a jira plugin
From: Shawn O. Pearce @ 2008-10-29 23:53 UTC (permalink / raw)
To: J. Longman; +Cc: git
In-Reply-To: <D7D18CE8-BDBD-430A-BCB6-D1BEFD21C949@xiplink.com>
"J. Longman" <longman@xiplink.com> wrote:
> Basically I stole the pgm.Fetch code:
>
> Transport tn = Transport.open(repository, "origin");
> final FetchResult r;
> List<RefSpec> toget = new ArrayList<RefSpec>();
> try {
> r = tn.fetch(new TextProgressMonitor(), toget);
> } finally {
> tn.close();
> }
>
> Can I assume that this enough to update the database?
Yes
> After this (and not shown) is some
> logging code taken from Fetch, which results in the following:
>
> From /Users/longman/workspace2/work/../masterRepo/
> 131dcf5..078d43f master -> origin/master
>
> but there doesn't appear to be any specific mention of the incoming
> changes.
Well, the new changes are what "git log 131dcf5..078d43f" outputs.
--
Shawn.
^ permalink raw reply
* [PATCH] git-filter-branch: Add an example on how to remove empty commits
From: Petr Baudis @ 2008-10-30 0:33 UTC (permalink / raw)
To: git; +Cc: Sverre Rabbelier
From: Sverre Rabbelier <srabbelier@gmail.com>
Signed-off-by: Sverre Rabbelier <srabbelier@gmail.com>
Signed-off-by: Petr Baudis <pasky@suse.cz>
---
Documentation/git-filter-branch.txt | 15 +++++++++++++++
1 files changed, 15 insertions(+), 0 deletions(-)
diff --git a/Documentation/git-filter-branch.txt b/Documentation/git-filter-branch.txt
index fed6de6..2565244 100644
--- a/Documentation/git-filter-branch.txt
+++ b/Documentation/git-filter-branch.txt
@@ -246,6 +246,21 @@ git filter-branch --commit-filter '
fi' HEAD
------------------------------------------------------------------------------
+To remove commits that are empty (do not introduce any change):
+
+------------------------------------------------------------------------------
+git rev-list HEAD | while read c; do [ -n "$(git diff-tree --root $c)" ] || echo $c; done > revs
+
+git filter-branch --commit-filter '
+ if grep -q "$GIT_COMMIT" '"$(pwd)/"revs';
+ then
+ skip_commit "$@";
+ else
+ git commit-tree "$@";
+ fi' HEAD
+
+------------------------------------------------------------------------------
+
The function 'skip_commit' is defined as follows:
--------------------------
--
1.5.6.3.536.g61aad
^ permalink raw reply related
* Re: Pull request for sub-tree merge into /contrib/gitstats
From: Sverre Rabbelier @ 2008-10-30 0:38 UTC (permalink / raw)
To: Junio C Hamano, Git Mailinglist
In-Reply-To: <bd6139dc0810291606o2efe4254me378335b76861340@mail.gmail.com>
On Thu, Oct 30, 2008 at 00:06, Sverre Rabbelier <alturin@gmail.com> wrote:
> My work is available in the git repository at:
Please use instead:
> git://repo.or.cz/git-stats.git for-junio
Which has the "gitstats:" prefix to all commit messages, and does not
have the changelog file.
--
Cheers,
Sverre Rabbelier
^ permalink raw reply
* Re: [PATCH] git-filter-branch: Add an example on how to remove empty commits
From: Johannes Schindelin @ 2008-10-30 0:56 UTC (permalink / raw)
To: Petr Baudis; +Cc: git, Sverre Rabbelier
In-Reply-To: <1225326833-15210-1-git-send-email-pasky@suse.cz>
Hi,
On Wed, 29 Oct 2008, Petr Baudis wrote:
> +To remove commits that are empty (do not introduce any change):
> +
> +------------------------------------------------------------------------------
> +git rev-list HEAD | while read c; do [ -n "$(git diff-tree --root $c)" ] || echo $c; done > revs
> +
> +git filter-branch --commit-filter '
> + if grep -q "$GIT_COMMIT" '"$(pwd)/"revs';
> + then
> + skip_commit "$@";
> + else
> + git commit-tree "$@";
> + fi' HEAD
You would not need to use the temporary "revs" file by using something
(totally untested, of course):
git filter-branch --commit-filter '
if git diff-tree --exit-status -q "$GIT_COMMIT";
then
git commit-tree "$@";
else
skip_commit "$@";
fi' HEAD
Of course, you could also mention that you could use
git log --cherry-pick -p --pretty=format: ..<branch>@{1}
to verify that all skipped commits had empty diffs. That one is also
totally untested.
Ciao,
Dscho
^ permalink raw reply
* Re: [PATCH] git-filter-branch: Add an example on how to remove empty commits
From: Sam Vilain @ 2008-10-30 0:39 UTC (permalink / raw)
To: Petr Baudis; +Cc: git, Sverre Rabbelier
In-Reply-To: <1225326833-15210-1-git-send-email-pasky@suse.cz>
On Wed, 2008-10-29 at 17:33 -0700, Petr Baudis wrote:
> +To remove commits that are empty (do not introduce any change):
> +
> +------------------------------------------------------------------------------
> +git rev-list HEAD | while read c; do [ -n "$(git diff-tree --root $c)" ] || echo $c; done > revs
> +
> +git filter-branch --commit-filter '
> + if grep -q "$GIT_COMMIT" '"$(pwd)/"revs';
> + then
Why not put the git diff-tree in the commit filter?
Is this tested? It doesn't look like it does what the comment says...
surely you have to compare with the previous commit, not the null
commit?
Sam.
^ permalink raw reply
* Re: Encoding problems using git-svn
From: James North @ 2008-10-30 3:28 UTC (permalink / raw)
To: git
In-Reply-To: <8b168cfb0810282014r789ac01dnec51824de1078f0@mail.gmail.com>
Ok, I made a quick change in git-svn script and seems like is working
now in my system with locale set to iso-8859-1.
Dunno if this is the right place to post this, but I hope someone
knowledgeable see this and tells if this would work as a general fix.
This patch is against 1.6.0.2
--- git-svn 2008-09-15 13:04:46.000000000 +0200
+++ git-svn.mine 2008-10-30 04:21:09.000000000 +0100
@@ -43,6 +43,7 @@
use Getopt::Long qw/:config gnu_getopt no_ignore_case auto_abbrev/;
use IPC::Open3;
use Git;
+use Encode;
BEGIN {
# import functions from Git into our packages, en masse
@@ -1061,6 +1062,7 @@
&& !$saw_from) {
$msgbuf .= "\n\nFrom: $author";
}
+ $msgbuf = encode("utf8", $msgbuf);
print $log_fh $msgbuf or croak $!;
command_close_pipe($msg_fh, $ctx);
}
On Wed, Oct 29, 2008 at 4:14 AM, James North <tocapicha@gmail.com> wrote:
> Hi,
>
> I'm using git-svn on a system with ISO-8859-1 encoding. The problem is
> when I try to use "git svn dcommit" to send changes to a remote svn
> (also ISO-8859-1).
>
> Seems like git-svn is sending commit messages with utf-8 (just a
> guessing...) and they look bad on the remote svn log. E.g. "Ca?\241a
> de cami?\243n"
>
> I have tried using i18n.commitencoding=ISO-8859-1 as suggested by the
> warning when doing "git svn dcommit" but messages still are sent with
> wrong encoding.
>
> I'm mising something?
>
> Thanks everyone
>
^ permalink raw reply
* [PATCH] Documentation: add a planning document for the next CLI revamp
From: Sam Vilain @ 2008-10-30 3:48 UTC (permalink / raw)
To: git, git; +Cc: Sam Vilain, Sam Vilain
From: Sam Vilain <samv@vilain.net>
For cross-command CLI changes to be effective, they need to be
cohesively planned. Add a planning document for this next set of
changes.
Signed-off-by: Sam Vilain <sam@vilain.net>
---
Some suggestions, which have been briefly scanned over by some of the
(remaining @4pm) GitTogether attendees.
Please keep it constructive! :)
Documentation/cli-revamp.txt | 135 ++++++++++++++++++++++++++++++++++++++++++
1 files changed, 135 insertions(+), 0 deletions(-)
create mode 100644 Documentation/cli-revamp.txt
diff --git a/Documentation/cli-revamp.txt b/Documentation/cli-revamp.txt
new file mode 100644
index 0000000..980ea07
--- /dev/null
+++ b/Documentation/cli-revamp.txt
@@ -0,0 +1,135 @@
+GIT command line revamp
+=======================
+
+This design document is designed for review and critique over planned
+direction for changing the command set used by git, rather than
+reviewing and critiquing individual changes.
+
+In general, old commands will be grandfathered for a year or longer,
+and all plumbing commands will still work as originally designed.
+
+Please bear in mind when critiquing that each of these changes might
+themselves have a progressive implementation, for instance the new
+behaviour being optional initially.
+
+Please try to be positive with your comments; let's try to come up
+with solutions and not argue about the details of the solutions
+presented until those details are submitted. In particular, critical
+comments that do not acknowledge the presence of a problem are
+worthless at this stage.
+
+Add/rm/reset/checkout/revert
+----------------------------
+
+Many find these confusing.
+
+ * 'git stage' would do what 'git add' does now.
+
+ * 'git unstage' would do what 'git reset --' does now
+
+ * 'git status' would encourage the user to use
+ 'git diff --staged' to see staged changes as a patch
+
+ * 'git commit' with no changes should give useful information about
+ using 'git stage', 'git commit -a' or 'git commit filename ...'
+
+ * 'git add' and 'git rm': no change
+
+ * 'git update-index' considered plumbing, not changed
+
+ * 'git revert' deprecated in favour of 'git cherry-pick --revert'
+
+ * 'git undo' would do what 'git checkout HEAD --' does now
+
+ * 'git checkout branch' would, if there is a remote branch called
+ 'branch' on exactly one remote, do what
+ 'git checkout -b branch thatremote/branch' does now. If it is
+ ambiguous, it would be an error, forcing the explicit notation.
+
+ * 'git branch --switch' : alternative to checkout
+
+
+Push/pull
+---------
+
+These commands are asymmetric, and this seems mostly historical.
+
+ * 'git push --matching' does what 'git push' does today (without
+ explicit configuration)
+
+ * 'git push' with no ref args and no 'push =' configuration does
+ what:
+ 'git push origin $(git symbolic-ref HEAD | sed "s!refs/heads/!!")'
+ does today. ie, it only pushes the current branch.
+ If a branch was defined in branch.<name>.push, push to that ref
+ instead of the matching one. If there is no matching ref, and
+ there is a branch.<name>.merge, push back there.
+
+ * 'git pull' behaviour unchanged
+
+ * 'git push' to checked out branch of non-bare repository not
+ allowed without special configuration. Configuration available
+ that allows working directory to be updated, known caveats
+ notwithstanding. Ideally, it would refuse only in situations
+ where a broken working copy would be left (because you couldn't
+ fix it), and work when it can be known to be safe.
+
+
+Informational
+-------------
+
+ * 'git branch' should default to '--color=auto -v'
+
+ * 'git tag -l' should show more information
+
+
+Working with patches
+--------------------
+
+ * 'git send-email' should prompt for all SMTP-related information
+ about sending e-mail when it is running with no configuration.
+ Because these days /usr/lib/sendmail is rarely configured
+ correctly.
+
+ * other git send-email functionality which has bitten people -
+ particularly building the recipient list - should prompt for
+ confirmation until configured to be automatic.
+
+ * 'git am -3' the default; with global option to make it not the
+ default for those that prefer the speed of -2
+
+
+Submodules
+----------
+
+ * submodules should be able to refer to symbolic ref names, svn
+ style - in the .gitmodules file. The actual commit used is still
+ recorded in the index.
+
+ * when switching branches, if the checked out revision of a submodule
+ changes, then it should be switched as well
+
+ * 'git submodule update' should be able to be triggered when
+ switching branches (but not be the default behaviour)
+
+
+Others
+------
+
+ * 'git export' command that does what
+ 'git archive --format=tar --prefix=dir | tar x' does now
+
+ * conflicted merges should point the user immediately to
+ 'git mergetool' and mention you need to use 'git stage' to mark
+ resolved files and 'git commit' when done.
+
+ * 'git init --server' (or similar) should do everything required for
+ exporting::
+----
+chmod -R a+rX
+touch git-daemon-export-ok
+git gc
+git update-server-info
+chmod u+x .git/hooks/post-update
+git config core.sharedrepository=1
+----
--
debian.1.5.6.1
^ permalink raw reply related
* Re: Using the --track option when creating a branch
From: Sam Vilain @ 2008-10-30 5:12 UTC (permalink / raw)
To: Bill Lear; +Cc: git
In-Reply-To: <18696.32778.842933.486171@lisa.zopyra.com>
On Wed, 2008-10-29 at 09:23 -0600, Bill Lear wrote:
> We use git in a way that makes it desirable for us to only push/pull
> to the same remote branch. So, if I'm in branch X, I want 'git push'
> to push to origin/X, and 'git pull' to fetch into origin/X and then
> merge into X from origin/X.
>
> In other words, we want git push/pull to behave in branches other than
> master the same way it does when in master.
>
> I have discovered the '--track' option when creating a local branch,
> and this appears to me to be the thing that gives us the desired
> behavior.
As things currently stand this is not achievable behaviour. The
behaviour of 'git push' is to push all matching refs. If you are lucky
this is what you intended, but it also pushes any changes to *other*
branches that you have made.
I have tabled a change proposal to make it work as you suggest in a
separate thread.
Sam
^ permalink raw reply
* Re: git adds some text file as binary file by mistake
From: Ping Yin @ 2008-10-30 6:32 UTC (permalink / raw)
To: Michael J Gruber; +Cc: Git Mailing List
In-Reply-To: <46dff0320810240630s5cbfa62esd10a9da45ce37bf8@mail.gmail.com>
On Fri, Oct 24, 2008 at 9:30 PM, Ping Yin <pkufranky@gmail.com> wrote:
> On Fri, Oct 24, 2008 at 8:54 PM, Michael J Gruber
> <git@drmicha.warpmail.net> wrote:
>> Ping Yin venit, vidit, dixit 24.10.2008 14:37:
>>> So what should i do if i want it added as text file?
>>
>> You should give us more detail on the file ;)
>> What's the extension, what's the typical content? It may be a simple
>> matter of specifying attributes.
>> Do ordinary diff and grep recognize your files as text?
>>
>> Michael
>>
>
> It's just an xml file. I guess maybe there are some hidden characters
> at the beginning. I will figure it out later because i have no access
> to that file right now.
>
> Ping Yin
>
I have figured it out. It's just because the BOM characters feff00 in
the beginning of the utf-8 xml file.
--
Ping Yin
^ permalink raw reply
* Re: [PATCH] Use find instead of perl in t5000 to get file modification time
From: Alex Riesen @ 2008-10-30 7:26 UTC (permalink / raw)
To: Jeff King; +Cc: Git Mailing List, Junio C Hamano, René Scharfe
In-Reply-To: <20081029215444.GA19874@sigill.intra.peff.net>
Jeff King, Wed, Oct 29, 2008 22:54:45 +0100:
> On Wed, Oct 29, 2008 at 11:38:32AM +0100, Alex Riesen wrote:
>
> > There can be a problem with "-printf": Open Group SUS does not specify
> > -printf for find(1), so it is probably a problem somewhere. I just don't know.
> > [...]
> > + find extract/a/a -printf "%T@\\n" >b.mtime &&
>
> $ uname -sr
> FreeBSD 6.1-RELEASE-p17-jc1
> $ find . -printf "%T@\\n"
> find: -printf: unknown option
>
> > There is always a fallback, which is to write a small program which calls
> > native stat(2). Or modify test-chmtime to just print mtime when asked.
>
> I think that makes the most sense.
>
Ok, will do.
^ permalink raw reply
* Re: Encoding problems using git-svn
From: Eric Wong @ 2008-10-30 7:41 UTC (permalink / raw)
To: James North; +Cc: git
In-Reply-To: <8b168cfb0810282014r789ac01dnec51824de1078f0@mail.gmail.com>
Hi James,
I saw your other patch too late, I had already started working on my
patch earlier today but got distracted by other things (being at
GitTogether :) and lacked a stable Internet connection afterwards.
Anyways, here's my version, it handles the case where the user specifies
the --edit option to interactively edit the commit message before
committing; and also reencodes the messages when fetching from SVN.
Can you let me know if it works for you?
Note: I'll be in transit tomorrow and may not have time to follow
up on this until Saturday.
>From 84f003e0c39414ebf27a98de167643e95bed6abb Mon Sep 17 00:00:00 2001
From: Eric Wong <normalperson@yhbt.net>
Date: Wed, 29 Oct 2008 23:49:26 -0700
Subject: [PATCH] git-svn: respect i18n.commitencoding config
SVN itself always stores log messages in the repository as
UTF-8. git always stores/retrieves everything as raw binary
data with no transformations whatsoever.
To interact with SVN, we need to encode log messages as UTF-8
before sending them to SVN, as SVN cannot do it for us. When
retrieving log messages from SVN, we also need to (attempt to)
reencode the UTF-8 log message back to the user-specified commit
encoding.
Note, handling i18n.logoutputencoding for "git svn log" also
needs to be done in a future change.
Also, this change only deals with the encoding of commit
messages and nothing else (path names, blob content, ...).
In-Reply-To: <8b168cfb0810282014r789ac01dnec51824de1078f0@mail.gmail.com>
James North <tocapicha@gmail.com> wrote:
> Hi,
>
> I'm using git-svn on a system with ISO-8859-1 encoding. The problem is
> when I try to use "git svn dcommit" to send changes to a remote svn
> (also ISO-8859-1).
>
> Seems like git-svn is sending commit messages with utf-8 (just a
> guessing...) and they look bad on the remote svn log. E.g. "Ca?\241a
> de cami?\243n"
>
> I have tried using i18n.commitencoding=ISO-8859-1 as suggested by the
> warning when doing "git svn dcommit" but messages still are sent with
> wrong encoding.
Signed-off-by: Eric Wong <normalperson@yhbt.net>
---
git-svn.perl | 24 ++++++++-
t/t9129-git-svn-i18n-commitencoding.sh | 80 ++++++++++++++++++++++++++++++++
2 files changed, 101 insertions(+), 3 deletions(-)
create mode 100755 t/t9129-git-svn-i18n-commitencoding.sh
diff --git a/git-svn.perl b/git-svn.perl
index f90ddac..f24559c 100755
--- a/git-svn.perl
+++ b/git-svn.perl
@@ -1136,9 +1136,19 @@ sub get_commit_entry {
system($editor, $commit_editmsg);
}
rename $commit_editmsg, $commit_msg or croak $!;
- open $log_fh, '<', $commit_msg or croak $!;
- { local $/; chomp($log_entry{log} = <$log_fh>); }
- close $log_fh or croak $!;
+ {
+ # SVN requires messages to be UTF-8 when entering the repo
+ local $/;
+ open $log_fh, '<', $commit_msg or croak $!;
+ binmode $log_fh;
+ chomp($log_entry{log} = <$log_fh>);
+
+ if (my $enc = Git::config('i18n.commitencoding')) {
+ require Encode;
+ Encode::from_to($log_entry{log}, $enc, 'UTF-8');
+ }
+ close $log_fh or croak $!;
+ }
unlink $commit_msg;
\%log_entry;
}
@@ -2273,6 +2283,14 @@ sub do_git_commit {
}
defined(my $pid = open3(my $msg_fh, my $out_fh, '>&STDERR', @exec))
or croak $!;
+ binmode $msg_fh;
+
+ # we always get UTF-8 from SVN, but we may want our commits in
+ # a different encoding.
+ if (my $enc = Git::config('i18n.commitencoding')) {
+ require Encode;
+ Encode::from_to($log_entry->{log}, 'UTF-8', $enc);
+ }
print $msg_fh $log_entry->{log} or croak $!;
restore_commit_header_env($old_env);
unless ($self->no_metadata) {
diff --git a/t/t9129-git-svn-i18n-commitencoding.sh b/t/t9129-git-svn-i18n-commitencoding.sh
new file mode 100755
index 0000000..2848e46
--- /dev/null
+++ b/t/t9129-git-svn-i18n-commitencoding.sh
@@ -0,0 +1,80 @@
+#!/bin/sh
+#
+# Copyright (c) 2008 Eric Wong
+
+test_description='git svn honors i18n.commitEncoding in config'
+
+. ./lib-git-svn.sh
+
+compare_git_head_with () {
+ nr=`wc -l < "$1"`
+ a=7
+ b=$(($a + $nr - 1))
+ git cat-file commit HEAD | sed -ne "$a,${b}p" >current &&
+ test_cmp current "$1"
+}
+
+compare_svn_head_with () {
+ LC_ALL=en_US.UTF-8 svn log --limit 1 `git svn info --url` | \
+ sed -e 1,3d -e "/^-\+\$/d" >current &&
+ test_cmp current "$1"
+}
+
+for H in ISO-8859-1 EUCJP ISO-2022-JP
+do
+ test_expect_success "$H setup" '
+ mkdir $H &&
+ svn import -m "$H test" $H "$svnrepo"/$H &&
+ git svn clone "$svnrepo"/$H $H
+ '
+done
+
+for H in ISO-8859-1 EUCJP ISO-2022-JP
+do
+ test_expect_success "$H commit on git side" '
+ (
+ cd $H &&
+ git config i18n.commitencoding $H &&
+ git checkout -b t refs/remotes/git-svn &&
+ echo $H >F &&
+ git add F &&
+ git commit -a -F "$TEST_DIRECTORY"/t3900/$H.txt &&
+ E=$(git cat-file commit HEAD | sed -ne "s/^encoding //p") &&
+ test "z$E" = "z$H"
+ compare_git_head_with "$TEST_DIRECTORY"/t3900/$H.txt
+ )
+ '
+done
+
+for H in ISO-8859-1 EUCJP ISO-2022-JP
+do
+ test_expect_success "$H dcommit to svn" '
+ (
+ cd $H &&
+ git svn dcommit &&
+ git cat-file commit HEAD | grep git-svn-id: &&
+ E=$(git cat-file commit HEAD | sed -ne "s/^encoding //p") &&
+ test "z$E" = "z$H" &&
+ compare_git_head_with "$TEST_DIRECTORY"/t3900/$H.txt
+ )
+ '
+done
+
+test_expect_success 'ISO-8859-1 should match UTF-8 in svn' '
+(
+ cd ISO-8859-1 &&
+ compare_svn_head_with "$TEST_DIRECTORY"/t3900/1-UTF-8.txt
+)
+'
+
+for H in EUCJP ISO-2022-JP
+do
+ test_expect_success '$H should match UTF-8 in svn' '
+ (
+ cd $H &&
+ compare_svn_head_with "$TEST_DIRECTORY"/t3900/2-UTF-8.txt
+ )
+ '
+done
+
+test_done
--
Eric Wong
^ permalink raw reply related
* Re: request for pre-generated git.info pages
From: Mike Ralphson @ 2008-10-30 9:06 UTC (permalink / raw)
To: SLONIK.AZ, Git Mailing List; +Cc: Junio C Hamano, Jeff King
In-Reply-To: <ee2a733e0810291500o67b3f94fibef63e0a173e8cc1@mail.gmail.com>
2008/10/29 Leo Razoumov <slonik.az@gmail.com>:
> I am an emacs user but with my current setup I have difficulties
> generating git.info pages. Main Git repo already provides
> pre-generated man and html documentation in "man" and "html"
> branches. I would kindly beg to extend this privilege to "info" pages
> to benefit all the emacs users out there.
Unfortunately I don't have a working asciidoc etc toolchain either
(though I will take a look at getting it working on my central git box
which is Linux based). As I'm not an emacs or Info user I probably
wouldn't know if they were building correctly anyway.
However, if anyone can do the above, I'll be happy to help them get
set up to push an 'info' branch to gitbuild.git
(http://repo.or.cz/w/git/gitbuild.git).
How often would you want the info pages rebuilt? Just the versions
which Junio tags? Or would you only want them built from one branch
(e.g. maint)?
Mike
^ permalink raw reply
* Re: request for pre-generated git.info pages
From: Miklos Vajna @ 2008-10-30 9:33 UTC (permalink / raw)
To: Mike Ralphson; +Cc: SLONIK.AZ, Git Mailing List, Junio C Hamano, Jeff King
In-Reply-To: <e2b179460810300206g79e06c63m2060092fa654b18b@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 360 bytes --]
On Thu, Oct 30, 2008 at 09:06:35AM +0000, Mike Ralphson <mike.ralphson@gmail.com> wrote:
> How often would you want the info pages rebuilt? Just the versions
> which Junio tags? Or would you only want them built from one branch
> (e.g. maint)?
Probably it could be done in a similar way to the html and the man pages
(each time master is updated + for tags).
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply
* [StGit PATCH 2/3] stgit.el: Added numeric prefix argument to push and pop commands.
From: David Kågedal @ 2008-10-30 9:52 UTC (permalink / raw)
To: kha, catalin.marinas; +Cc: git
In-Reply-To: <20081030095221.10290.58637.stgit@krank>
By using a numerical prefix (or simply C-u) it is possible to push or
pop more than one patch.
Signed-off-by: David Kågedal <davidk@lysator.liu.se>
---
contrib/stgit.el | 19 +++++++++++--------
1 files changed, 11 insertions(+), 8 deletions(-)
diff --git a/contrib/stgit.el b/contrib/stgit.el
index e6b7d70..9907952 100644
--- a/contrib/stgit.el
+++ b/contrib/stgit.el
@@ -276,16 +276,19 @@ Commands:
(stgit-capture-output nil (stgit-run "uncommit" "-n" (number-to-string arg)))
(stgit-refresh))
-(defun stgit-push-next ()
- "Push the first unapplied patch"
- (interactive)
- (stgit-capture-output nil (stgit-run "push"))
+(defun stgit-push-next (npatches)
+ "Push the first unapplied patch.
+With numeric prefix argument, push that many patches."
+ (interactive "p")
+ (stgit-capture-output nil (stgit-run "push" "-n"
+ (number-to-string npatches)))
(stgit-refresh))
-(defun stgit-pop-next ()
- "Pop the topmost applied patch"
- (interactive)
- (stgit-capture-output nil (stgit-run "pop"))
+(defun stgit-pop-next (npatches)
+ "Pop the topmost applied patch.
+With numeric prefix argument, pop that many patches."
+ (interactive "p")
+ (stgit-capture-output nil (stgit-run "pop" "-n" (number-to-string npatches)))
(stgit-refresh))
(defun stgit-applied-at-point ()
^ permalink raw reply related
* [StGit PATCH 3/3] stgit.el: Adapt to new output from stg series.
From: David Kågedal @ 2008-10-30 9:52 UTC (permalink / raw)
To: kha, catalin.marinas; +Cc: git
In-Reply-To: <20081030095221.10290.58637.stgit@krank>
Signed-off-by: David Kågedal <davidk@lysator.liu.se>
---
contrib/stgit.el | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/contrib/stgit.el b/contrib/stgit.el
index 9907952..d0f19c3 100644
--- a/contrib/stgit.el
+++ b/contrib/stgit.el
@@ -131,7 +131,8 @@ Argument DIR is the repository path."
(when (memq patchsym stgit-marked-patches)
(replace-match "*" nil nil nil 2)
(setq marked (cons patchsym marked)))))
- ((looking-at "stg series: Branch \".*\" not initialised")
+ ((or (looking-at "stg series: Branch \".*\" not initialised")
+ (looking-at "stg series: .*: branch not initialized"))
(forward-line 1)
(insert "Run M-x stgit-init to initialise")))
(forward-line 1))
^ permalink raw reply related
* [StGit PATCH 0/3] stgit.el patches
From: David Kågedal @ 2008-10-30 9:52 UTC (permalink / raw)
To: kha, catalin.marinas; +Cc: git
These three patches updates stgit.el. They don't depend on each other
and can be applied independently.
---
David Kågedal (3):
stgit.el: Adapt to new output from stg series.
stgit.el: Added numeric prefix argument to push and pop commands.
stgit.el: Added undo command
contrib/stgit.el | 36 ++++++++++++++++++++++++++----------
1 files changed, 26 insertions(+), 10 deletions(-)
--
Signature
^ permalink raw reply
* [StGit PATCH 1/3] stgit.el: Added undo command
From: David Kågedal @ 2008-10-30 9:52 UTC (permalink / raw)
To: kha, catalin.marinas; +Cc: git
In-Reply-To: <20081030095221.10290.58637.stgit@krank>
Bound it to the two standard bindings C-/ and C-_.
Signed-off-by: David Kågedal <davidk@lysator.liu.se>
---
contrib/stgit.el | 14 +++++++++++++-
1 files changed, 13 insertions(+), 1 deletions(-)
diff --git a/contrib/stgit.el b/contrib/stgit.el
index aafefaf..e6b7d70 100644
--- a/contrib/stgit.el
+++ b/contrib/stgit.el
@@ -165,7 +165,9 @@ Argument DIR is the repository path."
(define-key stgit-mode-map "P" 'stgit-push-or-pop)
(define-key stgit-mode-map "G" 'stgit-goto)
(define-key stgit-mode-map "=" 'stgit-show)
- (define-key stgit-mode-map "D" 'stgit-delete))
+ (define-key stgit-mode-map "D" 'stgit-delete)
+ (define-key stgit-mode-map [(control ?/)] 'stgit-undo)
+ (define-key stgit-mode-map "\C-_" 'stgit-undo))
(defun stgit-mode ()
"Major mode for interacting with StGit.
@@ -408,4 +410,14 @@ Commands:
(interactive)
(describe-function 'stgit-mode))
+(defun stgit-undo (&optional arg)
+ "Run stg undo.
+With prefix argument, run it with the --hard flag."
+ (interactive "P")
+ (stgit-capture-output nil
+ (if arg
+ (stgit-run "undo" "--hard")
+ (stgit-run "undo")))
+ (stgit-refresh))
+
(provide 'stgit)
^ permalink raw reply related
* [PATCH] asciidoc: add minor workaround to add an empty line after code blocks
From: Jonas Fonseca @ 2008-10-30 10:45 UTC (permalink / raw)
To: Teemu Likonen; +Cc: Junio C Hamano, git
In-Reply-To: <87od13ujm4.fsf@iki.fi>
Insert an empty <simpara> in manpages after code blocks to force and
empty line.
The problem can be seen on the manpage for the git tutorial, where an
example command and the following paragraph is printed with no empty
line between them:
First, note that you can get documentation for a command such as git
log --graph with:
$ man git-log
It is a good idea to introduce yourself to git [...]
Signed-off-by: Jonas Fonseca <fonseca@diku.dk>
---
Documentation/asciidoc.conf | 20 ++++++++++++++++++++
1 files changed, 20 insertions(+), 0 deletions(-)
Teemu Likonen <tlikonen@iki.fi> wrote Thu, Oct 30, 2008:
> In case someone is interested there is still a minor flaw that an
> example command and the following paragraph is printed with no empty
> line between them. Like in the beginning of "git help tutorial", for
> example:
>
> First, note that you can get documentation for a command such as git
> log --graph with:
>
> $ man git-log
> It is a good idea to introduce yourself to git [...]
>
> It would be nicer if there was empty line after "$ man git-log". I can't
> remember if this is new issue or not. This applies only to man pages; in
> html pages there are nice boxes around example commands and equal
> spacing before and after them.
This is an old issue reported by Theodore Ts'o and fixed partially in
commit 63c97ce228f2d2697a8ed954a9592dfb5f286338 for the URL section of
the fetch/pull/push manpages. I have fixed this in tig using an
approach similar to the attached. Simple and clean, but only tested
with docbook-xsl version 1.72 so I have made it conditional.
diff --git a/Documentation/asciidoc.conf b/Documentation/asciidoc.conf
index 40d43b7..2da867d 100644
--- a/Documentation/asciidoc.conf
+++ b/Documentation/asciidoc.conf
@@ -40,6 +40,26 @@ endif::doctype-manpage[]
</literallayout>
{title#}</example>
endif::docbook-xsl-172[]
+
+ifdef::docbook-xsl-172[]
+ifdef::doctype-manpage[]
+# The following two small workarounds insert a simple paragraph after screen
+[listingblock]
+<example><title>{title}</title>
+<screen>
+|
+</screen><simpara></simpara>
+{title#}</example>
+
+[verseblock]
+<formalpara{id? id="{id}"}><title>{title}</title><para>
+{title%}<literallayout{id? id="{id}"}>
+{title#}<literallayout>
+|
+</literallayout><simpara></simpara>
+{title#}</para></formalpara>
+endif::doctype-manpage[]
+endif::docbook-xsl-172[]
endif::backend-docbook[]
ifdef::doctype-manpage[]
--
1.6.0.3.756.gb776d.dirty
--
Jonas Fonseca
^ permalink raw reply related
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox