* Re: [PATCH 1/3] completion: be nicer with zsh
From: Junio C Hamano @ 2012-01-30 18:07 UTC (permalink / raw)
To: Felipe Contreras; +Cc: Junio C Hamano, git
In-Reply-To: <CAMP44s0rp1EwruAwMpntcUzKS=Pbe44t7Eq0OcHdH8WF7OoUhQ@mail.gmail.com>
Felipe Contreras <felipe.contreras@gmail.com> writes:
> In any case, there's no need for ad hominem arguments; there is a
> problem when using zsh, that's a fact.
There was no ad-hominem argument at all.
Read your two lines I quoted "... the code is now actually understandable
(at least to me), while before it looked like voodoo", which was your
words. What does it tell the reader? The patch author (1) did not
understand existing code (voodoo) and (2) the change is a good thing as a
style/readability improvement.
I was saying that I did not want to see that in the justification, because
(2) is not true, while (1) may be.
The patch as-is is a good change that works around issues with zsh's POSIX
emulation, and that is sufficient-enough justification. IOW, we are in
agreement on the later half of your sentence.
^ permalink raw reply
* Re: [PATCH v2 4/4] completion: be nicer with zsh
From: Jonathan Nieder @ 2012-01-30 17:53 UTC (permalink / raw)
To: Felipe Contreras
Cc: git, Felipe Contreras, Lee Marlow, Shawn O. Pearce,
SZEDER Gábor
In-Reply-To: <1327944197-6379-5-git-send-email-felipec@infradead.org>
Felipe Contreras wrote:
> --- a/contrib/completion/git-completion.bash
> +++ b/contrib/completion/git-completion.bash
> @@ -657,7 +657,8 @@ __git_merge_strategies=
> # is needed.
> __git_compute_merge_strategies ()
> {
> - : ${__git_merge_strategies:=$(__git_list_merge_strategies)}
> + test "$__git_merge_strategies" && return
> + __git_merge_strategies=$(__git_list_merge_strategies 2> /dev/null)
Why the new redirect? If I add debugging output to
__git_list_merge_strategies that writes to stderr, I want to see it.
Why the 'test "$foo"' form instead of [[ -n which is more common in
this completion script? Why use "return" instead of
[[ -n $var ]] || var=$(...)
which feels a little simpler?
^ permalink raw reply
* Re: [PATCH v2 3/4] completion: cleanup __gitcomp*
From: Jonathan Nieder @ 2012-01-30 17:50 UTC (permalink / raw)
To: Felipe Contreras
Cc: git, Felipe Contreras, Ted Pavlic, SZEDER Gábor,
Shawn O. Pearce
In-Reply-To: <1327944197-6379-4-git-send-email-felipec@infradead.org>
Felipe Contreras wrote:
> I don't know why there's so much code; these functions don't seem to be
> doing much:
Unless you mean "This patch has had inadequate review and I don't
understand the code I'm patching, so do not trust it", please drop
this commentary or place it after the three dashes.
> * no need to check $#, ${3:-$cur} is much easier
> * __gitcomp_nl doesn't seem to using the initial IFS
>
> This makes the code much simpler.
>
> Eventually it would be nice to wrap everything that touches compgen and
> COMPREPLY in one function for the zsh wrapper.
>
> Comments by Jonathan Nieder.
I don't want this acknowledgement. Who should care that I commented
on something?
> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
> ---
> contrib/completion/git-completion.bash | 20 +++-----------------
> 1 files changed, 3 insertions(+), 17 deletions(-)
This diffstat tells me more of what I wanted to know about the patch
than the description did.
I imagine it would have been enough to say something along the lines of
"The __gitcomp and __gitcomp_nl functions are unnecessarily verbose.
__gitcomp_nl sets IFS to " \t\n" unnecessarily before setting it to "\n"
by mistake. Both functions use 'if' statements to read parameters
with defaults, where the ${parameter:-default} idiom would be just as
clear. By fixing these, we can make each function almost a one-liner."
By the way, the subject ("clean up __gitcomp*") tells me almost as
little as something like "fix __gitcomp*". A person reading the
shortlog would like to know _how_ you are fixing it, or what the
impact of the change will be --- e.g., something like "simplify
__gitcomp and __gitcomp_nl" would be clearer.
[...]
> --- a/contrib/completion/git-completion.bash
> +++ b/contrib/completion/git-completion.bash
[...]
> @@ -524,18 +520,8 @@ __gitcomp ()
> # appended.
> __gitcomp_nl ()
> {
> - local s=$'\n' IFS=' '$'\t'$'\n'
> - local cur_="$cur" suffix=" "
> -
> - if [ $# -gt 2 ]; then
> - cur_="$3"
> - if [ $# -gt 3 ]; then
> - suffix="$4"
> - fi
> - fi
> -
> - IFS=$s
> - COMPREPLY=($(compgen -P "${2-}" -S "$suffix" -W "$1" -- "$cur_"))
> + local IFS=$'\n'
> + COMPREPLY=($(compgen -P "${2-}" -S "${4:- }" -W "$1" -- "${3:-$cur}"))
This loses the nice name $suffix for the -S argument. Not a problem,
just noticing.
^ permalink raw reply
* [PATCH v2] completion: add new zsh completion
From: Felipe Contreras @ 2012-01-30 17:40 UTC (permalink / raw)
To: git; +Cc: Felipe Contreras
From: Felipe Contreras <felipe.contreras@gmail.com>
It seems there's always issues with zsh's bash completion emulation,
after I took a deep look at the code, I found many issues[1].
So, here is a kind of wrapper that does the same, but properly :)
This would also allow us to make fixes if necessary, since the code is
simple enough, and extend functionality.
[1] http://article.gmane.org/gmane.comp.shells.zsh.devel/24290
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
---
v2:
* Fix completion of aliased commands
* Add check for wrong commands
* Properly set return codes
* Add default actiooon; for 'git foo -- <tab>'
contrib/completion/git-completion.zsh | 181 +++++++++++++++++++++++++++++++++
1 files changed, 181 insertions(+), 0 deletions(-)
create mode 100644 contrib/completion/git-completion.zsh
diff --git a/contrib/completion/git-completion.zsh b/contrib/completion/git-completion.zsh
new file mode 100644
index 0000000..bca08f2
--- /dev/null
+++ b/contrib/completion/git-completion.zsh
@@ -0,0 +1,181 @@
+#compdef git gitk
+
+# zsh completion wrapper for git
+#
+# You need git's bash completion script installed somewhere, by default on the
+# same directory as this script.
+#
+# If your script is on ~/.git-completion.sh instead, you can configure it on
+# your ~/.zshrc:
+#
+# zstyle ':completion:*:*:git:*' script ~/.git-completion.sh
+#
+# The recommended way to install this script is to copy to
+# '~/.zsh/completion/_git', and then add the following to your ~/.zshrc file:
+#
+# fpath=(~/.zsh/completion $fpath)
+
+compgen () {
+ local prefix suffix
+ local -a results
+ while getopts "W:P:S:" opt
+ do
+ case $opt in
+ W)
+ results=( ${(Q)~=OPTARG} )
+ ;;
+ P)
+ prefix="$OPTARG"
+ ;;
+ S)
+ suffix="$OPTARG"
+ ;;
+ esac
+ done
+ print -l -r -- "$prefix${^results[@]}$suffix"
+}
+
+complete () {
+ # do nothing
+ return 0
+}
+
+zstyle -s ":completion:$curcontext:" script script
+test -z "$script" && script="$(dirname ${funcsourcetrace[1]%:*})"/git-completion.bash
+ZSH_VERSION='' . "$script"
+
+_get_comp_words_by_ref ()
+{
+ while [ $# -gt 0 ]; do
+ case "$1" in
+ cur)
+ cur=${_words[CURRENT]}
+ ;;
+ prev)
+ cur=${_words[CURRENT-1]}
+ ;;
+ words)
+ words=("${_words[@]}")
+ ;;
+ cword)
+ ((cword = CURRENT - 1))
+ ;;
+ esac
+ shift
+ done
+}
+
+_bash_wrap ()
+{
+ local -a COMPREPLY results _words
+ _words=( $words )
+ () {
+ emulate -L sh
+ setopt KSH_TYPESET
+ setopt kshglob noshglob braceexpand nokshautoload
+ typeset -h words
+ local cur words cword prev
+ _get_comp_words_by_ref -n =: cur words cword prev
+ $1
+ } $1
+ results=( "${^COMPREPLY[@]}" )
+ if [[ -n $results ]]; then
+ local COMP_WORDBREAKS="\"'@><=;|&(:"
+ local i start
+ local cur="${words[CURRENT]}"
+ i=$(expr index "$cur" "$COMP_WORDBREAKS")
+ start="${cur:0:$i}"
+ compadd -Q -S '' -p "$start" -a results && ret=0
+ fi
+ if (( ret )); then
+ _default -S '' && ret=0
+ fi
+}
+
+_gitk ()
+{
+ __git_has_doubledash && return
+
+ local g="$(__gitdir)"
+ local merge=""
+ if [ -f "$g/MERGE_HEAD" ]; then
+ merge="--merge"
+ fi
+ case "$cur" in
+ --*)
+ __gitcomp "
+ $__git_log_common_options
+ $__git_log_gitk_options
+ $merge
+ "
+ return
+ ;;
+ esac
+ __git_complete_revlist
+}
+
+_get_completion_func ()
+{
+ emulate -L sh
+ setopt KSH_TYPESET
+ local command="$1"
+
+ completion_func="_git_${command//-/_}"
+ declare -f $completion_func >/dev/null && return
+
+ local expansion=$(__git_aliased_command "$command")
+ if [ -n "$expansion" ]; then
+ completion_func="_git_${expansion//-/_}"
+ declare -f $completion_func >/dev/null && return
+ fi
+
+ completion_func=
+}
+
+_git ()
+{
+ local ret=1
+
+ if [[ $service != git ]]
+ then
+ _bash_wrap _$service
+ return ret
+ fi
+
+ local curcontext="$curcontext" state state_descr line
+ typeset -A opt_args
+
+ _arguments -C \
+ '(-p --paginate --no-pager)'{-p,--paginate}'[Pipe all output into ''less'']' \
+ '(-p --paginate)--no-pager[Do not pipe git output into a pager]' \
+ '--git-dir=-[Set the path to the repository]: :_directories' \
+ '--bare[Treat the repository as a bare repository]' \
+ '(- :)--version[Prints the git suite version]' \
+ '--exec-path=-[Path to where your core git programs are installed]:: :_directories' \
+ '--html-path[Print the path where git''s HTML documentation is installed]' \
+ '--work-tree=-[Set the path to the working tree]: :_directories' \
+ '--namespace=-[Set the git namespace]: :_directories' \
+ '(- :)--help[Prints the synopsis and a list of the most commonly used commands]' \
+ '(-): :->command' \
+ '(-)*:: :->option-or-argument' && return 0
+
+ case $state in
+ (command)
+ emulate sh -c __git_compute_porcelain_commands
+ local -a porcelain aliases
+ porcelain=( ${=__git_porcelain_commands} )
+ aliases=( $(__git_aliases) )
+ _describe -t porcelain-commands 'porcelain commands' porcelain && ret=0
+ _describe -t aliases 'aliases' aliases && ret=0
+ ;;
+ (option-or-argument)
+ local completion_func
+ _get_completion_func "${words[1]}"
+ test "$completion_func" && _bash_wrap $completion_func
+ ;;
+ esac
+
+ return ret
+}
+
+_git
--
1.7.8
^ permalink raw reply related
* Re: [PATCH v2 1/4] completion: simplify __git_remotes
From: Jonathan Nieder @ 2012-01-30 17:34 UTC (permalink / raw)
To: Felipe Contreras
Cc: git, Felipe Contreras, Junio C Hamano, Shawn O. Pearce,
SZEDER Gábor
In-Reply-To: <1327944197-6379-2-git-send-email-felipec@infradead.org>
Felipe Contreras wrote:
> From: Felipe Contreras <felipe.contreras@gmail.com>
>
> There's no need for all that complicated code that requires nullglob,
> and the complexities related to such option.
>
> As an advantage, this would allow us to get rid of __git_shopt, which is
> used only in this fuction to enable 'nullglob' in zsh.
That is all a longwinded way to say "zsh doesn't support the same
interface as bash for setting the nullglob option, so let's avoid
it and use 'ls' which is simpler", right?
There's a potential speed regression involved --- using "ls" involves
an extra fork/exec. I believe you have thought about this and done a
little to mitigate it; could you explain this in the commit message so
future coders know what features of your code need to be preserved?
Please consider squashing this with patch 2/4. It will make both
patches way easier to understand on their own.
Cc-ing Gábor, who I imagine is more familiar with this code than I am.
> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
> ---
> contrib/completion/git-completion.bash | 7 +------
> 1 files changed, 1 insertions(+), 6 deletions(-)
>
> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
> index 1496c6d..086e38d 100755
> --- a/contrib/completion/git-completion.bash
> +++ b/contrib/completion/git-completion.bash
> @@ -644,12 +644,7 @@ __git_refs_remotes ()
> __git_remotes ()
> {
> local i ngoff IFS=$'\n' d="$(__gitdir)"
> - __git_shopt -q nullglob || ngoff=1
> - __git_shopt -s nullglob
> - for i in "$d/remotes"/*; do
> - echo ${i#$d/remotes/}
> - done
> - [ "$ngoff" ] && __git_shopt -u nullglob
> + test -d "$d/remotes" && ls -1 "$d/remotes"
> for i in $(git --git-dir="$d" config --get-regexp 'remote\..*\.url' 2>/dev/null); do
> i="${i#remote.}"
> echo "${i/.url*/}"
> --
> 1.7.8
>
^ permalink raw reply
* [PATCH v2 2/4] completion: remove unused code
From: Felipe Contreras @ 2012-01-30 17:23 UTC (permalink / raw)
To: git; +Cc: Jonathan Nieder, Felipe Contreras
In-Reply-To: <1327944197-6379-1-git-send-email-felipec@infradead.org>
From: Felipe Contreras <felipe.contreras@gmail.com>
No need for this rather complicated piece of code anymore :)
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
---
contrib/completion/git-completion.bash | 30 ------------------------------
1 files changed, 0 insertions(+), 30 deletions(-)
diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
index 086e38d..4f68f0a 100755
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash
@@ -2728,33 +2728,3 @@ if [ Cygwin = "$(uname -o 2>/dev/null)" ]; then
complete -o bashdefault -o default -o nospace -F _git git.exe 2>/dev/null \
|| complete -o default -o nospace -F _git git.exe
fi
-
-if [[ -n ${ZSH_VERSION-} ]]; then
- __git_shopt () {
- local option
- if [ $# -ne 2 ]; then
- echo "USAGE: $0 (-q|-s|-u) <option>" >&2
- return 1
- fi
- case "$2" in
- nullglob)
- option="$2"
- ;;
- *)
- echo "$0: invalid option: $2" >&2
- return 1
- esac
- case "$1" in
- -q) setopt | grep -q "$option" ;;
- -u) unsetopt "$option" ;;
- -s) setopt "$option" ;;
- *)
- echo "$0: invalid flag: $1" >&2
- return 1
- esac
- }
-else
- __git_shopt () {
- shopt "$@"
- }
-fi
--
1.7.8
^ permalink raw reply related
* [PATCH 0/4] completion: trivial cleanups
From: Felipe Contreras @ 2012-01-30 17:23 UTC (permalink / raw)
To: git; +Cc: Jonathan Nieder, Felipe Contreras
From: Felipe Contreras <felipe.contreras@gmail.com>
And an improvement for zsh.
Felipe Contreras (4):
completion: simplify __git_remotes
completion: remove unused code
completion: cleanup __gitcomp*
completion: be nicer with zsh
contrib/completion/git-completion.bash | 66 +++++---------------------------
1 files changed, 10 insertions(+), 56 deletions(-)
--
1.7.8
^ permalink raw reply
* Re: [PATCH v5 5/5] gitweb: place links to parent directories in page header
From: Jakub Narebski @ 2012-01-30 17:10 UTC (permalink / raw)
To: Bernhard R. Link; +Cc: Junio C Hamano, git
In-Reply-To: <20120130115046.GE9267@server.brlink.eu>
On Mon, 30 Jan 2012, Bernhard R. Link wrote:
> Change html page headers to not only link the project root and the
> currently selected project but also the directories in between using
> project_filter. (Allowing to jump to a list of all projects within
> that intermediate directory directly and making the project_filter
> feature visible to users).
Nice idea, nice description.
> Signed-off-by: Bernhard R. Link <brlink@debian.org>
> ---
> gitweb/gitweb.perl | 5 ++++-
> 1 files changed, 4 insertions(+), 1 deletions(-)
>
> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
> index dfc79df..b54ddb9 100755
> --- a/gitweb/gitweb.perl
> +++ b/gitweb/gitweb.perl
> @@ -3853,7 +3853,10 @@ sub print_nav_breadcrumbs {
>
> print $cgi->a({-href => esc_url($home_link)}, $home_link_str) . " / ";
> if (defined $project) {
> - print $cgi->a({-href => href(action=>"summary")}, esc_html($project));
> + my @dirname = split '/', $project;
> + my $projectbasename = pop @dirname;
> + print_nav_breadcrumbs_path(@dirname);
> + print $cgi->a({-href => href(action=>"summary")}, esc_html($projectbasename));
> if (defined $action) {
> my $action_print = $action ;
> if (defined $opts{-action_extra}) {
> --
Nice code.
--
Jakub Narebski
Poland
^ permalink raw reply
* Re: [PATCH] merge: use editor by default in interactive sessions
From: Thomas Rast @ 2012-01-30 17:06 UTC (permalink / raw)
To: Junio C Hamano, git
In-Reply-To: <7vipk26p1b.fsf@alter.siamese.dyndns.org>
On Mon, 23 Jan 2012 14:18:40 -0800, Junio C Hamano <gitster@pobox.com> wrote:
> Traditionally, a cleanly resolved merge was committed by "git merge" using
> the auto-generated merge commit log message with invoking the editor.
>
> After 5 years of use in the field, it turns out that people perform too
> many unjustified merges of the upstream history into their topic branches.
> These merges are not just useless, but they are often not explained well,
> and making the end result unreadable when it gets time for merging their
> history back to their upstream.
Ok, so I'm late to the party and perhaps I missed the discussion about
this, but...
I think the proposed commit message should have a comment, just like for
an ordinary commit, that explains why we are showing the user an editor.
(I'm too lazy to check, but I suspect we *always* give a comment about
what is going on when we fire up an editor.)
I would suggest something like
# Please enter the commit message for your merge commit. Lines starting
# with '#' will be ignored, and an empty message aborts the commit.
or if you feel comfortable with educating the user in a
workflow-specific way, even
# Please enter the commit message for your merge commit. You should
# justify it especially if it merges an updated upstream into a topic
# branch.
#
# Lines starting with '#' will be ignored, and an empty message aborts
# the commit.
--
Thomas Rast
trast@{inf,student}.ethz.ch
^ permalink raw reply
* Re: git-subtree
From: David A. Greene @ 2012-01-30 16:56 UTC (permalink / raw)
To: David A. Greene; +Cc: Jeff King, Ramkumar Ramachandra, git
In-Reply-To: <87aa56kvr4.fsf@smith.obbligato.org>
greened@obbligato.org (David A. Greene) writes:
> I originally put them under t97XX but now that is taken, as is
> everything up to and including t99XX.
Oops, I lied. I originally put them under t79XX and I've kept that for
now. Sound good?
-Dave
^ permalink raw reply
* git rebase and MacOS 10.7.2 file versions
From: Thomas Röfer @ 2012-01-30 16:46 UTC (permalink / raw)
To: git
Hi,
I get mysterious behavior during git rebase on MacOS 10.7.x. git reports unresolvable conflicts, stops the rebase, but afterwards the list of files that needs to be fixed is empty. git rebase --skip does not help, because then the commit is actually missing.
What helps is to abort the rebase, copy the conflicting files, delete the originals and move back the copies instead. The files themselves are identical before deleting and after restoring and their access rights are also unchanged. What is actually different is that all the conflicting files so far had older versions stored by Lion's "file versions" feature. The restored copies do not have such a version history. Since "file versions" cannot be deactivated, editing a file with an application that supports it (e.g. TextEdit) will basically result in strange git conflicts later.
I have tested this with a number of git versions, but the behavior is always the same.
All this may simply be a bug in MacOS 10.7.x, but maybe there is a workaround for git to make this work again.
Best regards,
Thomas Röfer
^ permalink raw reply
* Re: [PATCH v5.5 1/5] gitweb: prepare git_get_projects_list for use outside 'forks'.
From: Bernhard R. Link @ 2012-01-30 16:29 UTC (permalink / raw)
To: Jakub Narebski; +Cc: Junio C Hamano, git
In-Reply-To: <201201301640.35843.jnareb@gmail.com>
* Jakub Narebski <jnareb@gmail.com> [120130 16:40]:
> Perhaps there are other cases...
>
> > @@ -2841,7 +2840,7 @@ sub git_get_projects_list {
> > my $pfxlen = length("$dir");
> > my $pfxdepth = ($dir =~ tr!/!!);
> > # when filtering, search only given subdirectory
> > - if ($filter) {
> > + if ($filter and not $paranoid) {
>
> Hmmmm... ($filter and !$paranoid) or ($filter && !$paranoid)?
> Which would be more Perl-ish and fit current code style better...
I cannot say what is more perlish, but gitweb.perl seems to contain
only the combinations "and not" (1 time) and "&& !" (8 times).
Bernhard R. Link
^ permalink raw reply
* Re: [PATCH v5 4/5] gitweb: show active project_filter in project_list page header
From: Jakub Narebski @ 2012-01-30 16:38 UTC (permalink / raw)
To: Bernhard R. Link; +Cc: Junio C Hamano, git
In-Reply-To: <20120130114852.GD9267@server.brlink.eu>
On Mon, 30 Jan 2012, Bernhard R. Link wrote:
> In a project_list view show breadcrumbs with the currently active
> project_filter (and those of parent directories) in the page header.
O.K. (though I'd prefer written it less concise and more clear).
> Signed-off-by: Bernhard R. Link <brlink@debian.org>
> ---
> gitweb/gitweb.perl | 14 ++++++++++++++
> 1 files changed, 14 insertions(+), 0 deletions(-)
>
> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
> index e022e11..dfc79df 100755
> --- a/gitweb/gitweb.perl
> +++ b/gitweb/gitweb.perl
> @@ -3836,6 +3836,18 @@ sub print_header_links {
> }
> }
>
> +sub print_nav_breadcrumbs_path {
> + my $dirprefix = undef;
> + while (my $part = shift) {
Hmmm... using agument list directly, without copying it? Well, all right.
> + $dirprefix .= "/" if defined $dirprefix;
> + $dirprefix .= $part;
> + print $cgi->a({-href => href(project => undef,
> + project_filter => $dirprefix,
> + action=>"project_list")},
Minor nitpick: Let's use same whitespace rules for all key-value pairs
+ action => "project_list")},
> + esc_html($part)) . " / ";
> + }
> +}
> +
> sub print_nav_breadcrumbs {
> my %opts = @_;
>
> @@ -3854,6 +3866,8 @@ sub print_nav_breadcrumbs {
> print " / $opts{-action_extra}";
> }
> print "\n";
> + } elsif (defined $project_filter) {
> + print_nav_breadcrumbs_path(split '/', $project_filter);
> }
> }
Nice!
--
Jakub Narebski
Poland
^ permalink raw reply
* Re: [PATCH 3/5] gitweb: limit links to alternate forms of project_list to active project_filter
From: Jakub Narebski @ 2012-01-30 16:09 UTC (permalink / raw)
To: Bernhard R. Link; +Cc: Junio C Hamano, git
In-Reply-To: <20120130114706.GC9267@server.brlink.eu>
On Mon, 30 Jan 2012, Bernhard R. Link wrote:
> If project_list action is given a project_filter argument, pass that to
> TXT and OPML formats.
Nice.
This way [OPML] and [TXT] links provide the same list of projects as
the projects_list page they are linked from.
> Signed-off-by: Bernhard R. Link <brlink@debian.org>
> ---
> gitweb/gitweb.perl | 6 ++++--
> 1 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
> index 36efc10..e022e11 100755
> --- a/gitweb/gitweb.perl
> +++ b/gitweb/gitweb.perl
> @@ -3976,9 +3976,11 @@ sub git_footer_html {
> }
>
> } else {
> - print $cgi->a({-href => href(project=>undef, action=>"opml"),
> + print $cgi->a({-href => href(project=>undef, action=>"opml",
> + project_filter => $project_filter),
> -class => $feed_class}, "OPML") . " ";
> - print $cgi->a({-href => href(project=>undef, action=>"project_index"),
> + print $cgi->a({-href => href(project=>undef, action=>"project_index",
> + project_filter => $project_filter),
> -class => $feed_class}, "TXT") . "\n";
> }
Nicely short.
--
Jakub Narebski
Poland
^ permalink raw reply
* Re: gitweb showing slash r at the end of line
From: Ondra Medek @ 2012-01-30 16:09 UTC (permalink / raw)
To: git
In-Reply-To: <m3obtlczmu.fsf@localhost.localdomain>
Thanks for pointing out the [gitweb] section of the config. Should I try to
make the patch or someone else more skilled would pick this up?
Cheers
Ondra
--
View this message in context: http://git.661346.n2.nabble.com/gitweb-showing-slash-r-at-the-end-of-line-tp7229895p7237025.html
Sent from the git mailing list archive at Nabble.com.
^ permalink raw reply
* Re: [PATCH v5 2/5] gitweb: add project_filter to limit project list to a subdirectory
From: Jakub Narebski @ 2012-01-30 15:57 UTC (permalink / raw)
To: Bernhard R. Link; +Cc: Junio C Hamano, git
In-Reply-To: <20120130114557.GB9267@server.brlink.eu>
On Mon, 30 Jan 2012, Bernhard R. Link wrote:
> This commit changes the project listing views (project_list,
> project_index and opml) to limit the output to only projects in a
> subdirectory if the new optional parameter ?pf=directory name is
> used.
It would be nice to have in this or in a separate commit an update
to get_page_title() for HTML output, and to git_opml() updating
<title> element in OPML output, so that it mentions that project
list is limitied to $project_filter subdirectory.
For plain text output of git_project_index() nothing really can be
done -- there is no title. Well, we could fiddle with 'filename'
part of Content-Disposition HTTP header...
> The implementation of the filter reuses the implementation used for
> the 'forks' action (i.e. listing all projects within that directory
> from the projects list file (GITWEB_LIST) or only projects in the
> given subdirectory of the project root directory without a projects
> list file).
O.K., more detailed description of $strict_export interaction is in
that other commit.
> Reusing $project instead of adding a new parameter would have been
> nicer from a UI point-of-view (including PATH_INFO support) but
> would complicate the $project validating code that is currently
> being used to ensure nothing is exported that should not be viewable.
Nb. I wonder if we should make it invalid to have both 'project' and
'project_filter' parameters...
> @@ -994,6 +995,13 @@ sub evaluate_and_validate_params {
> }
> }
>
> + our $project_filter = $input_params{'project_filter'};
> + if (defined $project_filter) {
> + if (!validate_pathname($project_filter)) {
> + die_error(404, "Invalid project_filter parameter");
> + }
> + }
> +
That accidentally makes "pf=foo/" (with trailing slash) invalid.
On the other hand being able to assume that $project_filter doesn't
end in '/' simplifies code a bit.
> @@ -5984,7 +5992,7 @@ sub git_project_list {
> - my @list = git_get_projects_list();
> + my @list = git_get_projects_list($project_filter, $strict_export);
> sub git_project_index {
> - my @projects = git_get_projects_list();
> + my @projects = git_get_projects_list($project_filter, $strict_export);
> sub git_opml {
> - my @list = git_get_projects_list();
> + my @list = git_get_projects_list($project_filter, $strict_export);
Nice!
--
Jakub Narebski
Poland
^ permalink raw reply
* Re: [PATCH v5.5 1/5] gitweb: prepare git_get_projects_list for use outside 'forks'.
From: Jakub Narebski @ 2012-01-30 15:40 UTC (permalink / raw)
To: Bernhard R. Link; +Cc: Junio C Hamano, git
In-Reply-To: <20120130145538.GA2162@server.brlink.eu>
On Mon, 30 Jul 2012, Bernhard R. Link wrote:
> Use of the filter option of git_get_projects_list is currently
> limited to forks. It hard codes removal of ".git" suffixes from
> the filter and assumes the project belonging to the filter directory
> was already validated to be visible in the project list.
>
> To make it more generic move the .git suffix removal to the callers
> and add an optional argument to denote visibility verification is
> still needed.
Even better for patch readability would be to split this patch further,
with the first part just moving removal of ".git" suffix from said
function to callers.
> If there is a projects list file (GITWEB_LIST) only projects from
> this list are returned anyway, so no more checks needed.
>
> If there is no projects list file and the caller requests strict
> checking (GITWEB_STRICT_EXPORT), do not jump directly to the
> given directory but instead do a normal search and filter the
> results instead.
>
> The only (hopefully non-existing) effect of GITWEB_STRICT_EXPORT
> without GITWEB_LIST is to make sure no project can be viewed without
> also be found starting from project root. git_get_projects_list without
> this patch does not enforce this but all callers only call it with
> a filter already checked this way. With this parameter a caller
> can request this check if the filter cannot be checked this way.
O.K. now I see where the "paranoid mode" might make difference: if
one of intermediate directories in $project_filter subdirectory has
search/access permission ('x' bit) but is not readable ('r' bit),
then gitweb would show nothing in $strict_export mode, but scan from
"$projects_list/$project_filter" in non-strict mode.
Perhaps there are other cases...
> @@ -2841,7 +2840,7 @@ sub git_get_projects_list {
> my $pfxlen = length("$dir");
> my $pfxdepth = ($dir =~ tr!/!!);
> # when filtering, search only given subdirectory
> - if ($filter) {
> + if ($filter and not $paranoid) {
Hmmmm... ($filter and !$paranoid) or ($filter && !$paranoid)?
Which would be more Perl-ish and fit current code style better...
--
Jakub Narebski
Poland
^ permalink raw reply
* Re: commit/from command in git-fast-import
From: Sverre Rabbelier @ 2012-01-30 15:35 UTC (permalink / raw)
To: Jonathan Nieder; +Cc: David Barr, Mike Hommey, git, Dmitry Ivankov
In-Reply-To: <20120127210936.GC3124@burratino>
On Fri, Jan 27, 2012 at 15:09, Jonathan Nieder <jrnieder@gmail.com> wrote:
> The unfortunate term here is "existing branches", which seems to have
> been intended to refer to refs that have already been populated in
> this fast-import stream by a "commit" or "reset" command, rather than
> any old ref that already exists in the repository.
>
> In other words, instead of "existing branch", the manual should say
> something along the lines of "branch already in fast-import's internal
> branch table".
Looks sane.
--
Cheers,
Sverre Rabbelier
^ permalink raw reply
* Re: How often does git calculate SHAs?
From: Shawn Pearce @ 2012-01-30 14:59 UTC (permalink / raw)
To: Michael Cook; +Cc: git
In-Reply-To: <4F26A864.1080702@bbn.com>
On Mon, Jan 30, 2012 at 06:25, Michael Cook <mcook@bbn.com> wrote:
> How often does git actually calculate a file's SHA?
>
> `strace git status` shows that git stat'ed many files, but opened only a
> few. So I assume git has some heuristicsbased on the stat infofor when to
> recalculate the SHAs.
>
> Any pointers to how I could have figured this out myself from looking at the
> source code would be appreciated. Google wasn't helpful.
During `git status` Git performs an lstat() of every file in the
working tree. If the file matches stat structure data with the cache
held in .git/index, Git assumes the file is unmodified.
Things Git are looking for is usually size, mtime, inode number,
creation time, etc.
^ permalink raw reply
* How often does git calculate SHAs?
From: Michael Cook @ 2012-01-30 14:25 UTC (permalink / raw)
To: git
How often does git actually calculate a file's SHA?
`strace git status` shows that git stat'ed many files, but opened only a
few. So I assume git has some heuristicsbased on the stat infofor when
to recalculate the SHAs.
Any pointers to how I could have figured this out myself from looking at
the source code would be appreciated. Google wasn't helpful.
Michael
--
Michael Cook, Raytheon BBN Technologies, www.bbn.com
^ permalink raw reply
* [PATCH v5.5 1/5] gitweb: prepare git_get_projects_list for use outside 'forks'.
From: Bernhard R. Link @ 2012-01-30 14:55 UTC (permalink / raw)
To: Jakub Narebski; +Cc: Junio C Hamano, git
In-Reply-To: <201201301442.06707.jnareb@gmail.com>
Use of the filter option of git_get_projects_list is currently
limited to forks. It hard codes removal of ".git" suffixes from
the filter and assumes the project belonging to the filter directory
was already validated to be visible in the project list.
To make it more generic move the .git suffix removal to the callers
and add an optional argument to denote visibility verification is
still needed.
If there is a projects list file (GITWEB_LIST) only projects from
this list are returned anyway, so no more checks needed.
If there is no projects list file and the caller requests strict
checking (GITWEB_STRICT_EXPORT), do not jump directly to the
given directory but instead do a normal search and filter the
results instead.
The only (hopefully non-existing) effect of GITWEB_STRICT_EXPORT
without GITWEB_LIST is to make sure no project can be viewed without
also be found starting from project root. git_get_projects_list without
this patch does not enforce this but all callers only call it with
a filter already checked this way. With this parameter a caller
can request this check if the filter cannot be checked this way.
Signed-off-by: Bernhard R. Link <brlink@debian.org>
---
Changes since v5:
- don't you use s/.../.../r
gitweb/gitweb.perl | 13 ++++++++-----
1 files changed, 8 insertions(+), 5 deletions(-)
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 9cf7e71..19daabc 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -2829,10 +2829,9 @@ sub git_get_project_url_list {
sub git_get_projects_list {
my $filter = shift || '';
+ my $paranoid = shift;
my @list;
- $filter =~ s/\.git$//;
-
if (-d $projects_list) {
# search in directory
my $dir = $projects_list;
@@ -2841,7 +2840,7 @@ sub git_get_projects_list {
my $pfxlen = length("$dir");
my $pfxdepth = ($dir =~ tr!/!!);
# when filtering, search only given subdirectory
- if ($filter) {
+ if ($filter and not $paranoid) {
$dir .= "/$filter";
$dir =~ s!/+$!!;
}
@@ -2866,6 +2865,10 @@ sub git_get_projects_list {
}
my $path = substr($File::Find::name, $pfxlen + 1);
+ # paranoidly only filter here
+ if ($paranoid && $filter && $path !~ m!^\Q$filter\E/!) {
+ next;
+ }
# we check related file in $projectroot
if (check_export_ok("$projectroot/$path")) {
push @list, { path => $path };
@@ -6007,7 +6010,7 @@ sub git_forks {
die_error(400, "Unknown order parameter");
}
- my @list = git_get_projects_list($project);
+ my @list = git_get_projects_list((my $filter = $project) =~ s/\.git$//);
if (!@list) {
die_error(404, "No forks found");
}
@@ -6066,7 +6069,7 @@ sub git_summary {
if ($check_forks) {
# find forks of a project
- @forklist = git_get_projects_list($project);
+ @forklist = git_get_projects_list((my $filter = $project) =~ s/\.git$//);
# filter out forks of forks
@forklist = filter_forks_from_projects_list(\@forklist)
if (@forklist);
--
1.7.8.3
^ permalink raw reply related
* gitk Wish hangs on Mac OS X 10.6.8
From: Matti Linnanvuori @ 2012-01-30 13:55 UTC (permalink / raw)
To: git
Hi!
gitk Wish occasionally hangs on Mac OS X 10.6.8. I have to force kill it to make it disappear. git version 1.7.5.4.
regards, Matti Linnanvuori
^ permalink raw reply
* Re: [PATCH 2/3] completion: remove old code
From: Jonathan Nieder @ 2012-01-30 14:02 UTC (permalink / raw)
To: Felipe Contreras; +Cc: Frans Klaver, Junio C Hamano, git
In-Reply-To: <CAMP44s3vXSJaXiQK4X0kNOECzfLFsTo1YeMCtVZ0NWY-CHJ++A@mail.gmail.com>
Felipe Contreras wrote:
> Either way. I'm not going to discuss in this thread any more. I'll
> resend the patches, feel free to comment there.
Good idea. Just for the record, I'm not happy with any patch until
I've seen the code. ;-)
Thanks,
Jonathan
^ permalink raw reply
* Re: [PATCH 2/3] completion: remove old code
From: Felipe Contreras @ 2012-01-30 13:59 UTC (permalink / raw)
To: Frans Klaver; +Cc: Junio C Hamano, Jonathan Nieder, git
In-Reply-To: <CAH6sp9PfVTTNL218syf-MS465M+sP4E8eVxuVCHZC0geE3ezfg@mail.gmail.com>
On Mon, Jan 30, 2012 at 2:21 PM, Frans Klaver <fransklaver@gmail.com> wrote:
> On Mon, Jan 30, 2012 at 12:55 PM, Felipe Contreras
> <felipe.contreras@gmail.com> wrote:
>
>> We are not talking about backwards compatibility; we are talking about
>> compatibility of remotes completion of the bash completion script of
>> repositories more than 3 years old with remotes that haven't been
>> migrated.
>
> What's not backward about that?
Not all backwards compatibility issues are the same.
>> This barely resembles the git-foo -> 'git foo', which truly broke
>> backwards compatibility, and at the time I proposed many different
>> approaches to deal with these type of problems, which seem to be
>> followed now (although probably not because of my recommendations).
>>
>> But this has nothing to do with _attitude_; I am merely stating fact.
>> I have never expressed any opinion or attitude with respect to how
>> backwards compatibility should be handled in this thread, have I?
>
> As far as I know you haven't explicitly said anything about that.
> There may still be a possibility that the sentence Junio quoted in his
> reply could have implied a certain attitude.
I already asked, but I ask again; what would be that attitude? Not
caring about backwards compatibility? Then that implication would have
been wrong.
If you look a few lines below, you would see a change that doesn't
break backwards compatibility, which proves the previous implication
wrong... Not to mention previous discussions.
>>> Maybe numbers for this could be generated from the next git user
>>> survey. If numbers justify this change, maybe this or something like
>>> it could be scheduled for a major release of git.
>>
>> Maybe, but I doubt this issue hardly deserves much discussion.
>
> I wouldn't know about that. Apparently not everybody is happy with
> applying it without further discussion.
Jonathan Nieder is happy with the 'ls -1 "$d/remotes"' change, and I
haven't seen anybody object it.
Either way. I'm not going to discuss in this thread any more. I'll
resend the patches, feel free to comment there.
--
Felipe Contreras
^ permalink raw reply
* Re: [PATCH 3/3] completion: remove unused code
From: Felipe Contreras @ 2012-01-30 13:51 UTC (permalink / raw)
To: Thomas Rast; +Cc: Junio C Hamano, Jonathan Nieder, git
In-Reply-To: <87pqe1nx9a.fsf@thomas.inf.ethz.ch>
On Mon, Jan 30, 2012 at 3:19 PM, Thomas Rast <trast@inf.ethz.ch> wrote:
> Felipe Contreras <felipe.contreras@gmail.com> writes:
>
>> On Mon, Jan 30, 2012 at 10:22 AM, Junio C Hamano <jch2355@gmail.com> wrote:
>>> Thomas Rast <trast@inf.ethz.ch> wrote:
>>>>Felipe Contreras <felipe.contreras@gmail.com> writes:
>>>>
>>>>> No reason. I hope they read the mailing list, otherwise I'll resend
>>>>> and CC them. A get_maintainers script, or something like that would
>>>>> make things easier.
>>>>
>>>>I simply use
>>>>
>>>> git shortlog -sn --no-merges v1.7.0.. -- contrib/completion/
>>>>
>>>>(In many parts the revision limiter can be omitted without losing much,
>>>>but e.g. here this drops Shawn who hasn't worked on it since 2009.)
>>>
>>> Or "--since=1.year", which you can keep using forever without adjusting.
>>
>> Perhaps something like that can be stored in a script somewhere in
>> git's codebase so that people can set sendemail.cccmd to that.
>
> Umm, that seems rather AI-complete. You should always compile the list
> by hand.
Why? Take a look at the Linux kernel; having tons of contributors,
many still haven't learned the ropes, and looking at MAINTAIERS, plus
the output of 'git blame', for potentially dozens of patches is too
burdensome, which is why they have 'scripts/get_maintainer.pl' that
does a pretty good job of figuring out who to cc so you don't have to
think about it.
> Ok, this got rather long-winded. But I think the bottom line is, trying
> to put this in sendemail.cccmd is trying to script common sense.
It's still better than nothing.
I once wrote a much smarter script[1], but it never go into the tree.
The output I get is this:
"Shawn O. Pearce" <spearce@spearce.org>>
"Jonathan Nieder" <jrnieder@gmail.com>
"Mark Lodato" <lodatom@gmail.com>
"Junio C Hamano" <junkio@cox.net>
"Ted Pavlic" <ted@tedpavlic.com>
Note: seems like there's a bug with git blame -P:
% g blame -p -L 2730,+33 contrib/completion/git-completion.bash | grep
author-mail
And if this script is such a bad idea; why do you think sendmail.cccmd exists?
I think we should have a simple script that at least does something
sensible, at least in contrib, but I hope we could even have a
standard git-cccmd that all projects could use.
It looks like my ruby script never had much of a chance getting
anywhere, so would it be accepted in another format? perl? python?
bash?
Cheers.
[1] http://thread.gmane.org/gmane.comp.version-control.git/130391
--
Felipe Contreras
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox