From: dag@cray.com (David A. Greene)
To: Junio C Hamano <gitster@pobox.com>
Cc: greened@obbligato.org, git@vger.kernel.org
Subject: Re: [PATCH 1/2] Allow Overriding GIT_BUILD_DIR
Date: Mon, 05 Mar 2012 12:10:41 -0600 [thread overview]
Message-ID: <nng399m3om6.fsf@transit.us.cray.com> (raw)
In-Reply-To: <7vaa3v4kwo.fsf@alter.siamese.dyndns.org> (Junio C. Hamano's message of "Sun, 04 Mar 2012 22:33:11 -0800")
Junio C Hamano <gitster@pobox.com> writes:
> Both of your changes seem to have broken indentation to use 8-SP at
> the beginning of some (but not all) lines instead 1-HT. I'll queue
> a fixed up version and push the result out in 'pu' later, so please
> double check to make sure I didn't screw up.
Right. This is because you flagged an indentation issue with the
previous version of the patch. I think what happened is that the
previous version included the 1-HT (what is HT - half-tab?) spacing but
it "looked funny" with the additional "+" from the diff line.
So in some way this was deliberate to make the patch look better. I
have no problem with you (or me!) changing it back.
Thanks for taking these up!
-Dave
next prev parent reply other threads:[~2012-03-05 18:11 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-04 23:23 [PATCH 1/2] Allow Overriding GIT_BUILD_DIR greened
2012-03-04 23:23 ` [PATCH 2/2] Support Out-Of-Tree Valgrind Tests greened
2012-03-05 7:53 ` Thomas Rast
2012-03-05 18:11 ` David A. Greene
2012-03-06 8:46 ` Thomas Rast
2012-03-06 14:40 ` David A. Greene
2012-03-06 18:49 ` Junio C Hamano
2012-03-06 22:12 ` David A. Greene
2012-03-06 22:21 ` Junio C Hamano
2012-03-06 22:37 ` Junio C Hamano
2012-03-06 23:00 ` David A. Greene
2012-03-06 23:12 ` Junio C Hamano
2012-03-06 22:54 ` David A. Greene
2012-03-06 18:43 ` Junio C Hamano
2012-03-05 6:33 ` [PATCH 1/2] Allow Overriding GIT_BUILD_DIR Junio C Hamano
2012-03-05 18:10 ` David A. Greene [this message]
2012-03-05 20:08 ` Junio C Hamano
2012-03-06 14:21 ` David A. Greene
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nng399m3om6.fsf@transit.us.cray.com \
--to=dag@cray.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=greened@obbligato.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).