git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: nisse@lysator.liu.se (Niels Möller)
To: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
Cc: git@vger.kernel.org
Subject: Re: Wishlist: git commit --no-edit
Date: Fri, 02 Nov 2012 11:07:45 +0100	[thread overview]
Message-ID: <nnpq3wiaha.fsf@stalhein.lysator.liu.se> (raw)
In-Reply-To: <vpqfw4sgx33.fsf@grenoble-inp.fr> (Matthieu Moy's message of "Fri, 02 Nov 2012 10:42:24 +0100")

Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:

> Err, isn't this already working? (maybe your version of Git is too old,
> but my 1.7.9.5 does this at least)

It may be that I'm confused.

It doesn't work in the version I have (1.7.2.5, debian packaged).

And then I also had a quick look in the source code (of a fresh pull
from https://github.com/git/git.git). In builtin/commit.c, I didn't see
any no-edit flag (but I maybe it's in the OPT_BOOL magic (which is
different from OPT_BOOLEAN?)).

And it's also not mentioned in Documentation/git-commit.txt or on
http://kernel.org/pub/software/scm/git/docs/git-commit.html.

If commit --no-edit does work in recent versions, then all is fine,
except possibly the documentation of it. Thanks.

Regards,
/Niels

-- 
Niels Möller. PGP-encrypted email is preferred. Keyid C0B98E26.
Internet email is subject to wholesale government surveillance.

  parent reply	other threads:[~2012-11-02 10:08 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-02  9:26 Wishlist: git commit --no-edit Niels Möller
2012-11-02  9:42 ` Matthieu Moy
2012-11-02  9:59   ` Jeff King
     [not found]     ` <CACnwZYe-za3Q0qvkfQ=qatB1-8eLUFA6ZzfS41yeqrV=8rVzGA@mail.gmail.com>
2012-11-02 12:45       ` Jeff King
2012-11-02 10:07   ` Niels Möller [this message]
2012-11-02 10:39     ` [PATCH] Document 'git commit --no-edit' explicitly Matthieu Moy
2012-11-02 11:24       ` Niels Möller
2012-11-02 11:29         ` Matthieu Moy
2012-11-02 11:53       ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=nnpq3wiaha.fsf@stalhein.lysator.liu.se \
    --to=nisse@lysator.liu.se \
    --cc=Matthieu.Moy@grenoble-inp.fr \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).