git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Matthias Andree" <matthias.andree@gmx.de>
To: git@vger.kernel.org, users@subversion.tigris.org
Subject: git-svn dcommits messages not in UTF-8 charset to mod_dav_svn?
Date: Wed, 27 May 2009 18:16:24 +0200	[thread overview]
Message-ID: <op.uuljhmmg1e62zd@balu.cs.uni-paderborn.de> (raw)

Greetings,

I had tried to use git cvsimport and git svn to transfer a CVS repository  
(I have access to it) to an SVN repository (where I don't have access to  
the repo, so I cannot use cvs2svn or similar).

The problem is that the CVS repo had non-UTF-8 commit log messages, and I  
didn't bother to convert them to UTF-8. However, SVN insists on encoding  
filenames and log messages in UTF-8.

"git svn dcommit" (which uses the SVN Perl bindings under the hood)  
happily committed such a non-UTF-8 message and br0ke the repo. The actual  
reason is that the SVN server (https://...) is now wedged, as in:

$ svn log -r130
svn: REPORT of '/repos/!svn/bc/130': 200 OK (https://svn-serv...de)

$ svn --xml log -r130  2>/dev/null
[stdout:]
<?xml version="1.0"?>
<log>
[stderr:]
svn: REPORT of '/repos/!svn/bc/130': 200 OK (https://svn-serv...de)

$ svn propget --revprop svn:log -r130 https://svn-serv...de/path/
aktuelle version (disclaimer)
kopf und fu?\223zeilen
etc.


While mod_dav_svn arguably shouldn't accept b0rked messages, git-svn  
shouldn't attempt to commit them either. It seems that the svn command  
line utilities validate the message format by themselves, and apparently  
the svn server module (likely mod_dav_svn - or are there others?) does not.

So, could
a) git-svn be modified to refuse dcommiting non-UTF-8 messages?
b) mod_dav_svn be modified to refuse commits/propedits/propsets with  
non-UTF-8 messages?

I'm sorry to say I don't have information how the SVN server is configured  
and which version it's running.

Thanks.

-- 
Matthias Andree

             reply	other threads:[~2009-05-27 16:16 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-27 16:16 Matthias Andree [this message]
2009-05-28  8:08 ` git-svn dcommits messages not in UTF-8 charset to mod_dav_svn? Eric Wong
2009-05-28  8:18   ` [PATCH] git-svn: refuse to dcommit non-UTF-8 messages Eric Wong
2009-05-29  7:09     ` Junio C Hamano
2009-05-29  7:56     ` Junio C Hamano
2009-05-29 14:11       ` Brandon Casey
2009-05-30  0:14         ` [PATCH] t9139 uses ancient, backwards-compatible iconv names Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=op.uuljhmmg1e62zd@balu.cs.uni-paderborn.de \
    --to=matthias.andree@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=users@subversion.tigris.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).