From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Frans Klaver" Subject: git-svn: t9155 fails against subversion 1.7.0 Date: Tue, 08 Nov 2011 23:09:30 +0100 Message-ID: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit To: "git@vger.kernel.org" X-From: git-owner@vger.kernel.org Tue Nov 08 23:09:41 2011 Return-path: Envelope-to: gcvg-git-2@lo.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1RNtrQ-0006s3-Jj for gcvg-git-2@lo.gmane.org; Tue, 08 Nov 2011 23:09:40 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752866Ab1KHWJf (ORCPT ); Tue, 8 Nov 2011 17:09:35 -0500 Received: from mail-ey0-f174.google.com ([209.85.215.174]:60207 "EHLO mail-ey0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752546Ab1KHWJe (ORCPT ); Tue, 8 Nov 2011 17:09:34 -0500 Received: by eye27 with SMTP id 27so881883eye.19 for ; Tue, 08 Nov 2011 14:09:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=content-type:to:date:subject:mime-version:content-transfer-encoding :from:message-id:user-agent; bh=vHDYtICxuKU1IPBWZoJBpft8v/BPO5t9tYgZhZ1USUg=; b=LuNuB0rD/5g537toVhsli2RIQMCrMg9yA7nsRVQ8T4PYWK1tobhFb5o1mYYn0wQJG7 wqgun6ukqjSVkcD6SA6z+ZU11hRLLYjKdMfwoECiSokQmDV3l1a3f5iRRKO6NlyxQPlA GYdkwUftqflhkot9XQruvfKkynTSFpebMUYSo= Received: by 10.213.102.9 with SMTP id e9mr2798136ebo.77.1320790173481; Tue, 08 Nov 2011 14:09:33 -0800 (PST) Received: from keputer (82-136-253-149.ip.telfort.nl. [82.136.253.149]) by mx.google.com with ESMTPS id q28sm7768277eea.6.2011.11.08.14.09.32 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 08 Nov 2011 14:09:32 -0800 (PST) User-Agent: Opera Mail/12.00 (Linux) Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: For kicks I decided to run the tests and noticed that on master t9155-git-svn-fetch-deleted-tag fails against svn 1.7.0. We hit an assertion in subversion's dirent_uri.c, stating that we don't provide a canonical url. I haven't tested against other subversion versions. I dare assume that this issue doesn't arise on earlier versions. It probably won't affect a lot of users right now, but it will in the future. Here's some verbose test output: expecting success: git svn init --stdlayout "$svnrepo" git_project && cd git_project && git svn fetch && git diff --exit-code mybranch:trunk/subdir/file tags/mytag:file && git diff --exit-code master:subdir/file tags/mytag^:file Initialized empty Git repository in /home/frans/devsw/git/t/trash directory.t9155-git-svn-fetch-deleted-tag/git_project/.git/ svn: E235000: In file 'subversion/libsvn_subr/dirent_uri.c' line 2291: assertion failed (svn_uri_is_canonical(url, pool)) error: git-svn died of signal 6 not ok - 2 fetch deleted tags from same revision with checksum error I've been trying to debug and got down to: Git::SVN::Ra::new(/home/frans/devsw/git/git-svn:5496): 5496: my $self = SVN::Ra->new(url => escape_url($url), auth => $baton, 5497: config => $config, 5498: pool => SVN::Pool->new, 5499: auth_provider_callbacks => $callbacks); ... SVN::Ra::new(/usr/lib/perl5/vendor_perl/5.12.4/i686-linux/SVN/Ra.pm:529): 529: $self->{session} = SVN::_Ra::svn_ra_open($self->{url}, $callback, $self->{config} || {}, $pool); DB<3> p $self->{url} file:///home/frans/devsw/git/t/trash directory.t9155-git-svn-fetch-deleted-tag/svnrepo The url looks like that throughout the stack (as far as I've seen), so if it is wrong, it is probably wrong at top-level. Hope someone with a bit more experience knows how to deal with this. Thanks, Frans