git-svn: t9155 fails against subversion 1.7.0

git-svn: t9155 fails against subversion 1.7.0

[Frans Klaver]

For kicks I decided to run the tests and noticed that on master  
t9155-git-svn-fetch-deleted-tag fails against svn 1.7.0. We hit an  
assertion in subversion's dirent_uri.c, stating that we don't provide a  
canonical url. I haven't tested against other subversion versions. I dare  
assume that this issue doesn't arise on earlier versions. It probably  
won't affect a lot of users right now, but it will in the future.

Here's some verbose test output:
expecting success:
	git svn init --stdlayout "$svnrepo" git_project &&
	cd git_project &&
	git svn fetch &&

	git diff --exit-code mybranch:trunk/subdir/file tags/mytag:file &&
	git diff --exit-code master:subdir/file tags/mytag^:file

Initialized empty Git repository in /home/frans/devsw/git/t/trash  
directory.t9155-git-svn-fetch-deleted-tag/git_project/.git/
svn: E235000: In file 'subversion/libsvn_subr/dirent_uri.c' line 2291:  
assertion failed (svn_uri_is_canonical(url, pool))
error: git-svn died of signal 6
not ok - 2 fetch deleted tags from same revision with checksum error

I've been trying to debug and got down to:
Git::SVN::Ra::new(/home/frans/devsw/git/git-svn:5496):
5496:		my $self = SVN::Ra->new(url => escape_url($url), auth => $baton,
5497:		                      config => $config,
5498:				      pool => SVN::Pool->new,
5499:		                      auth_provider_callbacks => $callbacks);
...
SVN::Ra::new(/usr/lib/perl5/vendor_perl/5.12.4/i686-linux/SVN/Ra.pm:529):
529:	    $self->{session} = SVN::_Ra::svn_ra_open($self->{url}, $callback,  
$self->{config} || {}, $pool);
   DB<3> p $self->{url}
file:///home/frans/devsw/git/t/trash  
directory.t9155-git-svn-fetch-deleted-tag/svnrepo

The url looks like that throughout the stack (as far as I've seen), so if  
it is wrong, it is probably wrong at top-level. Hope someone with a bit  
more experience knows how to deal with this.

Thanks,
Frans

Re: git-svn: t9155 fails against subversion 1.7.0

[Frans Klaver]

I missed $gmane/184644 in my search for this issue.


On Tue, 08 Nov 2011 23:09:30 +0100, Frans Klaver <fransklaver@gmail.com>  
wrote:

> For kicks I decided to run the tests and noticed that on master  
> t9155-git-svn-fetch-deleted-tag fails against svn 1.7.0. We hit an  
> assertion in subversion's dirent_uri.c, stating that we don't provide a  
> canonical url. I haven't tested against other subversion versions. I  
> dare assume that this issue doesn't arise on earlier versions. It  
> probably won't affect a lot of users right now, but it will in the  
> future.
>
> Here's some verbose test output:
> expecting success:
> 	git svn init --stdlayout "$svnrepo" git_project &&
> 	cd git_project &&
> 	git svn fetch &&
>
> 	git diff --exit-code mybranch:trunk/subdir/file tags/mytag:file &&
> 	git diff --exit-code master:subdir/file tags/mytag^:file
>
> Initialized empty Git repository in /home/frans/devsw/git/t/trash  
> directory.t9155-git-svn-fetch-deleted-tag/git_project/.git/
> svn: E235000: In file 'subversion/libsvn_subr/dirent_uri.c' line 2291:  
> assertion failed (svn_uri_is_canonical(url, pool))
> error: git-svn died of signal 6
> not ok - 2 fetch deleted tags from same revision with checksum error
>
> I've been trying to debug and got down to:
> Git::SVN::Ra::new(/home/frans/devsw/git/git-svn:5496):
> 5496:		my $self = SVN::Ra->new(url => escape_url($url), auth => $baton,
> 5497:		                      config => $config,
> 5498:				      pool => SVN::Pool->new,
> 5499:		                      auth_provider_callbacks => $callbacks);
> ...
> SVN::Ra::new(/usr/lib/perl5/vendor_perl/5.12.4/i686-linux/SVN/Ra.pm:529):
> 529:	    $self->{session} = SVN::_Ra::svn_ra_open($self->{url},  
> $callback, $self->{config} || {}, $pool);
>    DB<3> p $self->{url}
> file:///home/frans/devsw/git/t/trash  
> directory.t9155-git-svn-fetch-deleted-tag/svnrepo
>
> The url looks like that throughout the stack (as far as I've seen), so  
> if it is wrong, it is probably wrong at top-level. Hope someone with a  
> bit more experience knows how to deal with this.
>
> Thanks,
> Frans


-- 
Using Opera's revolutionary e-mail client: http://www.opera.com/mail/

Re: git-svn: t9155 fails against subversion 1.7.0

[Robin H. Johnson]

On Thu, Nov 10, 2011 at 07:02:13AM +0100,  Frans Klaver wrote:
> I missed $gmane/184644 in my search for this issue.
Did you make any progress in fixing this?

> On Tue, 08 Nov 2011 23:09:30 +0100, Frans Klaver <fransklaver@gmail.com>  
> wrote:
> 
> > For kicks I decided to run the tests and noticed that on master  
> > t9155-git-svn-fetch-deleted-tag fails against svn 1.7.0. We hit an  
> > assertion in subversion's dirent_uri.c, stating that we don't provide a  
> > canonical url. I haven't tested against other subversion versions. I  
> > dare assume that this issue doesn't arise on earlier versions. It  
> > probably won't affect a lot of users right now, but it will in the  
> > future.

-- 
Robin Hugh Johnson
Gentoo Linux: Developer, Trustee & Infrastructure Lead
E-Mail     : robbat2@gentoo.org
GnuPG FP   : 11ACBA4F 4778E3F6 E4EDF38E B27B944E 34884E85

Re: git-svn: t9155 fails against subversion 1.7.0

[Frans Klaver]

Hi Robin,

On Sun, Feb 5, 2012 at 10:25 PM, Robin H. Johnson <robbat2@gentoo.org> wrote:
> On Thu, Nov 10, 2011 at 07:02:13AM +0100,  Frans Klaver wrote:
>> I missed $gmane/184644 in my search for this issue.
> Did you make any progress in fixing this?

I haven't invested time in this, and the tests still seem to fail on
subversion 1.7.x. Maybe one of the people involved in $gmane/184644
knows more?

Cheers,
Frans

Re: git-svn: t9155 fails against subversion 1.7.0

[Eric Wong]

Frans Klaver <fransklaver@gmail.com> wrote:
> I haven't invested time in this, and the tests still seem to fail on
> subversion 1.7.x. Maybe one of the people involved in $gmane/184644
> knows more?

Not me.  I haven't had time/interest in dealing with SVN in a while.

I've always hoped somebody else has the time+interest for git-svn, but
given the self-obsoleting nature of git-svn, it's hard to find
motivation.

Re: git-svn: t9155 fails against subversion 1.7.0

[Jonathan Nieder]

Ben Walton wrote:

> This is still on my todo list as I'd like to have a working bridge
> (and to be able to run the svn test suite when packaging for
> solaris).  I've not had the required time to dig into this once it
> proved to be non-trivial breakage though.

Thanks.  Just a quick update: I can confirm that

 - Something like your original patch will probably take care of this,
   once a few residual svn bugs are ironed out.

 - Unfortunately, there are a few residual svn bugs, such as
   <http://subversion.tigris.org/issues/show_bug.cgi?id=4091>.

 - The svn developers are very helpful.  Hopefully among us we should
   eventually make progress, given enough time. ;-)

Ah, but time is hard to find here, too...

Proposal: I'm willing to maintain drafts of a patch to fix the test
breakage.  Send me patches and I'll blindly apply them to a dedicated
branch in a repo on repo.or.cz, so small improvements are easier to
make.  (Or if someone else wants to take care of the same, I'd be even
happier.)  Once it's working, we can send the result in some more
logical form to the list for application to mainline.

Ciao,
Jonathan