From: "Frans Klaver" <fransklaver@gmail.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: "git@vger.kernel.org" <git@vger.kernel.org>,
"Junio C Hamano" <gitster@pobox.com>
Subject: Re: Compile warnings
Date: Mon, 14 Nov 2011 22:55:24 +0100 [thread overview]
Message-ID: <op.v4yhummo0aolir@keputer> (raw)
In-Reply-To: <CACBZZX6d_ykc9CbN7H-ACWNUxACb9+TH4ffJ-+9T=SEv6Ai0Ug@mail.gmail.com>
On Mon, 14 Nov 2011 17:58:20 +0100, Ævar Arnfjörð Bjarmason
<avarab@gmail.com> wrote:
> On Mon, Nov 14, 2011 at 15:55, Frans Klaver <fransklaver@gmail.com>
> wrote:
>> Every now and then I see an 'unused result' warning come by during
>> building.
>> What is the general attitude towards these warnings? Remove them (by
>> properly checking)? Or leave them be as a kind of documentation -- we
>> know
>> we're ignoring the info, but it's good to be reminded?
>
> Under what OS / version and compiler / version and what's the warning?
> Paste the full warning(s) you get verbatim.
This question was triggered by
warning: ignoring return value of ‘fwrite’, declared with attribute
warn_unused_result
appearing in diff.c, graph.c, grep.c and several others. I'm using gentoo
linux, gcc 4.5.3.
So the specific question would be, do these fwrites need to be checked?
next prev parent reply other threads:[~2011-11-14 21:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-14 14:55 Compile warnings Frans Klaver
2011-11-14 16:58 ` Ævar Arnfjörð Bjarmason
2011-11-14 21:55 ` Frans Klaver [this message]
2011-11-14 20:36 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=op.v4yhummo0aolir@keputer \
--to=fransklaver@gmail.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).