git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Frans Klaver" <fransklaver@gmail.com>
To: "Holger Hellmuth" <hellmuth@ira.uka.de>
Cc: "Andrew Ardill" <andrew.ardill@gmail.com>,
	"Jakub Narebski" <jnareb@gmail.com>,
	"Sidney San Martín" <s@sidneysm.com>,
	git@vger.kernel.org
Subject: Re: Question about commit message wrapping
Date: Mon, 12 Dec 2011 23:16:49 +0100	[thread overview]
Message-ID: <op.v6edibfz0aolir@keputer> (raw)
In-Reply-To: <4EE62DB9.8030406@ira.uka.de>

On Mon, 12 Dec 2011 17:37:13 +0100, Holger Hellmuth <hellmuth@ira.uka.de>  
wrote:

>> I am starting to think that we need to somehow keep the current
>> behavior, but override at smaller widths. Maybe even use format=flowed
>> in format-patch.
>
> Could you explain what overriding at smaller widths would achieve?  
> Supporting format=flowed would be nice though.

I specifically meant trying to detect pre-wrapped text, removing the  
new-lines where we think it is because of wrapping at 80 characters. So  
the result would be: perfect on screens up to 80 characters wide, and ok  
on anything wider.

The implementation of that however could affect code in the mail if it  
isn't done properly.

>
>> On the other hand, the fundamental use with git is to
>> communicate code, and I'm not sure how that [cw]ould be handled.
>
> I prefer wrapped code to code that is cut of at a specific column.  
> Wrapped code has much less possibility for misinterpretation. Python  
> programmers might disagree?

Wrapped code as in auto-wrapped? Or as in manually wrapped? Python  
programmers have significant white space, but you can still hard wrap  
stuff, as long as the next statement is properly indented.

>
> I see your proposal mainly as an improvement to the display of texts,  
> not code.

Me too.


-- 
Using Opera's revolutionary e-mail client: http://www.opera.com/mail/

  reply	other threads:[~2011-12-12 22:16 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-09  1:59 Question about commit message wrapping Sidney San Martín
2011-12-09  7:05 ` Frans Klaver
2011-12-09  7:51   ` Frans Klaver
2011-12-09 14:10   ` Sidney San Martín
2011-12-09 16:49     ` Frans Klaver
2011-12-09 17:49       ` Sidney San Martín
2011-12-10  9:10     ` Andreas Schwab
2011-12-09 13:41 ` Jakub Narebski
2011-12-09 17:50   ` Sidney San Martín
2011-12-10 19:30     ` Jakub Narebski
2011-12-11 22:00       ` Andrew Ardill
2011-12-12  8:41         ` Frans Klaver
2011-12-12 16:37           ` Holger Hellmuth
2011-12-12 22:16             ` Frans Klaver [this message]
2011-12-13  3:14               ` Michael Haggerty
2011-12-13  6:16                 ` Frans Klaver
2011-12-13 13:14                 ` Holger Hellmuth
2011-12-14 21:04                 ` Sidney San Martín
2012-01-01 16:03                   ` Drew Northup
2012-01-26  1:50                     ` Sidney San Martín
2011-12-14 21:07       ` Sidney San Martín

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=op.v6edibfz0aolir@keputer \
    --to=fransklaver@gmail.com \
    --cc=andrew.ardill@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=hellmuth@ira.uka.de \
    --cc=jnareb@gmail.com \
    --cc=s@sidneysm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).