git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Frans Klaver" <fransklaver@gmail.com>
To: "Michael Haggerty" <mhagger@alum.mit.edu>
Cc: "Holger Hellmuth" <hellmuth@ira.uka.de>,
	"Andrew Ardill" <andrew.ardill@gmail.com>,
	"Jakub Narebski" <jnareb@gmail.com>,
	"Sidney San Martín" <s@sidneysm.com>,
	git@vger.kernel.org
Subject: Re: Question about commit message wrapping
Date: Tue, 13 Dec 2011 07:16:21 +0100	[thread overview]
Message-ID: <op.v6ezpjj90aolir@keputer> (raw)
In-Reply-To: <4EE6C31C.60909@alum.mit.edu>

On Tue, 13 Dec 2011 04:14:36 +0100, Michael Haggerty  
<mhagger@alum.mit.edu> wrote:

> On 12/12/2011 11:16 PM, Frans Klaver wrote:
>> Wrapped code as in auto-wrapped? Or as in manually wrapped? Python
>> programmers have significant white space, but you can still hard wrap
>> stuff, as long as the next statement is properly indented.
>
> This is incorrect.  Python statements can only be broken across lines
> within unbalanced parenthesis (or using '\' or within a multiline
> string).  For example,
>
>     x =
>         1
>
> is a syntax error, while
>
>     y = (
>         1
>         )
>
> or
>
>     f(1,
>           2,
>       3,
>       4)
>
> are both valid.

Hm yes, my statement was quite incomplete. What you describe here is what  
I meant, and I should have taken the time to word it down properly. Thanks  
for taking the time to do so.



>
> FWIW I think automatic wrapping of commit messages is a bad idea.  I
> wrap my commit messages deliberately to make them look the way I want
> them to look.  The assumption of an 80-character display has historical
> reasons, but it is also a relatively comfortable line-width to read
> (even on wider displays).  And given that commit messages sometimes
> contain "flowable" paragraph text, sometimes code snippets, sometimes
> ASCII art, etc, no automatic wrapping will work correctly unless
> everybody agrees that commit messages must be written in some specific
> form of markup (or lightweight markup).  And I can't imagine such a
> thing ever happening.
>
> As for "future-proofing", do you really think there will be a lot of
> programming happening on mobile phones with less than 80-character-wide
> displays?  (And even my little HTC can easily fit 80 characters if I
> rotate the phone to "landscape" mode.)

Makes sense.

  reply	other threads:[~2011-12-13  6:16 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-09  1:59 Question about commit message wrapping Sidney San Martín
2011-12-09  7:05 ` Frans Klaver
2011-12-09  7:51   ` Frans Klaver
2011-12-09 14:10   ` Sidney San Martín
2011-12-09 16:49     ` Frans Klaver
2011-12-09 17:49       ` Sidney San Martín
2011-12-10  9:10     ` Andreas Schwab
2011-12-09 13:41 ` Jakub Narebski
2011-12-09 17:50   ` Sidney San Martín
2011-12-10 19:30     ` Jakub Narebski
2011-12-11 22:00       ` Andrew Ardill
2011-12-12  8:41         ` Frans Klaver
2011-12-12 16:37           ` Holger Hellmuth
2011-12-12 22:16             ` Frans Klaver
2011-12-13  3:14               ` Michael Haggerty
2011-12-13  6:16                 ` Frans Klaver [this message]
2011-12-13 13:14                 ` Holger Hellmuth
2011-12-14 21:04                 ` Sidney San Martín
2012-01-01 16:03                   ` Drew Northup
2012-01-26  1:50                     ` Sidney San Martín
2011-12-14 21:07       ` Sidney San Martín

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=op.v6ezpjj90aolir@keputer \
    --to=fransklaver@gmail.com \
    --cc=andrew.ardill@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=hellmuth@ira.uka.de \
    --cc=jnareb@gmail.com \
    --cc=mhagger@alum.mit.edu \
    --cc=s@sidneysm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).