From: "Frans Klaver" <fransklaver@gmail.com>
To: "Junio C Hamano" <gitster@pobox.com>,
"Frans Klaver" <fransklaver@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/2] run-command: Add checks after execvp fails with EACCES
Date: Wed, 14 Dec 2011 23:06:22 +0100 [thread overview]
Message-ID: <op.v6h2cwuw0aolir@keputer.lokaal> (raw)
In-Reply-To: <CAH6sp9Mf=EjkVN9mDN59ZCxCU0sCFLa8E=7YxM1J8LCCMr=xYQ@mail.gmail.com>
On Wed, 14 Dec 2011 15:31:25 +0100, Frans Klaver <fransklaver@gmail.com>
wrote:
> Since fopen() uses the effective uid/gid, it then makes sense to use
> eaccess(3) instead of access(2) if available. It would be stupid to
> have bugs arise just because of a mismatch between the [ug]ids used by
> the two access checks. I'm aware of the fact that eaccess isn't a
> standard function, so a #define HAVE... fallback to at least access()
> would probably be required.
Just to be clear, I don't really want to restart the discussion of which
uid to use, but it is something to consider now or in the future. The next
roll will use access(2) as far as I'm concerned.
next prev parent reply other threads:[~2011-12-14 22:06 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-21 21:53 [PATCH] run-command.c: Accept EACCES as command not found Frans Klaver
2011-11-21 22:13 ` Junio C Hamano
2011-11-21 23:06 ` Frans Klaver
2011-11-21 23:54 ` Junio C Hamano
2011-11-22 9:31 ` Frans Klaver
2011-11-23 8:17 ` Frans Klaver
2011-11-23 12:04 ` Nguyen Thai Ngoc Duy
2011-11-23 13:25 ` Frans Klaver
2011-11-23 22:55 ` Frans Klaver
2011-12-06 21:38 ` [PATCH 0/2] run-command: Add EACCES diagnostics Frans Klaver
2011-12-06 21:38 ` [PATCH 1/2] run-command: Add checks after execvp fails with EACCES Frans Klaver
2011-12-06 22:35 ` Junio C Hamano
2011-12-07 8:31 ` Frans Klaver
2011-12-08 21:44 ` Frans Klaver
2011-12-09 17:23 ` Junio C Hamano
2011-12-09 21:35 ` Frans Klaver
2011-12-06 21:38 ` [PATCH 2/2] run-command: Add interpreter permissions check Frans Klaver
2011-12-06 22:47 ` Junio C Hamano
2011-12-07 8:37 ` Frans Klaver
2011-12-13 15:08 ` [PATCH 0/2 v2] run-command: Add eacces diagnostics Frans Klaver
2011-12-13 15:08 ` [PATCH 1/2] run-command: Add checks after execvp fails with EACCES Frans Klaver
2011-12-13 19:01 ` Junio C Hamano
2011-12-14 14:31 ` Frans Klaver
2011-12-14 22:06 ` Frans Klaver [this message]
2011-12-13 15:08 ` [PATCH 2/2] run-command: Add interpreter permissions check Frans Klaver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=op.v6h2cwuw0aolir@keputer.lokaal \
--to=fransklaver@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).