From: "Frans Klaver" <fransklaver@gmail.com>
To: "Jeff King" <peff@peff.net>
Cc: "Jonathan Nieder" <jrnieder@gmail.com>,
"Junio C Hamano" <gitster@pobox.com>,
"James Pickens" <jepicken@gmail.com>,
"Git ML" <git@vger.kernel.org>
Subject: Re: [PATCH 2/2] git: continue alias lookup on EACCES errors
Date: Thu, 29 Mar 2012 19:23:12 +0200 [thread overview]
Message-ID: <op.wbxzwyre0aolir@keputer> (raw)
In-Reply-To: <20120329172033.GC12318@sigill.intra.peff.net>
On Thu, 29 Mar 2012 19:20:33 +0200, Jeff King <peff@peff.net> wrote:
> On Thu, Mar 29, 2012 at 01:31:09PM +0200, Frans Klaver wrote:
>
>> On Wed, Mar 28, 2012 at 11:57 PM, Jeff King <peff@peff.net> wrote:
>>
>> > +static int exists_in_PATH(const char *file)
>> [...]
>>
>> I expect that if more post-mortem checking is done, this function is
>> going to need a sibling that provides you with the first found entry
>> in PATH, so you can do more checks on it.
>
> It should be easy to write it that way. I'm not personally planning on
> adding more checks, but I think it's worth considering future additions.
I have some similar code lying around. It shouldn't be too hard to rebase
that on top of this.
>> One of the things I ran into while working on [1] is that quite some
>> errors that are produced can also be caused by the interpreter.
>
> Yeah, they can be confusing and hard to track down. I'll leave that
> topic out of this round, and you can build on it if you like.
I was planning to do that, yea.
next prev parent reply other threads:[~2012-03-29 17:23 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-26 23:48 Bug? Bad permissions in $PATH breaks Git aliases James Pickens
2012-03-27 3:19 ` Jeff King
2012-03-27 7:25 ` James Pickens
2012-03-27 15:11 ` Junio C Hamano
2012-03-27 17:59 ` Jeff King
2012-03-27 18:04 ` [PATCH 1/2] run-command: propagate EACCES errors to parent Jeff King
2012-03-27 18:24 ` Junio C Hamano
2012-03-27 18:33 ` Jeff King
2012-03-27 18:05 ` [PATCH 2/2] git: continue alias lookup on EACCES errors Jeff King
2012-03-27 19:16 ` Junio C Hamano
2012-03-28 4:30 ` Jeff King
2012-03-28 17:42 ` Junio C Hamano
2012-03-28 17:48 ` Jeff King
2012-03-28 18:04 ` Jonathan Nieder
2012-03-28 18:31 ` Junio C Hamano
2012-03-28 18:40 ` Jonathan Nieder
2012-03-28 19:39 ` Jeff King
2012-03-28 19:45 ` Jonathan Nieder
2012-03-28 20:18 ` Jeff King
2012-03-28 20:37 ` Jeff King
2012-03-28 20:51 ` Jonathan Nieder
2012-03-28 20:52 ` Jeff King
2012-03-28 20:42 ` Jonathan Nieder
2012-03-28 20:51 ` Jeff King
2012-03-28 21:01 ` Jonathan Nieder
2012-03-28 21:25 ` Jeff King
2012-03-28 21:30 ` Frans Klaver
2012-03-28 20:43 ` Junio C Hamano
2012-03-28 21:04 ` Jeff King
2012-03-28 21:44 ` Junio C Hamano
2012-03-28 21:57 ` Jeff King
2012-03-28 22:07 ` Jeff King
2012-03-28 22:18 ` Junio C Hamano
2012-03-29 11:31 ` Frans Klaver
2012-03-29 17:20 ` Jeff King
2012-03-29 17:23 ` Frans Klaver [this message]
2012-03-28 19:38 ` Jeff King
2012-03-28 18:29 ` Junio C Hamano
2012-03-28 19:40 ` Jeff King
2012-03-29 11:16 ` Frans Klaver
2012-03-29 17:15 ` Jeff King
2012-03-29 17:21 ` Frans Klaver
2012-03-27 6:14 ` Bug? Bad permissions in $PATH breaks Git aliases Johannes Sixt
2012-03-27 7:37 ` James Pickens
2012-03-27 15:14 ` Junio C Hamano
2012-03-27 17:48 ` James Pickens
2012-03-27 18:03 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=op.wbxzwyre0aolir@keputer \
--to=fransklaver@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jepicken@gmail.com \
--cc=jrnieder@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).