From: "Frans Klaver" <fransklaver@gmail.com>
To: "Junio C Hamano" <gitster@pobox.com>
Cc: "Jeff King" <peff@peff.net>,
git@vger.kernel.org, "James Pickens" <jepicken@gmail.com>
Subject: Re: [PATCH] run-command: treat inaccessible directories as ENOENT
Date: Fri, 30 Mar 2012 22:22:39 +0200 [thread overview]
Message-ID: <op.wbz2v2k60aolir@keputer> (raw)
In-Reply-To: <7vmx6ym54m.fsf@alter.siamese.dyndns.org>
On Fri, 30 Mar 2012 18:21:29 +0200, Junio C Hamano <gitster@pobox.com>
wrote:
> Frans Klaver <fransklaver@gmail.com> writes:
>
>> isn't it rather more sensible from a unit-test perspective to see
>> if start_command returns 127 instead of 128 in this specific case?
>
>
> You are welcome to add another test that checks lower level
> implementation
> detail, but this specific test is to make sure the gripe "Why does git
> deny my aliases when I have inaccessible directory on my PATH?" will
> never
> come back.
I think I didn't word carefully enough there. I didn't mean to dispute the
use of the test. The test I proposed would make sense in t0061, but I
would rather have expected the test in Jeff's patch in a tests that
specifically targets aliases. It would be less surprising, wouldn't it?
The fact that git goes through start_command before doing aliases is
merely an implementation detail, from my point of view.
next prev parent reply other threads:[~2012-03-30 20:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-30 7:52 [PATCH] run-command: treat inaccessible directories as ENOENT Jeff King
2012-03-30 8:23 ` Frans Klaver
2012-03-30 16:21 ` Junio C Hamano
2012-03-30 20:22 ` Frans Klaver [this message]
2012-03-30 16:18 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=op.wbz2v2k60aolir@keputer \
--to=fransklaver@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jepicken@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).