From: Linus Arver <linusa@google.com>
To: Jiang Xin <worldhello.net@gmail.com>,
Git List <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>
Cc: Jiang Xin <zhiyou.jx@alibaba-inc.com>
Subject: Re: [PATCH v5 0/6] support remote archive via stateless transport
Date: Sat, 20 Jan 2024 12:43:46 -0800 [thread overview]
Message-ID: <owly1qabhh19.fsf@fine.c.googlers.com> (raw)
In-Reply-To: <cover.1705411391.git.zhiyou.jx@alibaba-inc.com>
Jiang Xin <worldhello.net@gmail.com> writes:
This v5 looks good code-wise. I've made small suggestions to make the
commit messages better, but they are just nits and you are free to
ignore them.
If you choose to reroll one more time, one additional thing you could do
is to use the word "protocol_v2" in all commit messages because that's
how that term looks like in the code (unless the "protocol-v2" string is
already the standard term used elsewhere).
Thanks.
next prev parent reply other threads:[~2024-01-20 20:43 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-19 6:41 [PATCH 1/2] transport-helper: no connection restriction in connect_helper Jiang Xin
2023-09-19 6:41 ` [PATCH 2/2] archive: support remote archive from stateless transport Jiang Xin
2023-09-19 17:18 ` [PATCH 1/2] transport-helper: no connection restriction in connect_helper Junio C Hamano
2023-09-20 0:20 ` Jiang Xin
2023-09-23 15:21 ` [PATCH v2 0/3] support remote archive from stateless transport Jiang Xin
2023-09-25 22:21 ` Junio C Hamano
2023-09-26 0:43 ` Jiang Xin
2023-09-23 15:21 ` [PATCH v2 1/3] transport-helper: no connection restriction in connect_helper Jiang Xin
2023-09-25 21:11 ` Junio C Hamano
2023-09-23 15:22 ` [PATCH v2 2/3] transport-helper: run do_take_over " Jiang Xin
2023-09-25 21:34 ` Junio C Hamano
2023-10-04 14:00 ` Jiang Xin
2023-10-04 15:21 ` [PATCH v3 0/4] support remote archive from stateless transport Jiang Xin
2023-10-04 15:21 ` [PATCH v3 1/4] transport-helper: no connection restriction in connect_helper Jiang Xin
2023-10-04 15:21 ` [PATCH v3 2/4] transport-helper: call do_take_over() in process_connect Jiang Xin
2023-10-04 18:29 ` Junio C Hamano
2023-10-04 15:21 ` [PATCH v3 3/4] transport-helper: call do_take_over() in connect_helper Jiang Xin
2023-10-04 15:21 ` [PATCH v3 4/4] archive: support remote archive from stateless transport Jiang Xin
2023-12-14 14:13 ` [PATCH v4 0/4] support remote archive via " Jiang Xin
2023-12-14 14:13 ` [PATCH v4 1/4] transport-helper: no connection restriction in connect_helper Jiang Xin
2024-01-12 7:42 ` Linus Arver
2024-01-12 21:50 ` Junio C Hamano
2024-01-16 9:04 ` Jiang Xin
2024-01-18 22:26 ` Linus Arver
2024-01-19 10:56 ` Jiang Xin
2024-01-20 20:25 ` Linus Arver
2023-12-14 14:13 ` [PATCH v4 2/4] transport-helper: call do_take_over() in process_connect Jiang Xin
2023-12-14 14:13 ` [PATCH v4 3/4] transport-helper: call do_take_over() in connect_helper Jiang Xin
2024-01-12 7:56 ` Linus Arver
2024-01-16 9:41 ` Jiang Xin
2023-12-14 14:13 ` [PATCH v4 4/4] archive: support remote archive from stateless transport Jiang Xin
2024-01-12 8:12 ` Linus Arver
2024-01-16 13:39 ` [PATCH v5 0/6] support remote archive via " Jiang Xin
2024-01-16 13:39 ` [PATCH v5 1/6] transport-helper: no connection restriction in connect_helper Jiang Xin
2024-01-20 20:28 ` Linus Arver
2024-01-16 13:39 ` [PATCH v5 2/6] remote-curl: supports git-upload-archive service Jiang Xin
2024-01-20 20:30 ` Linus Arver
2024-01-16 13:39 ` [PATCH v5 3/6] transport-helper: protocol-v2 supports upload-archive Jiang Xin
2024-01-16 13:39 ` [PATCH v5 4/6] http-backend: new rpc-service for git-upload-archive Jiang Xin
2024-01-16 13:39 ` [PATCH v5 5/6] transport-helper: call do_take_over() in connect_helper Jiang Xin
2024-01-20 20:37 ` Linus Arver
2024-01-16 13:39 ` [PATCH v5 6/6] transport-helper: call do_take_over() in process_connect Jiang Xin
2024-01-20 20:43 ` Linus Arver [this message]
2024-01-21 4:09 ` [PATCH v5 0/6] support remote archive via stateless transport Jiang Xin
2024-01-21 13:15 ` [PATCH v6 " Jiang Xin
2024-01-21 13:15 ` [PATCH v6 1/6] transport-helper: no connection restriction in connect_helper Jiang Xin
2024-01-21 13:15 ` [PATCH v6 2/6] remote-curl: supports git-upload-archive service Jiang Xin
2024-01-21 13:15 ` [PATCH v6 3/6] transport-helper: protocol v2 supports upload-archive Jiang Xin
2024-01-21 13:15 ` [PATCH v6 4/6] http-backend: new rpc-service for git-upload-archive Jiang Xin
2024-01-21 13:15 ` [PATCH v6 5/6] transport-helper: call do_take_over() in connect_helper Jiang Xin
2024-01-21 13:15 ` [PATCH v6 6/6] transport-helper: call do_take_over() in process_connect Jiang Xin
2024-01-21 16:57 ` [PATCH v6 0/6] support remote archive via stateless transport Linus Arver
2024-01-22 15:54 ` Junio C Hamano
2023-09-23 15:22 ` [PATCH v2 3/3] archive: support remote archive from " Jiang Xin
2023-09-24 6:52 ` Eric Sunshine
2023-09-24 23:39 ` Jiang Xin
2023-09-24 23:58 ` rsbecker
2023-09-25 0:15 ` Jiang Xin
2023-09-25 1:04 ` rsbecker
2023-09-24 13:41 ` Phillip Wood
2023-09-24 23:36 ` Jiang Xin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=owly1qabhh19.fsf@fine.c.googlers.com \
--to=linusa@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=worldhello.net@gmail.com \
--cc=zhiyou.jx@alibaba-inc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).