git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Linus Arver <linusa@google.com>
To: Josh Soref <jsoref@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
	Josh Soref via GitGitGadget <gitgitgadget@gmail.com>,
	git@vger.kernel.org
Subject: Re: [PATCH] pretty-formats.txt: fix whitespace
Date: Tue, 26 Sep 2023 14:20:26 -0700	[thread overview]
Message-ID: <owlymsx8skbp.fsf@fine.c.googlers.com> (raw)
In-Reply-To: <CACZqfqC3HWOuveQdbpVEEO5KOwmnugvUmm6M0WpVu2MtUopm-w@mail.gmail.com>

Josh Soref <jsoref@gmail.com> writes:

> Linus Arver wrote:
>> FWIW we already have some guidelines about what is acceptable for doc
>> patches in SubmittingPatches:
>>
>>     We currently have a liberal mixture of US and UK English norms for
>>     spelling and grammar, which is somewhat unfortunate.  A huge patch that
>>     touches the files all over the place only to correct the inconsistency
>>     is not welcome, though.  Potential clashes with other changes that can
>>     result from such a patch are not worth it.  We prefer to gradually
>>     reconcile the inconsistencies in favor of US English, with small and
>>     easily digestible patches, as a side effect of doing some other real
>>     work in the vicinity (e.g. rewriting a paragraph for clarity, while
>>     turning en_UK spelling to en_US).  Obvious typographical fixes are much
>>     more welcomed ("teh -> "the"), preferably submitted as independent
>>     patches separate from other documentation changes.
>>
>> and both the 2-space vs 1-space and comma changes seem to fall into the
>> "not welcome" category.
>
> Ok, then, I think at this point I'll abandon this PR.
>
> I could probably find the time to justify rewriting one paragraph in
> this single file to try to abide by the requirements, but it doesn't
> seem worth it.

The change to make a paragraph read better (fixes to awkward wording,
for example) are very much appreciated and would be good as a follow-up
patch in its own right.

> I'm sorry I wasted everyone's time.

Please don't let this experience deter you from considering future
contributions to our documentation. Thanks.

  reply	other threads:[~2023-09-26 22:46 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-22 14:10 [PATCH] pretty-formats.txt: fix whitespace Josh Soref via GitGitGadget
2023-09-22 21:56 ` Junio C Hamano
2023-09-24 10:31   ` Josh Soref
2023-09-25 17:24     ` Junio C Hamano
2023-09-26 18:52     ` Linus Arver
2023-09-26 19:51       ` Josh Soref
2023-09-26 21:20         ` Linus Arver [this message]
2023-09-25 20:04 ` Kristoffer Haugsbakk
2023-09-26  2:51   ` Josh Soref
2023-09-26 16:42     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=owlymsx8skbp.fsf@fine.c.googlers.com \
    --to=linusa@google.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=gitster@pobox.com \
    --cc=jsoref@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).