git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: git cvsimport and case-insensitive config
Date: Wed, 31 Mar 2010 13:17:01 +0200	[thread overview]
Message-ID: <p2mcb7bb73a1003310417u3821f8b1hd3df79e8b41502c3@mail.gmail.com> (raw)
In-Reply-To: <7v634cq0yj.fsf@alter.siamese.dyndns.org>

On Wed, Mar 31, 2010 at 11:45 AM, Junio C Hamano <gitster@pobox.com> wrote:
> Giuseppe Bilotta <giuseppe.bilotta@gmail.com> writes:
>
>> What I wonder is: when would the heuristics not work? Are there git
>> repositories that have a cvsimport configuration with both -s and -S
>> specified?
>
> You are asking a wrong question.  Setting both -s and -S is not an issue.
> Not being able to tell reliably if the value you see for cvsimport.s in
> "config -l" output were specified for cvsimport.S or cvsimport.s is only
> by inspecting the value is.

What I'm asking is rahter: is it worth to worry about this?

>> I strongly suspect the answer is NO because such a
>> configuration would not work currently (at least not reliably as the
>> wrong value would be assigned to at least one of the keys.
>
> So this is a moot point, but people who specified cvsimport.S expecting
> that it would stand for -S option are not getting what they want and are
> getting -s instead, which is also a case where the configuration is not
> working currently.
>
> Silently converting it to an equally non-working configuration is easy;
> just treat as if everything were specified for lowercase option.
>
> But that would not help users at all.  I was hoping that you were aiming
> for something better than that.  At least that "case-sensitive" patch was.

Well, I wasn't thinking about a silent conversion for the uncertain
options: in the case of dubious options which we can guess (a vs A, r
vs R), a warning would be given, and for the unguessable case we could
either still give a warning and continue or even abort the process
altogether. Better than the silent conversion (which would not break
anything that isn't broken already anyway), although probably not as
sophisticated as your proposal.

-- 
Giuseppe "Oblomov" Bilotta

      reply	other threads:[~2010-03-31 11:17 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-30  8:32 git cvsimport and case-insensitive config Giuseppe Bilotta
2010-03-30 17:29 ` Junio C Hamano
2010-03-30 18:05   ` Giuseppe Bilotta
2010-03-30 21:20     ` Junio C Hamano
2010-03-30 22:17       ` Giuseppe Bilotta
2010-03-30 23:14         ` Junio C Hamano
2010-03-31  6:54           ` Giuseppe Bilotta
2010-03-31  9:45             ` Junio C Hamano
2010-03-31 11:17               ` Giuseppe Bilotta [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=p2mcb7bb73a1003310417u3821f8b1hd3df79e8b41502c3@mail.gmail.com \
    --to=giuseppe.bilotta@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).