From: Matthias Urlichs <smurf@smurf.noris.de>
To: git@vger.kernel.org
Subject: [PATCH] cvsimport-in-Perl: Limit the number of arguments to git-update-cache
Date: Thu, 30 Jun 2005 12:34:00 +0200 [thread overview]
Message-ID: <pan.2005.06.30.10.34.00.807346@smurf.noris.de> (raw)
In-Reply-To: pan.2005.06.28.19.23.08.307486@smurf.noris.de
A small fix to git-cvsimport-script:
Limit the number of arguments to git-update-cache.
(Limiting their length may make a bit more sense, but I'm lazy.)
Signed-Off-By: Matthias Urlichs <smurf@smurf.noris.de>
---
diff --git a/git-cvsimport-script b/git-cvsimport-script
--- a/git-cvsimport-script
+++ b/git-cvsimport-script
@@ -395,14 +395,32 @@ my $state = 0;
my($patchset,$date,$author,$branch,$ancestor,$tag,$logmsg);
my(@old,@new);
my $commit = sub {
my $pid;
- system("git-update-cache","--force-remove","--",@old) if @old;
- die "Cannot remove files: $?\n" if $?;
- system("git-update-cache","--add","--",@new) if @new;
- die "Cannot add files: $?\n" if $?;
+ while(@old) {
+ my @o2;
+ if(@old > 55) {
+ @o2 = splice(@old,0,50);
+ } else {
+ @o2 = @old;
+ @old = ();
+ }
+ system("git-update-cache","--force-remove","--",@o2);
+ die "Cannot remove files: $?\n" if $?;
+ }
+ while(@new) {
+ my @n2;
+ if(@new > 55) {
+ @n2 = splice(@new,0,50);
+ } else {
+ @n2 = @new;
+ @new = ();
+ }
+ system("git-update-cache","--add","--",@n2);
+ die "Cannot add files: $?\n" if $?;
+ }
$pid = open(C,"-|");
die "Cannot fork: $!" unless defined $pid;
unless($pid) {
exec("git-write-tree");
@@ -478,13 +496,10 @@ my $commit = sub {
or die "Cannot write tag $branch: $!\n";
close(C)
or die "Cannot write tag $branch: $!\n";
print "Created tag '$tag' on '$branch'\n" if $opt_v;
}
-
- @old = ();
- @new = ();
};
while(<CVS>) {
chomp;
if($state == 0 and /^-+$/) {
next prev parent reply other threads:[~2005-06-30 10:36 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-28 19:23 [PATCH] cvsimport: rewritten in Perl Matthias Urlichs
2005-06-29 15:06 ` Nicolas Pitre
2005-06-29 20:40 ` Matthias Urlichs
2005-06-30 10:30 ` Matthias Urlichs
2005-06-30 16:48 ` Nicolas Pitre
2005-06-30 10:34 ` Matthias Urlichs [this message]
2005-06-30 16:54 ` [PATCH] cvsimport-in-Perl: Limit the number of arguments to git-update-cache Nicolas Pitre
2005-06-30 17:15 ` Nicolas Pitre
2005-06-30 18:02 ` Matthias Urlichs
2005-06-30 14:55 ` [PATCH] cvsimport: perform string comparison on "HEAD" Sven Verdoolaege
2005-06-30 15:21 ` Matthias Urlichs
2005-06-30 16:38 ` [PATCH] cvsimport: Limit the log string to 32k Matthias Urlichs
2005-06-30 15:02 ` [PATCH] cvsimport: rewritten in Perl Sven Verdoolaege
2005-06-30 15:21 ` Matthias Urlichs
2005-06-30 15:44 ` Sven Verdoolaege
2005-06-30 16:10 ` Matthias Urlichs
2005-06-30 16:14 ` Sven Verdoolaege
2005-06-30 16:30 ` Matthias Urlichs
2005-06-30 17:22 ` Nicolas Pitre
2005-07-01 9:43 ` Matthias Urlichs
2005-07-03 10:35 ` Sven Verdoolaege
2005-07-03 10:36 ` [PATCH] Make specification of CVS module to convert optional Sven Verdoolaege
2005-07-03 10:37 ` git-cvsimport-script: clean up documentation Sven Verdoolaege
2005-07-03 11:37 ` git-cvsimport-script: Honour CVS_SERVER Sven Verdoolaege
2005-07-03 11:38 ` [PATCH] git-cvsimport-script: Support :ext: access method Sven Verdoolaege
2005-07-03 12:21 ` cvsimport: rewritten in Perl Sven Verdoolaege
2005-07-03 13:44 ` Matthias Urlichs
2005-07-05 23:02 ` Wolfgang Denk
2005-07-06 2:41 ` Linus Torvalds
2005-07-06 6:37 ` Sven Verdoolaege
2005-07-06 7:32 ` Matthias Urlichs
2005-07-06 10:24 ` Wolfgang Denk
2005-07-04 12:13 ` [PATCH] git-cvsimport-script: leave working directory alone Sven Verdoolaege
2005-07-04 12:13 ` [PATCH] git-cvsimport-script: use private index Sven Verdoolaege
2005-07-04 14:06 ` [PATCH] git-cvsimport-script: fix branch switching Sven Verdoolaege
2005-07-04 14:09 ` [PATCH] git-cvsimport-script: update cvsps cache instead of rebuilding it Sven Verdoolaege
2005-06-30 19:38 ` [PATCH] cvsimport: rewritten in Perl Sven Verdoolaege
2005-06-30 21:00 ` Matthias Urlichs
2005-07-01 7:01 ` Sven Verdoolaege
2005-07-01 7:25 ` Matthias Urlichs
2005-07-04 13:03 ` Sven Verdoolaege
2005-07-04 13:53 ` Matthias Urlichs
2005-07-04 13:46 ` Sven Verdoolaege
2005-07-04 14:36 ` Matthias Urlichs
2005-07-04 15:52 ` Sven Verdoolaege
2005-07-03 23:03 ` Sven Verdoolaege
2005-07-04 1:49 ` Matthias Urlichs
2005-07-04 10:47 ` Sven Verdoolaege
2005-06-30 18:48 ` Stephen C. Tweedie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=pan.2005.06.30.10.34.00.807346@smurf.noris.de \
--to=smurf@smurf.noris.de \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox