From: "Oscar Dominguez via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: Oscar Dominguez <dominguez.celada@gmail.com>,
Oscar Dominguez <dominguez.celada@gmail.com>
Subject: [PATCH v2] ci(main): upgrade actions/checkout to v3
Date: Mon, 05 Dec 2022 10:01:14 +0000 [thread overview]
Message-ID: <pull.1354.v2.git.git.1670234474721.gitgitgadget@gmail.com> (raw)
In-Reply-To: <pull.1354.git.git.1665388136.gitgitgadget@gmail.com>
From: Oscar Dominguez <dominguez.celada@gmail.com>
To be up to date with actions/checkout opens the door to use the latest
features if necessary and get the latest security patches.
This also avoids a couple of deprecation warnings in the CI runs.
Note: The `actions/checkout` Action has been known to be broken in i686
containers as of v2, therefore we keep forcing it to v1 there. See
actions/runner#2115 for more details.
Signed-off-by: Oscar Dominguez <dominguez.celada@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
ci(main): upgrade actions/checkout to v3
Description
===========
Upgrades actions/checkout to v3 in .github/workflows/main.yml
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-1354%2Foscard0m%2Fpatch-1-v2
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-1354/oscard0m/patch-1-v2
Pull-Request: https://github.com/git/git/pull/1354
Range-diff vs v1:
1: 2dbb779f7fd ! 1: 26fad15f97a ci(main): upgrade actions/checkout to v3
@@ Metadata
## Commit message ##
ci(main): upgrade actions/checkout to v3
- to be up to date with actions/checkout opens the door to use the latest
+ To be up to date with actions/checkout opens the door to use the latest
features if necessary and get the latest security patches.
- Signed-off-by: Oscar Dominguez Celada <dominguez.celada@gmail.com>
+ This also avoids a couple of deprecation warnings in the CI runs.
+
+ Note: The `actions/checkout` Action has been known to be broken in i686
+ containers as of v2, therefore we keep forcing it to v1 there. See
+ actions/runner#2115 for more details.
+
+ Signed-off-by: Oscar Dominguez <dominguez.celada@gmail.com>
+ Signed-off-by: Junio C Hamano <gitster@pobox.com>
+ Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
## .github/workflows/main.yml ##
@@ .github/workflows/main.yml: jobs:
@@ .github/workflows/main.yml: jobs:
runs-on: ubuntu-latest
container: ${{matrix.vector.image}}
steps:
-- - uses: actions/checkout@v1
+ - uses: actions/checkout@v3
++ if: matrix.vector.jobname != 'linux32'
+ - uses: actions/checkout@v1
++ if: matrix.vector.jobname == 'linux32'
- run: ci/install-docker-dependencies.sh
- run: ci/run-build-and-tests.sh
- name: print test failures
2: 4ee163b9a2c < -: ----------- ci(main): linux32 uses actions/checkout@v2
.github/workflows/main.yml | 17 ++++++++++-------
1 file changed, 10 insertions(+), 7 deletions(-)
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
index 831f4df56c5..5262823eb1c 100644
--- a/.github/workflows/main.yml
+++ b/.github/workflows/main.yml
@@ -83,7 +83,7 @@ jobs:
if: needs.ci-config.outputs.enabled == 'yes'
runs-on: windows-latest
steps:
- - uses: actions/checkout@v2
+ - uses: actions/checkout@v3
- uses: git-for-windows/setup-git-for-windows-sdk@v1
- name: build
shell: bash
@@ -138,10 +138,10 @@ jobs:
GIT_CONFIG_PARAMETERS: "'user.name=CI' 'user.email=ci@git'"
runs-on: windows-latest
steps:
- - uses: actions/checkout@v2
+ - uses: actions/checkout@v3
- uses: git-for-windows/setup-git-for-windows-sdk@v1
- name: initialize vcpkg
- uses: actions/checkout@v2
+ uses: actions/checkout@v3
with:
repository: 'microsoft/vcpkg'
path: 'compat/vcbuild/vcpkg'
@@ -258,7 +258,7 @@ jobs:
runs_on_pool: ${{matrix.vector.pool}}
runs-on: ${{matrix.vector.pool}}
steps:
- - uses: actions/checkout@v2
+ - uses: actions/checkout@v3
- run: ci/install-dependencies.sh
- run: ci/run-build-and-tests.sh
- name: print test failures
@@ -291,7 +291,10 @@ jobs:
runs-on: ubuntu-latest
container: ${{matrix.vector.image}}
steps:
+ - uses: actions/checkout@v3
+ if: matrix.vector.jobname != 'linux32'
- uses: actions/checkout@v1
+ if: matrix.vector.jobname == 'linux32'
- run: ci/install-docker-dependencies.sh
- run: ci/run-build-and-tests.sh
- name: print test failures
@@ -311,7 +314,7 @@ jobs:
jobname: StaticAnalysis
runs-on: ubuntu-22.04
steps:
- - uses: actions/checkout@v2
+ - uses: actions/checkout@v3
- run: ci/install-dependencies.sh
- run: ci/run-static-analysis.sh
- run: ci/check-directional-formatting.bash
@@ -331,7 +334,7 @@ jobs:
artifact: sparse-20.04
- name: Install the current `sparse` package
run: sudo dpkg -i sparse-20.04/sparse_*.deb
- - uses: actions/checkout@v2
+ - uses: actions/checkout@v3
- name: Install other dependencies
run: ci/install-dependencies.sh
- run: make sparse
@@ -343,6 +346,6 @@ jobs:
jobname: Documentation
runs-on: ubuntu-latest
steps:
- - uses: actions/checkout@v2
+ - uses: actions/checkout@v3
- run: ci/install-dependencies.sh
- run: ci/test-documentation.sh
base-commit: bcd6bc478adc4951d57ec597c44b12ee74bc88fb
--
gitgitgadget
next prev parent reply other threads:[~2022-12-05 10:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-10 7:48 [PATCH 0/2] ci(main): upgrade actions/checkout to v3 Oscar Dominguez via GitGitGadget
2022-10-10 7:48 ` [PATCH 1/2] " Oscar Dominguez via GitGitGadget
2022-10-10 20:55 ` Junio C Hamano
2022-10-10 7:48 ` [PATCH 2/2] ci(main): linux32 uses actions/checkout@v2 Oscar Dominguez via GitGitGadget
2022-10-10 21:00 ` Junio C Hamano
2022-10-10 21:43 ` Junio C Hamano
2022-12-05 10:01 ` Oscar Dominguez via GitGitGadget [this message]
2022-12-05 23:28 ` [PATCH v2] ci(main): upgrade actions/checkout to v3 Junio C Hamano
2022-12-06 8:24 ` [PATCH] ci: use actions/{upload,download}-artifact@v3 Junio C Hamano
2022-12-06 21:21 ` Johannes Schindelin
2022-12-06 23:41 ` Junio C Hamano
2022-12-07 0:35 ` Junio C Hamano
2022-12-07 12:33 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=pull.1354.v2.git.git.1670234474721.gitgitgadget@gmail.com \
--to=gitgitgadget@gmail.com \
--cc=dominguez.celada@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).