From: "Harshil Jani via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Harshil Jani <harshiljani2002@gmail.com>
Subject: [PATCH v2 0/2] Remove MSys Support
Date: Thu, 02 Feb 2023 03:51:36 +0000 [thread overview]
Message-ID: <pull.1433.v2.git.1675309898.gitgitgadget@gmail.com> (raw)
In-Reply-To: <pull.1433.git.1670274213.gitgitgadget@gmail.com>
I am trying to learn more about the git code base and came across the issue
where the support of MSys environment was to be dropped. This patch is my
first contribution towards it.
The msysGit and the MSys v1.x has been dropped into this patch and the
USE_NED_ALLOCATOR variable was duplicated here in the implementation so its
deduplication was also made in this patch.
Signed-off-by: Harshil-Jani harshiljani2002@gmail.com
Harshil-Jani (2):
mingw: remove duplicate `USE_NED_ALLOCATOR` directive
mingw: remove msysGit/MSYS1 support
config.mak.uname | 86 ++++++++++++++++++++----------------------------
1 file changed, 35 insertions(+), 51 deletions(-)
base-commit: 35a62bb5798092d491e6c7e688db6cb1418c9098
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1433%2FHarshil-Jani%2Fdrop-Msys-v2
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1433/Harshil-Jani/drop-Msys-v2
Pull-Request: https://github.com/gitgitgadget/git/pull/1433
Range-diff vs v1:
1: bc79dfcc4d4 = 1: bc79dfcc4d4 mingw: remove duplicate `USE_NED_ALLOCATOR` directive
2: e6d3d280a4f ! 2: 0c0289343fb mingw: remove msysGit/MSYS1 support
@@ Metadata
## Commit message ##
mingw: remove msysGit/MSYS1 support
- The msysGit (i.e. Git for Windows 1.x' SDK) is no longer used and the
- last known user for MSys1 + MinGW has switched to MSys2. So there was no
- reason to keep the msysGit/MSys1 config section. This Patch intends to
- remove the support of both the builds and throw an error on
- execution.
-
- The output of `uname -r` if returns us with '1.' then it relates with MSys1
- build environment and msysGit which we don't want to continue ahead and thus
- an error can be expected.
-
- The MSYS2 is currently used into the MinGW so we can get that part
- running directly without any conditionals required.
+ MSys has long fallen behind MSYS2 in features like Unicode or
+ x86_64 support or even security bug fixes, and is therefore no
+ longer used by anyone in the Git developer community. The Git for
+ Windows project itself started switching from MSys to MSYS2 early
+ in 2015, i.e. about eight years ago. Let's drop supporting MSys as
+ a development platform.
Signed-off-by: Harshil-Jani <harshiljani2002@gmail.com>
--
gitgitgadget
next prev parent reply other threads:[~2023-02-02 3:51 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-05 21:03 [PATCH 0/2] Remove MSys Support Harshil Jani via GitGitGadget
2022-12-05 21:03 ` [PATCH 1/2] mingw: remove duplicate `USE_NED_ALLOCATOR` directive Harshil-Jani via GitGitGadget
2022-12-18 1:54 ` Junio C Hamano
2022-12-05 21:03 ` [PATCH 2/2] mingw: remove msysGit/MSYS1 support Harshil-Jani via GitGitGadget
2022-12-18 2:11 ` Junio C Hamano
2022-12-18 3:58 ` Junio C Hamano
2023-01-09 7:48 ` Johannes Schindelin
2023-01-09 8:52 ` Junio C Hamano
2022-12-18 2:15 ` [PATCH 0/2] Remove MSys Support Junio C Hamano
2023-01-09 7:36 ` Johannes Schindelin
2023-01-09 8:49 ` Junio C Hamano
2023-02-02 3:51 ` Harshil Jani via GitGitGadget [this message]
2023-02-02 3:51 ` [PATCH v2 1/2] mingw: remove duplicate `USE_NED_ALLOCATOR` directive Harshil-Jani via GitGitGadget
2023-02-02 3:51 ` [PATCH v2 2/2] mingw: remove msysGit/MSYS1 support Harshil-Jani via GitGitGadget
2023-02-02 13:59 ` [PATCH v2 0/2] Remove MSys Support Johannes Schindelin
2023-02-02 16:06 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=pull.1433.v2.git.1675309898.gitgitgadget@gmail.com \
--to=gitgitgadget@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=harshiljani2002@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).